Last Comment Bug 758911 - convert mail/base/content/mailCore.js to Services.jsm
: convert mail/base/content/mailCore.js to Services.jsm
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 15.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks: 720356 718139
  Show dependency treegraph
 
Reported: 2012-05-26 14:47 PDT by :aceman
Modified: 2012-06-05 13:01 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (16.05 KB, patch)
2012-05-26 15:46 PDT, :aceman
mkmelin+mozilla: review+
Details | Diff | Review
patch v2 (16.05 KB, patch)
2012-05-29 13:21 PDT, :aceman
acelists: review+
Details | Diff | Review
patch v3 (12.67 KB, patch)
2012-05-30 12:54 PDT, :aceman
acelists: review+
Details | Diff | Review

Description :aceman 2012-05-26 14:47:28 PDT
let prefSvc = Components.classes["@mozilla.org/preferences-service;1"]
var windowManager = Cc['@mozilla.org/appshell/window-mediator;1'].getService();
var windowManager = Cc['@mozilla.org/appshell/window-mediator;1'].getService();
var prefsService = Components.classes["@mozilla.org/preferences-service;1"].getService(Components.interfaces.nsIPrefService).getBranch(null);
var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
var urlToOpen = Components.classes["@mozilla.org/toolkit/URLFormatterService;1"]
var uri = Components.classes["@mozilla.org/network/io-service;1"]
let wm = Cc["@mozilla.org/appshell/window-mediator;1"]
Comment 1 :aceman 2012-05-26 15:46:12 PDT
Created attachment 627513 [details] [diff] [review]
patch
Comment 2 Magnus Melin 2012-05-29 13:14:30 PDT
Comment on attachment 627513 [details] [diff] [review]
patch

Review of attachment 627513 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, aceman! r=mkmelin

::: mail/base/content/mailCore.js
@@ +403,5 @@
>        // This is complicated because showPane is asynchronous (it could trigger a dynamic overlay)
>        // so our tab element may not be accessible right away...
>      }
>    }
> +  else

Nit: this else should also have braces
Comment 3 :aceman 2012-05-29 13:21:49 PDT
Created attachment 628087 [details] [diff] [review]
patch v2

Thanks.
I am going to touch that exact function in bug 718139, but no problem.
Comment 4 :aceman 2012-05-30 12:54:22 PDT
Created attachment 628430 [details] [diff] [review]
patch v3

MPL2 bitrot.
Comment 5 Mike Conley (:mconley) - (Away until June 29th) 2012-05-31 12:17:41 PDT
Landed in comm-central as https://hg.mozilla.org/comm-central/rev/9e53fb1e5d22

Note You need to log in before you can comment on or make changes to this bug.