The default bug view has changed. See this FAQ.

convert mail/base/content/mailCore.js to Services.jsm

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Mail Window Front End
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 15.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

12.67 KB, patch
aceman
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
let prefSvc = Components.classes["@mozilla.org/preferences-service;1"]
var windowManager = Cc['@mozilla.org/appshell/window-mediator;1'].getService();
var windowManager = Cc['@mozilla.org/appshell/window-mediator;1'].getService();
var prefsService = Components.classes["@mozilla.org/preferences-service;1"].getService(Components.interfaces.nsIPrefService).getBranch(null);
var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
var urlToOpen = Components.classes["@mozilla.org/toolkit/URLFormatterService;1"]
var uri = Components.classes["@mozilla.org/network/io-service;1"]
let wm = Cc["@mozilla.org/appshell/window-mediator;1"]
(Assignee)

Comment 1

5 years ago
Created attachment 627513 [details] [diff] [review]
patch
Attachment #627513 - Flags: review?(mkmelin+mozilla)

Comment 2

5 years ago
Comment on attachment 627513 [details] [diff] [review]
patch

Review of attachment 627513 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, aceman! r=mkmelin

::: mail/base/content/mailCore.js
@@ +403,5 @@
>        // This is complicated because showPane is asynchronous (it could trigger a dynamic overlay)
>        // so our tab element may not be accessible right away...
>      }
>    }
> +  else

Nit: this else should also have braces
Attachment #627513 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 628087 [details] [diff] [review]
patch v2

Thanks.
I am going to touch that exact function in bug 718139, but no problem.
Attachment #627513 - Attachment is obsolete: true
Attachment #628087 - Flags: review+
(Assignee)

Updated

5 years ago
Blocks: 718139
Keywords: checkin-needed
(Assignee)

Comment 4

5 years ago
Created attachment 628430 [details] [diff] [review]
patch v3

MPL2 bitrot.
Attachment #628087 - Attachment is obsolete: true
Attachment #628430 - Flags: review+
Landed in comm-central as https://hg.mozilla.org/comm-central/rev/9e53fb1e5d22
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.