758911 - convert mail/base/content/mailCore.js to Services.jsm

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[:aceman]

let prefSvc = Components.classes["@mozilla.org/preferences-service;1"]
var windowManager = Cc['@mozilla.org/appshell/window-mediator;1'].getService();
var windowManager = Cc['@mozilla.org/appshell/window-mediator;1'].getService();
var prefsService = Components.classes["@mozilla.org/preferences-service;1"].getService(Components.interfaces.nsIPrefService).getBranch(null);
var wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
var urlToOpen = Components.classes["@mozilla.org/toolkit/URLFormatterService;1"]
var uri = Components.classes["@mozilla.org/network/io-service;1"]
let wm = Cc["@mozilla.org/appshell/window-mediator;1"]

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 627513 [details] [diff] [review]
patch

Review of attachment 627513 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, aceman! r=mkmelin

::: mail/base/content/mailCore.js
@@ +403,5 @@
>        // This is complicated because showPane is asynchronous (it could trigger a dynamic overlay)
>        // so our tab element may not be accessible right away...
>      }
>    }
> +  else

Nit: this else should also have braces

Comment 3

[:aceman]

Attachment: patch v2

Thanks.
I am going to touch that exact function in bug 718139, but no problem.

Comment 4

[:aceman]

Attachment: patch v3

MPL2 bitrot.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Landed in comm-central as https://hg.mozilla.org/comm-central/rev/9e53fb1e5d22