760163 - Bugmail for dependency change showed a referenced bug that wasn't mentioned

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Ed Morley [:emorley]]

Just got this bugmail:

Subject: [Bug 695480] Remove support for Chrome -> Content leaks
Date: Thu, 31 May 2012 15:49:45 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Classification: Components
X-Bugzilla-Product: Core
X-Bugzilla-Component: DOM
X-Bugzilla-Keywords: dev-doc-needed
X-Bugzilla-Severity: normal
X-Bugzilla-Who: tschnei...<snip>@gmail.com
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: --
X-Bugzilla-Assigned-To: khuey@<snip>.com
X-Bugzilla-Target-Milestone: mozilla15
X-Bugzilla-Changed-Fields: 
Message-ID: <[e-mail]/>
In-Reply-To: <[e-mail]/>
References: <[e-mail]/>
X-Bugzilla-URL: https://bugzilla.mozilla.org/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0

https://bugzilla.mozilla.org/show_bug.cgi?id=695480

Bug 695480 depends on bug 752468, which changed state.

https://bugzilla.mozilla.org/show_bug.cgi?id=752468

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

Referenced Bugs:

https://bugzilla.mozilla.org/show_bug.cgi?id=749159
[Bug 749159] Lots of recent failures with "Modal dialog has been found and
processed"
https://bugzilla.mozilla.org/show_bug.cgi?id=752468
[Bug 752468] Visual Hashing addon causes every website visited to be
retained as a ghost window

-- 
Configure bugmail: https://bugzilla.mozilla.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

========================

Bug 749159 wasn't changed or mentioned at all, but yet was (as you can see above) in the "Referenced Bugs" list.

Comment 1

[David Lawrence [:dkl]]

At quick glance, I cannot see anything in the code that could be causing this although it could be related to the corruption in bugs_activity causing the query in BugMail.pm line 236 to return incorrect results. If so this may go away once bugs_activity is back to normal some day.

dkl

Comment 2

[:glob ✱]

Attachment: patch v1

what's happening is the code which scans for dependent bug changes uses a time-frame of the bug's last-diff to the current change, with perl code excluding changes.

in this case the query would be '2012-05-16 02:18:10 PDT' to '2012-05-31 08:49:38 PDT'.  the dependency_diffs query returns any bugs which had their status or resolution changed within this range, which includes 749159 at '2012-05-29 10:30:37 PDT'.

currently we always push all these bugs onto referenced_bugs.

this patch changes it to only push when the change is interesting, ie. when is_open_state() changes.  as 749159's status wasn't changed, it should be excluded by this patch.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 629044 [details] [diff] [review]
patch v1

Review of attachment 629044 [details] [diff] [review]:
-----------------------------------------------------------------

Make sense. r=dkl

Comment 4

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified Bugzilla/BugMail.pm
Committed revision 8202.

Comment 5

[Steffen Wilberg]

Reopening:

Subject: [Bug 307181] Eliminate wait while restarting Firefox after update
 (apply update in background)
Date: Wed, 06 Jun 2012 13:48:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Classification: Components
X-Bugzilla-Product: Toolkit
X-Bugzilla-Component: Application Update
X-Bugzilla-Keywords: #relman/triage/defer-to-group, dev-doc-needed,
 sec-review-complete, user-doc-needed
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: [e-mail]
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Priority: --
X-Bugzilla-Assigned-To: [e-mail]
X-Bugzilla-Target-Milestone: mozilla15
X-Bugzilla-Changed-Fields: Depends on
Message-ID: <[e-mail]/>
In-Reply-To: <[e-mail]/>
References: <[e-mail]/>
X-Bugzilla-URL: https://bugzilla.mozilla.org/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Envelope-To: <[e-mail]>
X-UI-Filterresults: ;V01:K0:BOp+R3XE:AO8vd6IveH9ZinqCW2RMmpoCTSt8tomawhd
 dyFHxOAIsrW4Klql6Z7dT2qkGB7WPd6/FaadVw0nVnfHAQZDYRj9tcLYjNmruRu7q03zv4j
 0m6RfGVeWXmUfezJ1XKd1m1SJezfFXmJ+MU4Tiat+k+STCK/FXwIr1X1ULJYwEibA=

https://bugzilla.mozilla.org/show_bug.cgi?id=307181

Ed Morley (Back 6th June) [:edmorley] <[e-mail]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |762032

Referenced Bugs:

https://bugzilla.mozilla.org/show_bug.cgi?id=760577
[Bug 760577] Keep the mar file around when staging an update in the
background
https://bugzilla.mozilla.org/show_bug.cgi?id=762032
[Bug 762032] Intermittent test_0201_app_launch_apply_update.js |
WindowsError: [Error 13] The process cannot access the file because it is
being used by another process:
'...\\appdata\\local\\temp\\tmpnvfhv6\\ExecutableDir.tmp\\bin\\uninstall\\helper.exe'

Comment 6

[Reed Loden [:reed]]

The push to prod only occurs once a week (on Thursday nights, iirc). Wait until you see the current-production tag above a rev that includes the fix (https://bzr.mozilla.org/bmo/4.0/changes).