If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Thunderbird release mozconfigs should take revision arguments from the environment

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 15.0
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird13+ fixed, thunderbird14+ fixed, thunderbird-esr1013+ fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 629109 [details] [diff] [review]
The fix

In the ESR release build, we realised client.py wasn't being passed the revision of mozilla-* to be building with. This was causing the wrong gecko version to be reported in the final binary build, and could lead to confusion in beta/release builds in future (different things included than expected).

The simple fix to this is to add --comm-rev=${COMM_REV} --mozilla-rev=${MOZILLA_REV} to the release mozconfigs on the CLIENT_PY_ARGS line. The release binary builders already have the relevant items set in the environment.
Attachment #629109 - Flags: review?(nrthomas)
(Assignee)

Updated

5 years ago
Blocks: 744599
(Assignee)

Comment 1

5 years ago
Created attachment 629114 [details] [diff] [review]
Branch patch

Additional patch for all the branches, just fixes bitrot.
Attachment #629114 - Flags: review?(nrthomas)

Updated

5 years ago
Attachment #629114 - Flags: review?(nrthomas) → review+

Updated

5 years ago
Attachment #629109 - Flags: review?(nrthomas) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 629114 [details] [diff] [review]
Branch patch

[Triage Comment]
We need this on esr10 and release to fix bustage, we'll also need it on aurora for the next cycle, beta isn't necessary as that's not needed now.
Attachment #629114 - Flags: approval-comm-release+
Attachment #629114 - Flags: approval-comm-esr10+
Attachment #629114 - Flags: approval-comm-aurora+
(Assignee)

Comment 3

5 years ago
Checked in:

https://hg.mozilla.org/comm-central/rev/c47b65544536
https://hg.mozilla.org/releases/comm-aurora/rev/443af4372453
https://hg.mozilla.org/releases/comm-release/rev/b43356d5b161
https://hg.mozilla.org/releases/comm-esr10/rev/939269a86b88 (relbranch for 10.0.5esr)
https://hg.mozilla.org/releases/comm-esr10/rev/c67d6fbb3373
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird13: --- → fixed
status-thunderbird14: --- → fixed
status-thunderbird-esr10: --- → fixed
tracking-thunderbird13: --- → +
tracking-thunderbird14: --- → +
tracking-thunderbird-esr10: --- → 13+
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
We should follow this up with a fix to the whitelist in release_sanity.py.
status-thunderbird13: fixed → ---
status-thunderbird14: fixed → ---
status-thunderbird-esr10: fixed → ---
tracking-thunderbird13: + → ---
tracking-thunderbird14: + → ---
tracking-thunderbird-esr10: 13+ → ---
Target Milestone: Thunderbird 15.0 → ---
(Assignee)

Updated

5 years ago
status-thunderbird13: --- → fixed
status-thunderbird14: --- → fixed
status-thunderbird-esr10: --- → fixed
tracking-thunderbird13: --- → +
tracking-thunderbird14: --- → +
tracking-thunderbird-esr10: --- → 13+
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.