760390 - Thunderbird release mozconfigs should take revision arguments from the environment

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

In the ESR release build, we realised client.py wasn't being passed the revision of mozilla-* to be building with. This was causing the wrong gecko version to be reported in the final binary build, and could lead to confusion in beta/release builds in future (different things included than expected).

The simple fix to this is to add --comm-rev=${COMM_REV} --mozilla-rev=${MOZILLA_REV} to the release mozconfigs on the CLIENT_PY_ARGS line. The release binary builders already have the relevant items set in the environment.

Comment 1

[Mark Banner (:standard8)]

Attachment: Branch patch

Additional patch for all the branches, just fixes bitrot.

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 629114 [details] [diff] [review]
Branch patch

[Triage Comment]
We need this on esr10 and release to fix bustage, we'll also need it on aurora for the next cycle, beta isn't necessary as that's not needed now.

Comment 3

[Mark Banner (:standard8)]

Checked in:

https://hg.mozilla.org/comm-central/rev/c47b65544536
https://hg.mozilla.org/releases/comm-aurora/rev/443af4372453
https://hg.mozilla.org/releases/comm-release/rev/b43356d5b161
https://hg.mozilla.org/releases/comm-esr10/rev/939269a86b88 (relbranch for 10.0.5esr)
https://hg.mozilla.org/releases/comm-esr10/rev/c67d6fbb3373

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

We should follow this up with a fix to the whitelist in release_sanity.py.