Closed Bug 760390 Opened 7 years ago Closed 7 years ago

Thunderbird release mozconfigs should take revision arguments from the environment

Categories

(Thunderbird :: Build Config, defect)

defect
Not set

Tracking

(thunderbird13+ fixed, thunderbird14+ fixed, thunderbird-esr1013+ fixed)

RESOLVED FIXED
Thunderbird 15.0
Tracking Status
thunderbird13 + fixed
thunderbird14 + fixed
thunderbird-esr10 13+ fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Attached patch The fixSplinter Review
In the ESR release build, we realised client.py wasn't being passed the revision of mozilla-* to be building with. This was causing the wrong gecko version to be reported in the final binary build, and could lead to confusion in beta/release builds in future (different things included than expected).

The simple fix to this is to add --comm-rev=${COMM_REV} --mozilla-rev=${MOZILLA_REV} to the release mozconfigs on the CLIENT_PY_ARGS line. The release binary builders already have the relevant items set in the environment.
Attachment #629109 - Flags: review?(nrthomas)
Blocks: 744599
Attached patch Branch patchSplinter Review
Additional patch for all the branches, just fixes bitrot.
Attachment #629114 - Flags: review?(nrthomas)
Attachment #629114 - Flags: review?(nrthomas) → review+
Attachment #629109 - Flags: review?(nrthomas) → review+
Comment on attachment 629114 [details] [diff] [review]
Branch patch

[Triage Comment]
We need this on esr10 and release to fix bustage, we'll also need it on aurora for the next cycle, beta isn't necessary as that's not needed now.
Attachment #629114 - Flags: approval-comm-release+
Attachment #629114 - Flags: approval-comm-esr10+
Attachment #629114 - Flags: approval-comm-aurora+
We should follow this up with a fix to the whitelist in release_sanity.py.
Target Milestone: Thunderbird 15.0 → ---
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.