760418 - Reorganize and fix broken Mutt JavaScript tests

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The current list of JS tests is a mess and need refactoring and clean-up. I will work on that to get a state where I can continue to implement new features without introducing new regressions. 

What I will do is:
* put tests under sub folders for modules
* fix broken tests (or file bugs for regressions)
* use local test pages instead of hitting the net

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Pointer to Github pull-request

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 630191 [details]
Patch v1

So this is tested and passes on OS X. Please test this patch on Linux (Jeff) and Windows (Clint). 

There were some tests in our suite which are obsolete, covered by other tests already, or access chrome parts which should not be in this suite but covered by our mozmill tests for Firefox.

Comment 3

[Jeff Hammel]

Comment on attachment 630191 [details]
Patch v1

Awesome work, Henrik!  If these pass now, it looks good to me.

FWIW, if you have 

"""
[DEFAULT]
type = javascript

[include:somefile.ini]
"""

somefile.ini should inherit 'type = javascript'. (If this doesn't work, it is a bug.) OTOH, there is no harm in specifying/overriding in the include-d file

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Jeff Hammel [:jhammel] from comment #3)

> [DEFAULT]
> type = javascript
> 
> [include:somefile.ini]
> 
> somefile.ini should inherit 'type = javascript'. (If this doesn't work, it
> is a bug.) OTOH, there is no harm in specifying/overriding in the include-d
> file

It works but I decided to leave this in so you can run a manifest of the sub folder directly. Otherwise you would have to comment out all included in the main tests.ini or add the default section to the appropriate tests.ini file.

I hope that's ok. I will now do a final test on Windows and Linux and check-in the changes if all pass.

Clint, I would still be happy to get an additional review. Just to be sure if you could spot any failure on my side.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

On Windows there seems to be a major issue with process handling on the Python side for the restart tests. I will file this as a separate bug. Otherwise it looks good.

Landed as:
https://github.com/mozautomation/mozmill/commit/931efcab0c4885f96a405b92825149390982bafa

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, had to push a follow-up for an accidental left-over from my screenshot patch on another bug.

https://github.com/mozautomation/mozmill/commit/1c8cd7a181ff5062f5767cfff783aecaee41cb70

Comment 7

[Jeff Hammel]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> (In reply to Jeff Hammel [:jhammel] from comment #3)
> 
> > [DEFAULT]
> > type = javascript
> > 
> > [include:somefile.ini]
> > 
> > somefile.ini should inherit 'type = javascript'. (If this doesn't work, it
> > is a bug.) OTOH, there is no harm in specifying/overriding in the include-d
> > file
> 
> It works but I decided to leave this in so you can run a manifest of the sub
> folder directly. Otherwise you would have to comment out all included in the
> main tests.ini or add the default section to the appropriate tests.ini file.
> 
> I hope that's ok. 

Yep, that's a completely valid point.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

One more accident. My bad. When I revert the feature in screenshot I also have to revert the test:

https://github.com/mozautomation/mozmill/commit/2d8896b06f4d321c61ef17df9b4fb4c9866ef753