de-ns-ify nsBaseWidgetAccessible

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I'd suggest to rename the file to general/BaseAccessibles in contrast to my suggestion in bug 759310 (ElementAccessibles). Sounds ok?
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 629525 [details] [diff] [review]
Patch (v1)

Renamed / moved files to generic/BaseAccessibles, renamed three classes, tweaked header guards, added to namespace, changed mozilla::a11y::role, tweaked include order, tweaked type*'s, blanks before ":" 's, removed couple whitespace nits ... blah blah blah :)
Attachment #629525 - Flags: review?(surkov.alexander)
(Assignee)

Updated

5 years ago
Blocks: 760755
(Reporter)

Comment 2

5 years ago
Comment on attachment 629525 [details] [diff] [review]
Patch (v1)

Review of attachment 629525 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/nsBaseWidgetAccessible.cpp
@@ +226,5 @@
>  ////////////////////////////////////////////////////////////////////////////////
>  
> +EnumRoleAccessible::
> +  EnumRoleAccessible(nsIContent* aNode, DocAccessible* aDoc,
> +                     roles::Role aRole) :

keep on the same line pls

::: accessible/src/base/nsBaseWidgetAccessible.h
@@ +95,4 @@
>  {
>  public:
> +  EnumRoleAccessible(nsIContent* aContent, DocAccessible* aDoc,
> +                     mozilla::a11y::role aRole);

a11y::role

::: accessible/src/xul/nsXULListboxAccessible.h
@@ +9,1 @@
>  #include "nsCOMPtr.h"

it doesn't seem you need nsCOMPtr.h include

::: accessible/src/xul/nsXULTabAccessible.h
@@ +6,5 @@
>  #ifndef _nsXULTabAccessible_H_
>  #define _nsXULTabAccessible_H_
>  
>  // NOTE: alphabetically ordered
> +#include "BaseAccessibles.h"

what's for?
Attachment #629525 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=11e7729cc708
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19b3c7d978a9
Target Milestone: --- → mozilla15
Target Milestone: mozilla15 → mozilla16
https://hg.mozilla.org/mozilla-central/rev/0dd9a6f719e8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.