Last Comment Bug 760463 - de-ns-ify nsBaseWidgetAccessible
: de-ns-ify nsBaseWidgetAccessible
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mark Capella [:capella]
:
Mentors:
Depends on:
Blocks: densifya11y 760755
  Show dependency treegraph
 
Reported: 2012-06-01 08:49 PDT by alexander :surkov
Modified: 2012-06-05 05:58 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (56.07 KB, patch)
2012-06-02 14:54 PDT, Mark Capella [:capella]
surkov.alexander: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-06-01 08:49:37 PDT
I'd suggest to rename the file to general/BaseAccessibles in contrast to my suggestion in bug 759310 (ElementAccessibles). Sounds ok?
Comment 1 Mark Capella [:capella] 2012-06-02 14:54:30 PDT
Created attachment 629525 [details] [diff] [review]
Patch (v1)

Renamed / moved files to generic/BaseAccessibles, renamed three classes, tweaked header guards, added to namespace, changed mozilla::a11y::role, tweaked include order, tweaked type*'s, blanks before ":" 's, removed couple whitespace nits ... blah blah blah :)
Comment 2 alexander :surkov 2012-06-03 19:55:04 PDT
Comment on attachment 629525 [details] [diff] [review]
Patch (v1)

Review of attachment 629525 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/base/nsBaseWidgetAccessible.cpp
@@ +226,5 @@
>  ////////////////////////////////////////////////////////////////////////////////
>  
> +EnumRoleAccessible::
> +  EnumRoleAccessible(nsIContent* aNode, DocAccessible* aDoc,
> +                     roles::Role aRole) :

keep on the same line pls

::: accessible/src/base/nsBaseWidgetAccessible.h
@@ +95,4 @@
>  {
>  public:
> +  EnumRoleAccessible(nsIContent* aContent, DocAccessible* aDoc,
> +                     mozilla::a11y::role aRole);

a11y::role

::: accessible/src/xul/nsXULListboxAccessible.h
@@ +9,1 @@
>  #include "nsCOMPtr.h"

it doesn't seem you need nsCOMPtr.h include

::: accessible/src/xul/nsXULTabAccessible.h
@@ +6,5 @@
>  #ifndef _nsXULTabAccessible_H_
>  #define _nsXULTabAccessible_H_
>  
>  // NOTE: alphabetically ordered
> +#include "BaseAccessibles.h"

what's for?
Comment 3 Mark Capella [:capella] 2012-06-04 03:31:43 PDT
https://tbpl.mozilla.org/?tree=Try&rev=11e7729cc708
Comment 4 Mark Capella [:capella] 2012-06-04 06:25:18 PDT
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19b3c7d978a9
Comment 5 Geoff Lankow (:darktrojan) 2012-06-05 05:58:28 PDT
https://hg.mozilla.org/mozilla-central/rev/0dd9a6f719e8

Note You need to log in before you can comment on or make changes to this bug.