Last Comment Bug 760755 - de-ns-ify nsHTMLImageMapAccessible
: de-ns-ify nsHTMLImageMapAccessible
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mark Capella [:capella]
:
Mentors:
Depends on: 760463
Blocks: densifya11y 760756
  Show dependency treegraph
 
Reported: 2012-06-01 19:33 PDT by alexander :surkov
Modified: 2012-06-05 05:59 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (18.15 KB, patch)
2012-06-03 01:53 PDT, Mark Capella [:capella]
surkov.alexander: review+
Details | Diff | Review

Description alexander :surkov 2012-06-01 19:33:30 PDT

    
Comment 1 Mark Capella [:capella] 2012-06-03 01:53:10 PDT
Created attachment 629572 [details] [diff] [review]
Patch (v1)

Renamed files to html/HTMLImageMapAccessible, renamed two classes, tweaked header guards, added to namespace, changed mozilla::a11y::role, tweaked include / makefile order, nits ...
Comment 2 alexander :surkov 2012-06-03 20:29:57 PDT
Comment on attachment 629572 [details] [diff] [review]
Patch (v1)

Review of attachment 629572 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLImageMapAccessible.h
@@ +15,5 @@
>  
>  /**
>   * Used for HTML image maps.
>   */
> +class HTMLImageMapAccessible : public mozilla::a11y::ImageAccessibleWrap

you don't need mozilla::a11y
Comment 3 Mark Capella [:capella] 2012-06-04 03:31:52 PDT
https://tbpl.mozilla.org/?tree=Try&rev=11e7729cc708
Comment 4 Mark Capella [:capella] 2012-06-04 06:25:02 PDT
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=19b3c7d978a9
Comment 5 Geoff Lankow (:darktrojan) 2012-06-05 05:59:39 PDT
https://hg.mozilla.org/mozilla-central/rev/d7b5ba5389bb

Note You need to log in before you can comment on or make changes to this bug.