760624 - Changed Hover.com password results in Thunderbird saying that there is a network problem.

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

When I change my Mailbox password (through Hover)
The next time I go into Thunderbird,  it gives that message "Server <[e-mail]>  has disconnected.  The server may have gone down or there may be a network problem."   instead of prompting for the password again (like it would do before, when no password was being set at all).

Comment 1

[Mike Conley (:mconley) (:⚙️)]

David says that this is happening because Hover.com is dropping the connection when the auth attempt fails, and that our IMAP code is kinda busted in that situation.

What do we want to do about this?

Comment 2

[David :Bienvenu]

Attachment: proposed fix

Mike, you want to try with this patch? It's fairly safe, as last minute changes go.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 629299 [details] [diff] [review]
proposed fix

Review of attachment 629299 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Now the question is, what do we do with this?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Mark:

Are we effectively past the point where something could get slipped into beta?

-Mike

Comment 5

[Mike Conley (:mconley) (:⚙️)]

landed on trunk - http://hg.mozilla.org/comm-central/rev/ebe999a8371e

Comment 6

[David :Bienvenu]

Comment on attachment 629299 [details] [diff] [review]
proposed fix

[Triage Comment]
I'll land this on aurora in a bit, maybe later today.

Comment 7

[David :Bienvenu]

pushed to aurora - http://hg.mozilla.org/releases/comm-aurora/rev/648090f7ec78

Comment 8

[David :Bienvenu]

Comment on attachment 629299 [details] [diff] [review]
proposed fix

[Approval Request Comment]
I'll let Standard8 make the call about beta/final.

I doubt that it's only hover affected by this issue, so there is a more general upside to taking this patch.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 629299 [details] [diff] [review]
proposed fix

This is now on the beta channel.

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 629299 [details] [diff] [review]
proposed fix

[Triage Comment]
We've not heard any issues with this, so we'll take it in 13.0.1.

Comment 11

[Mark Banner (:standard8)]

Fixed for 13.0.1:

https://hg.mozilla.org/releases/comm-release/rev/0c203b72f169