Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Update shell integration default browser check for Windows 8

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Shell Integration
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: bbondy)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 16
x86_64
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Our current methods do not detect this properly. The shell code will need to be updated.
(Assignee)

Updated

5 years ago
Assignee: nobody → netzen
(Assignee)

Comment 1

5 years ago
I think the way to fix this is to check the ProgId for the default protocol in nsWindowsShellService::IsDefaultBrowserVista via IApplicationAssociationRegistration::QueryCurrentDefault
(Assignee)

Comment 2

5 years ago
Created attachment 630310 [details] [diff] [review]
Patch v1.

This review request is to land directly on m-c.
Registering http implies https by the way. 

It pops up the same select browser window as when you install.  The pref UI doesn't change at all. If you don't select Firefox in the popup it will not update the pref UI saying you set the default (I.e. it works correctly).
Attachment #630310 - Flags: review?(jmathies)
(Reporter)

Comment 3

5 years ago
Comment on attachment 630310 [details] [diff] [review]
Patch v1.

Review of attachment 630310 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/shell/src/nsWindowsShellService.cpp
@@ +582,5 @@
> +    info.pcszClass = NULL;
> +    info.oaifInFlags = OAIF_FORCE_REGISTRATION | 
> +                       OAIF_URL_PROTOCOL |
> +                       OAIF_REGISTER_EXT;
> +    if FAILED(SHOpenWithDialog(NULL, &info)) {

This api is Vista and up, we'll need to use GetProcAddress to avoid xp problems. :/

http://msdn.microsoft.com/en-us/library/windows/desktop/bb762234(v=vs.85).aspx

With a NULL parent window handle, are there any focus issues with the main fx desktop window?
Attachment #630310 - Flags: review?(jmathies) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 630601 [details] [diff] [review]
Patch v2

Fixed the dynamic load.

We don't need to specify an HWND because the defaults dialog is dismissed automatically when focus is lost anyway.  The call is blocking though in that the next line of code will not execute until the window loses focus or a selection is made.

I haven't pushed to try yet by the way but will before landing.
Attachment #630310 - Attachment is obsolete: true
Attachment #630601 - Flags: review?(jmathies)
(Reporter)

Comment 5

5 years ago
Comment on attachment 630601 [details] [diff] [review]
Patch v2

Hrm, modal dialog calls are best avoided, but if the call throws up the right looking win8 interface I suppose it's worth it the risk.
Attachment #630601 - Flags: review?(jmathies) → review+
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/9399394d8f32
Target Milestone: --- → Firefox 16

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9399394d8f32
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Duplicate of this bug: 760679
(Assignee)

Updated

5 years ago
Depends on: 764515
(Assignee)

Updated

5 years ago
Duplicate of this bug: 740424
(Assignee)

Updated

5 years ago
Blocks: 831612
You need to log in before you can comment on or make changes to this bug.