760680 - Update shell integration default browser check for Windows 8

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Jim Mathies [:jimm]]

Our current methods do not detect this properly. The shell code will need to be updated.

Comment 1

[Brian R. Bondy [:bbondy]]

I think the way to fix this is to check the ProgId for the default protocol in nsWindowsShellService::IsDefaultBrowserVista via IApplicationAssociationRegistration::QueryCurrentDefault

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

This review request is to land directly on m-c.
Registering http implies https by the way. 

It pops up the same select browser window as when you install.  The pref UI doesn't change at all. If you don't select Firefox in the popup it will not update the pref UI saying you set the default (I.e. it works correctly).

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 630310 [details] [diff] [review]
Patch v1.

Review of attachment 630310 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/shell/src/nsWindowsShellService.cpp
@@ +582,5 @@
> +    info.pcszClass = NULL;
> +    info.oaifInFlags = OAIF_FORCE_REGISTRATION | 
> +                       OAIF_URL_PROTOCOL |
> +                       OAIF_REGISTER_EXT;
> +    if FAILED(SHOpenWithDialog(NULL, &info)) {

This api is Vista and up, we'll need to use GetProcAddress to avoid xp problems. :/

http://msdn.microsoft.com/en-us/library/windows/desktop/bb762234(v=vs.85).aspx

With a NULL parent window handle, are there any focus issues with the main fx desktop window?

Comment 4

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2

Fixed the dynamic load.

We don't need to specify an HWND because the defaults dialog is dismissed automatically when focus is lost anyway.  The call is blocking though in that the next line of code will not execute until the window loses focus or a selection is made.

I haven't pushed to try yet by the way but will before landing.

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 630601 [details] [diff] [review]
Patch v2

Hrm, modal dialog calls are best avoided, but if the call throws up the right looking win8 interface I suppose it's worth it the risk.

Comment 6

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/9399394d8f32

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9399394d8f32