If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Port |Bug 756325 - channel-prefs.js appears in new 'preferences' location on fresh installation but remains in 'pref' for updated existing installation| to SeaMonkey

VERIFIED FIXED in seamonkey2.13

Status

SeaMonkey
Build Config
P3
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.13
Dependency tree / graph
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.11 verified, seamonkey2.12 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 629465 [details] [diff] [review]
(Av1) Move 'channel-prefs.js' back to NON_OMNIJAR_FILES

*Ftr, bug 756325 says 'removed-files.in' needs no update :-|
*Fwiw, FF and TB has (all) this in their /app/ dir,
 yet I left it as is, in /suite/browser/.
*(Untested).
Attachment #629465 - Flags: review?(bugspam.Callek)
Attachment #629465 - Flags: approval-comm-aurora?
(Assignee)

Updated

5 years ago
status-seamonkey2.12: --- → affected
Target Milestone: seamonkey2.12 → seamonkey2.13
(Assignee)

Updated

5 years ago
Attachment #629465 - Flags: approval-comm-beta?

Updated

5 years ago
Attachment #629465 - Flags: review?(bugspam.Callek)
Attachment #629465 - Flags: review+
Attachment #629465 - Flags: approval-comm-beta?
Attachment #629465 - Flags: approval-comm-beta+
Attachment #629465 - Flags: approval-comm-aurora?
Attachment #629465 - Flags: approval-comm-aurora+
(Assignee)

Updated

5 years ago
Depends on: 762588
(Assignee)

Comment 2

5 years ago
Created attachment 637064 [details] [diff] [review]
(Av2) Port bug 756325 and bug 762588
[Checked in: Comment 7 & 9 & 6]

Av1, plus bug 762588 port.
(I'll assume c-* approvals are still valid.)

NB:
I preferred to separate rather than use 'else', especially in 'Makefile.in' (wrt 'rules.mk').
Attachment #629465 - Attachment is obsolete: true
Attachment #637064 - Flags: review?(bugspam.Callek)
(Assignee)

Comment 3

5 years ago
Ftr, patch Av1 succeeded as
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=b820a0a17dab

Iiuc the logs (and .zip), channel-prefs.js is packaged at the correct place whether patch Av1 is applied or not.
Then, I wonder whether this file would be "already" (as in double) packaged by some other (shared?) code.

Anyway, let's just sync' (Av2) code ftb :-|
Comment on attachment 637064 [details] [diff] [review]
(Av2) Port bug 756325 and bug 762588
[Checked in: Comment 7 & 9 & 6]

Review of attachment 637064 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: I do prefer the way Firefox did it http://mxr.mozilla.org/comm-central/source/mozilla/browser/app/Makefile.in#140 (with the else) but I won't block on it
Attachment #637064 - Flags: review?(bugspam.Callek)
Attachment #637064 - Flags: review+
Attachment #637064 - Flags: approval-comm-beta+
Attachment #637064 - Flags: approval-comm-aurora+
(Assignee)

Updated

5 years ago
Depends on: 769130
(Assignee)

Comment 5

5 years ago
Comment on attachment 637064 [details] [diff] [review]
(Av2) Port bug 756325 and bug 762588
[Checked in: Comment 7 & 9 & 6]

https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=37e2a400b4d9
[Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/16.0 Firefox/16.0 SeaMonkey/2.13a1 // Build identifier: 20120627041654] (MsVc8, sgautherie.bz@free.fr-67dbc42bd72d/try-comm-central-win32)

channel-prefs.js is still(!) packaged outside omni.ja only :-)
http://hg.mozilla.org/releases/comm-beta/rev/c35a94785f1e
status-seamonkey2.11: affected → fixed
tracking-seamonkey2.11: ? → ---
(Assignee)

Comment 7

5 years ago
Comment on attachment 637064 [details] [diff] [review]
(Av2) Port bug 756325 and bug 762588
[Checked in: Comment 7 & 9 & 6]

http://hg.mozilla.org/comm-central/rev/6d4fa81cc115
Attachment #637064 - Attachment description: (Av2) Port bug 756325 and bug 762588 → (Av2) Port bug 756325 and bug 762588 [Checked in: Comment 7 & 6]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: 6d4fa81cc115 to c-a]
(Assignee)

Comment 8

5 years ago
/pub/seamonkey/candidates/2.11b5-candidates/build1/win32/en-US
seamonkey-2.11b5.zip

seamonkey2.11: verified.
status-seamonkey2.11: fixed → verified
https://hg.mozilla.org/releases/comm-aurora/rev/9331aaae3574
status-seamonkey2.12: affected → fixed
Keywords: checkin-needed
Whiteboard: [c-n: 6d4fa81cc115 to c-a]
(Assignee)

Updated

5 years ago
Attachment #637064 - Attachment description: (Av2) Port bug 756325 and bug 762588 [Checked in: Comment 7 & 6] → (Av2) Port bug 756325 and bug 762588 [Checked in: Comment 7 & 9 & 6]
(Assignee)

Comment 10

5 years ago
http://tbpl.drapostles.org/?rev=6d4fa81cc115
sgautherie.bz@free.fr – Sat Jul 7 13:52:03 2012
/pub/seamonkey/tinderbox-builds/comm-central-trunk-win32/1341661942
seamonkey-2.13a1.en-US.win32.zip

V.Fixed


http://tbpl.drapostles.org/?tree=SeaMonkey-Aurora&rev=9331aaae3574
ryanvm@gmail.com – Sat Jul 7 15:16:12 2012
/pub/seamonkey/tinderbox-builds/comm-aurora-win32/1341666982
seamonkey-2.12a2.en-US.win32.zip

seamonkey2.12: verified.
Status: RESOLVED → VERIFIED
status-seamonkey2.12: fixed → verified
You need to log in before you can comment on or make changes to this bug.