761574 - Debugger Closing after Opening it immediately on Mac (a11y)

Status: RESOLVED DUPLICATE of bug 668469

(DevTools :: Debugger, defect, P1)

Description

[Rob Campbell [:rc] (:robcee)]

In current nightly, FF16.0a, opening the debugger causes an assertion in mozAccessible.mm which causes the debugger to close immediately.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Rob was this some kind of assertion related to a11y being instantiated?

Comment 2

[Rob Campbell [:rc] (:robcee)]

it's easy to test! With the Big Global Accessibility option enabled, try opening the Debugger in Firefox and check the Error Console.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to David Bolter [:davidb] from comment #1)

Assertion failure in -[mozRootAccessible didReceiveFocus], /fx-team/accessible/src/mac/mozAccessible.mm:587

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

OK thanks. Hub, can you take this one?

Comment 5

[Hubert Figuiere [:hub]]

I get that assert often (it is non fatal). I have no idea why it is in there. DOM Inspector and mochitest triggers it too.

Comment 6

[alexander :surkov (:asurkov)]

The assertion is:
NSAssert1(![self accessibilityIsIgnored], @"trying to set focus to ignored element! (%@)", self);

accessibilityIsIgnored method returns true for any accessible object having a role that isn't mapped to mac a11y.

The fix is to make accessibilityIsIgnored method to check the presence of focusable state.

Hub, wanna take the bug?

Comment 7

[Hubert Figuiere [:hub]]

mozRootAccessible is the accessible created for the CHROME_WINDOW role, that is ignored.

I believe this is wrong as it should be the NSWindow (ie the window in MacOS).

Comment 8

[Hubert Figuiere [:hub]]

I can reproduce after fixing the error leading to the assert. I don't know what is happening, nor have any idea if the debug messages are relevant or not.

I use mozilla-inbound.

Comment 9

[Hubert Figuiere [:hub]]

(I also have a patch to disable the VO whitelisting that have been introduced between the moment the bug was reported and now... as well as have a11y enabled explicitely as it no longer is)

Comment 10

[Hubert Figuiere [:hub]]

actually I realize, I didn't have the patch fixing the assert unlike I said in comment 8. With or without I don't get the assert but I do get the bug.

Comment 11

[Hubert Figuiere [:hub]]

The assert mentionned in comment 6 is bug 668469

Comment 12

[Rob Campbell [:rc] (:robcee)]

Hub, is this still a problem for us? If mac a11y has been disabled, the assertion should go away and things should behave as they should, right?

Comment 13

[Rob Campbell [:rc] (:robcee)]

followup question: Should this be an a11y bug and not specifically the Debugger?

Comment 14

[alexander :surkov (:asurkov)]

(In reply to Rob Campbell [:rc] (:robcee) from comment #13)
> followup question: Should this be an a11y bug and not specifically the
> Debugger?

yes, I think focusable stuffs should be never ignored.

Hub, are you ok with approach from comment #6?

Comment 15

[Hubert Figuiere [:hub]]

Alex, seems to be reasonable.

Comment 16

[Hubert Figuiere [:hub]]

I believe this is an actual dupe of bug 668469 that has just been fixed in central.

Let me know if you still encounter problems. If not, I'll mark this one as dupe.

Thanks.

Comment 17

[alexander :surkov (:asurkov)]

dupe per comment #16