Last Comment Bug 761975 - extra ")" makes Firefox RPM Nightly build failed
: extra ")" makes Firefox RPM Nightly build failed
Product: Firefox Graveyard
Classification: Graveyard
Component: Webapp Runtime (show other bugs)
: Trunk
: All All
-- normal
: Firefox 16
Assigned To: Takanori MATSUURA
: Jason Smith [:jsmith]
: 762214 (view as bug list)
Depends on:
Blocks: 746156
  Show dependency treegraph
Reported: 2012-06-06 03:56 PDT by Takanori MATSUURA
Modified: 2016-03-21 12:39 PDT (History)
6 users (show)
jsmith: in‑moztrap-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Fix (1.23 KB, patch)
2012-06-06 03:56 PDT, Takanori MATSUURA
benjamin: review+
akeybl: approval‑mozilla‑aurora+
myk: checkin+
Details | Diff | Splinter Review

Description User image Takanori MATSUURA 2012-06-06 03:56:34 PDT
Created attachment 630497 [details] [diff] [review]

See bug 746156 comment #11 and bug 746156 comment #13.

By removing extra ")" from toolkit/mozapps/installer/, Firefox RPM Nightly build is successful.
Comment 2 User image Ed Morley [:emorley] 2012-06-07 05:52:03 PDT
Comment 3 User image Benjamin Smedberg [:bsmedberg] 2012-06-07 06:51:56 PDT
*** Bug 762214 has been marked as a duplicate of this bug. ***
Comment 4 User image Myk Melez [:myk] [@mykmelez] 2012-07-13 10:33:43 PDT
Comment on attachment 630497 [details] [diff] [review]

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 746156
User impact if declined: There is no user impact, but various build steps will fail when Firefox is built in certain configurations, including the one described in this bug and the one described in bug 773706.
Testing completed (on m-c, etc.): This landed on mozilla-central a while ago and has not caused any problems there.
Risk to taking this patch (and alternatives if risky): It's a simple, obvious fix and thus seems very low-risk.
String or UUID changes made by this patch: None.
Comment 5 User image Alex Keybl [:akeybl] 2012-07-13 13:54:49 PDT
Comment on attachment 630497 [details] [diff] [review]

[Triage Comment]
If this somehow manages to regress us, my faith will be shaken. Approved for Aurora 15.
Comment 6 User image Alex Keybl [:akeybl] 2012-07-13 13:55:11 PDT
(please land ASAP to make it in before Monday's merge)
Comment 7 User image Myk Melez [:myk] [@mykmelez] 2012-07-13 14:19:37 PDT

Note You need to log in before you can comment on or make changes to this bug.