Closed Bug 761975 Opened 12 years ago Closed 12 years ago

extra ")" makes Firefox RPM Nightly build failed

Categories

(Firefox Graveyard :: Webapp Runtime, defect)

Product:
Firefox Graveyard
Component:
Webapp Runtime
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- fixed

People

(Reporter: t.matsuu, Assigned: t.matsuu)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Fix
1.23 KB, patch
benjamin
: review+
akeybl
: approval-mozilla-aurora+
myk
: checkin+
Details | Diff | Splinter Review
Attached patch Fix — — Splinter Review 
See bug 746156 comment #11 and bug 746156 comment #13.

By removing extra ")" from toolkit/mozapps/installer/packager.mk, Firefox RPM Nightly build is successful.
Attachment #630497 - Flags: review?(benjamin)
Attachment #630497 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
Assignee: nobody → t.matsuu
Status: NEW → ASSIGNED
Whiteboard: [qa-]
https://hg.mozilla.org/mozilla-central/rev/2b0ec0df160c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Flags: in-moztrap-
QA Contact: jsmith
Comment on attachment 630497 [details] [diff] [review]
Fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 746156
User impact if declined: There is no user impact, but various build steps will fail when Firefox is built in certain configurations, including the one described in this bug and the one described in bug 773706.
Testing completed (on m-c, etc.): This landed on mozilla-central a while ago and has not caused any problems there.
Risk to taking this patch (and alternatives if risky): It's a simple, obvious fix and thus seems very low-risk.
String or UUID changes made by this patch: None.
Attachment #630497 - Flags: approval-mozilla-aurora?
Comment on attachment 630497 [details] [diff] [review]
Fix

[Triage Comment]
If this somehow manages to regress us, my faith will be shaken. Approved for Aurora 15.
Attachment #630497 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(please land ASAP to make it in before Monday's merge)
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.