[css3-transitions] unprefix CSS Transition properties

RESOLVED FIXED in mozilla16



7 years ago
6 years ago


(Reporter: tantek, Assigned: ebassi)


(Blocks 1 bug, {dev-doc-complete})

Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags



(Whiteboard: [qa+])


(1 attachment, 2 obsolete attachments)

The CSS Working Group has agreed to give the go-ahead to browser implementers to unprefix CSS3 Transitions, Transforms, and Animations:

Nominating for k9o - this identified as a top pain point from John Jensen's report for web compatibility.
blocking-kilimanjaro: --- → ?
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Jet - What are your thoughts on blocking k9o on the unprefixing these properties?
(In reply to Lawrence Mandel [:lmandel] from comment #2)
> Jet - What are your thoughts on blocking k9o on the unprefixing these
> properties?

As a point of comparison, we are currently blocking on bug 745523 (the transforms unprefixing) based on the same rationale in comment 1. Should this be a blocker for the same reason?
Yes, these should be k9o blockers.
blocking-kilimanjaro: ? → +
Assigning to Emmanuele as his first official bug.
Assignee: nobody → ebassi
Posted patch preliminary patch (obsolete) — Splinter Review
I have a preliminary patch ready; needs testing on the try server, for which I requested a level 1 commit access in bug 770124.

I mostly followed the pattern of the unprefixing of -moz-border-image (cfr commit https://hg.mozilla.org/mozilla-central/rev/8ff7563000f5).
Summary: [css3-transitions] unprefix CSS Transition properties and values → [css3-transitions] unprefix CSS Transition properties
new version of the patch in attachment 638436 [details] [diff] [review]; this one actually provides -moz aliases for transition and its sub-properties, as they have been exposed already.

a simple grep on mozilla-central shows a lot of hits in browser/themes and toolkit/themes for -moz-transition; I wonder if a supplemental patch should be provided now, before we remove the aliases, to avoid doing it later.
Attachment #638436 - Attachment is obsolete: true
Attachment #638769 - Flags: feedback?(dbaron)
Comment on attachment 638769 [details] [diff] [review]
unprefix CSS Transition properties and provide temporary aliases for -moz-transition and exposed subproperties

You should actually run unit tests to make sure this doesn't make anything fail.  I think you're missing reordering of the table near the end of layout/style/nsComputedDOMStyle.cpp (which will cause a test to fail, since the order of that list is exposed to JS), but otherwise this looks fine.

In the future it may make sense to separate the renaming patch from the go-through-the-tree patch, though there's no need to do that after-the-fact here.  (The first patch needs to have the layout/style/test/ changes to avoid failing tests.)
Attachment #638769 - Flags: feedback?(dbaron) → feedback+
Attachment #639077 - Flags: review?(dbaron)
Comment on attachment 639077 [details] [diff] [review]
Bug 762303 - [css3-transitions] unprefix CSS Transition properties and provide temporary aliases for -moz-transition and exposed subproperties

Attachment #639077 - Flags: review?(dbaron) → review+
Guessing checkin-needed since EB is new :-)
Keywords: checkin-needed

I had to un-bitrot this a bit. Please look it over to make sure I didn't mess anything up. Also, please make sure that future patches have all the needed checkin info. It makes life easier for those checking in on your behalf. Thanks!
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla16
Whiteboard: [qa+]
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 772342
Blocks: 772456
Blocks: 772460
Blocks: unprefix
Depends on: 789747
Blocks: 832139
You need to log in before you can comment on or make changes to this bug.