[css3-transitions] unprefix CSS Transition properties

RESOLVED FIXED in mozilla16

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Tantek Çelik, Assigned: ebassi)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

Trunk
mozilla16
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(blocking-kilimanjaro:+)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

5 years ago
The CSS Working Group has agreed to give the go-ahead to browser implementers to unprefix CSS3 Transitions, Transforms, and Animations:

http://lists.w3.org/Archives/Public/www-style/2012Jun/0105.html
Nominating for k9o - this identified as a top pain point from John Jensen's report for web compatibility.
blocking-kilimanjaro: --- → ?

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Jet - What are your thoughts on blocking k9o on the unprefixing these properties?
(In reply to Lawrence Mandel [:lmandel] from comment #2)
> Jet - What are your thoughts on blocking k9o on the unprefixing these
> properties?

As a point of comparison, we are currently blocking on bug 745523 (the transforms unprefixing) based on the same rationale in comment 1. Should this be a blocker for the same reason?

Comment 4

5 years ago
Yes, these should be k9o blockers.

Updated

5 years ago
blocking-kilimanjaro: ? → +

Comment 5

5 years ago
Assigning to Emmanuele as his first official bug.
Assignee: nobody → ebassi
(Assignee)

Comment 6

5 years ago
Created attachment 638436 [details] [diff] [review]
preliminary patch

I have a preliminary patch ready; needs testing on the try server, for which I requested a level 1 commit access in bug 770124.

I mostly followed the pattern of the unprefixing of -moz-border-image (cfr commit https://hg.mozilla.org/mozilla-central/rev/8ff7563000f5).
Summary: [css3-transitions] unprefix CSS Transition properties and values → [css3-transitions] unprefix CSS Transition properties
(Assignee)

Comment 7

5 years ago
Created attachment 638769 [details] [diff] [review]
unprefix CSS Transition properties and provide temporary aliases for -moz-transition and exposed subproperties

new version of the patch in attachment 638436 [details] [diff] [review]; this one actually provides -moz aliases for transition and its sub-properties, as they have been exposed already.

a simple grep on mozilla-central shows a lot of hits in browser/themes and toolkit/themes for -moz-transition; I wonder if a supplemental patch should be provided now, before we remove the aliases, to avoid doing it later.
Attachment #638436 - Attachment is obsolete: true
Attachment #638769 - Flags: feedback?(dbaron)
Comment on attachment 638769 [details] [diff] [review]
unprefix CSS Transition properties and provide temporary aliases for -moz-transition and exposed subproperties

You should actually run unit tests to make sure this doesn't make anything fail.  I think you're missing reordering of the table near the end of layout/style/nsComputedDOMStyle.cpp (which will cause a test to fail, since the order of that list is exposed to JS), but otherwise this looks fine.

In the future it may make sense to separate the renaming patch from the go-through-the-tree patch, though there's no need to do that after-the-fact here.  (The first patch needs to have the layout/style/test/ changes to avoid failing tests.)
Attachment #638769 - Flags: feedback?(dbaron) → feedback+
(Assignee)

Comment 9

5 years ago
Created attachment 639077 [details] [diff] [review]
Bug 762303 - [css3-transitions] unprefix CSS Transition properties and provide temporary aliases for -moz-transition and exposed subproperties

updated patch after feedback.

try output: https://tbpl.mozilla.org/?tree=Try&rev=bc9718b535f8
try log: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ebassi@mozilla.com-bc9718b535f8/
Attachment #638769 - Attachment is obsolete: true
(Assignee)

Comment 10

5 years ago
ugh, copy and paste failure.

try output: https://tbpl.mozilla.org/?tree=Try&rev=00cf7dc7ee59
try log: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ebassi@mozilla.com-00cf7dc7ee59/
(Assignee)

Updated

5 years ago
Attachment #639077 - Flags: review?(dbaron)
Comment on attachment 639077 [details] [diff] [review]
Bug 762303 - [css3-transitions] unprefix CSS Transition properties and provide temporary aliases for -moz-transition and exposed subproperties

r=dbaron
Attachment #639077 - Flags: review?(dbaron) → review+
Keywords: dev-doc-needed

Comment 12

5 years ago
Guessing checkin-needed since EB is new :-)
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/137f4655cf25

I had to un-bitrot this a bit. Please look it over to make sure I didn't mess anything up. Also, please make sure that future patches have all the needed checkin info. It makes life easier for those checking in on your behalf. Thanks!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla16

Updated

5 years ago
Whiteboard: [qa+]
looks fine to me
https://hg.mozilla.org/mozilla-central/rev/137f4655cf25
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Blocks: 772342

Updated

5 years ago
Blocks: 772456

Updated

5 years ago
Blocks: 772460

Updated

5 years ago
Blocks: 775235
Doc updated:
https://developer-new.mozilla.org/en-US/docs/Firefox_16_for_developers
https://developer-new.mozilla.org/en-US/docs/CSS/transition
https://developer-new.mozilla.org/en-US/docs/CSS/transition-delay
https://developer-new.mozilla.org/en-US/docs/CSS/transition-duration
https://developer-new.mozilla.org/en-US/docs/CSS/transition-property
https://developer-new.mozilla.org/en-US/docs/CSS/transition-timing-function

(I kept the experimental banner — until the spec reach CR — and all this is visible only on the new wiki for a few days until Kuma goes live)
Keywords: dev-doc-needed → dev-doc-complete

Updated

5 years ago
Depends on: 789747
Depends on: 790761

Updated

5 years ago
Blocks: 832139
You need to log in before you can comment on or make changes to this bug.