Closed Bug 762754 Opened 7 years ago Closed 7 years ago

rename nsXULTextAccessible files to XULEelementAccessibles

Categories

(Core :: Disability Access APIs, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: surkov, Assigned: capella)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

densify containing classes as you go
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
namespacing also?
of course
Attached patch Patch (v1) (obsolete) — Splinter Review
A little quickie ...
Attachment #631436 - Flags: review?(surkov.alexander)
Blocks: 762755
Comment on attachment 631436 [details] [diff] [review]
Patch (v1)

Review of attachment 631436 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with class renaming

::: accessible/src/xul/nsXULTextAccessible.cpp
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  // NOTE: groups are alphabetically ordered
> +#include "XULElementAccessibles.h"

the comment should be after this include (or get rid it at all)

::: accessible/src/xul/nsXULTextAccessible.h
@@ +15,4 @@
>  /**
>   * Used for XUL description and label elements.
>   */
> +class XULElementAccessibles : public HyperTextAccessibleWrap

name it to XULLabelAccessible
Attachment #631436 - Flags: review?(surkov.alexander) → review+
Attached patch Patch (v2)Splinter Review
Revised for push.
Attachment #631436 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/e6dedc30b9c3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.