rename nsXULTextAccessible files to XULEelementAccessibles

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
densify containing classes as you go
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
namespacing also?
(Reporter)

Comment 2

5 years ago
of course
(Assignee)

Comment 3

5 years ago
Created attachment 631436 [details] [diff] [review]
Patch (v1)

A little quickie ...
Attachment #631436 - Flags: review?(surkov.alexander)
(Assignee)

Updated

5 years ago
Blocks: 762755
(Reporter)

Comment 4

5 years ago
Comment on attachment 631436 [details] [diff] [review]
Patch (v1)

Review of attachment 631436 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with class renaming

::: accessible/src/xul/nsXULTextAccessible.cpp
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  // NOTE: groups are alphabetically ordered
> +#include "XULElementAccessibles.h"

the comment should be after this include (or get rid it at all)

::: accessible/src/xul/nsXULTextAccessible.h
@@ +15,4 @@
>  /**
>   * Used for XUL description and label elements.
>   */
> +class XULElementAccessibles : public HyperTextAccessibleWrap

name it to XULLabelAccessible
Attachment #631436 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 631611 [details] [diff] [review]
Patch (v2)

Revised for push.
Attachment #631436 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
push to try:
https://tbpl.mozilla.org/?tree=Try&rev=6b0a0f95c64d
(Assignee)

Comment 7

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8ca3fe220709
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/e6dedc30b9c3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.