Comment 1 Mark Capella [:capella] 2012-06-08 08:42:03 PDT

namespacing also?

Comment 2 alexander :surkov 2012-06-08 08:48:33 PDT

of course

Comment 3 Mark Capella [:capella] 2012-06-08 09:44:30 PDT

Created attachment 631436 [details] [diff] [review]
Patch (v1)

A little quickie ...

Comment 4 alexander :surkov 2012-06-08 20:21:48 PDT

Comment on attachment 631436 [details] [diff] [review]
Patch (v1)

Review of attachment 631436 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with class renaming

::: accessible/src/xul/nsXULTextAccessible.cpp
@@ +3,5 @@
>   * License, v. 2.0. If a copy of the MPL was not distributed with this
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  // NOTE: groups are alphabetically ordered
> +#include "XULElementAccessibles.h"

the comment should be after this include (or get rid it at all)

::: accessible/src/xul/nsXULTextAccessible.h
@@ +15,4 @@
>  /**
>   * Used for XUL description and label elements.
>   */
> +class XULElementAccessibles : public HyperTextAccessibleWrap

name it to XULLabelAccessible

Comment 5 Mark Capella [:capella] 2012-06-08 21:35:01 PDT

Created attachment 631611 [details] [diff] [review]
Patch (v2)

Revised for push.

Comment 6 Mark Capella [:capella] 2012-06-08 22:51:48 PDT

push to try:
https://tbpl.mozilla.org/?tree=Try&rev=6b0a0f95c64d

Comment 7 Mark Capella [:capella] 2012-06-09 01:23:15 PDT

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8ca3fe220709

Comment 8 Ryan VanderMeulen [:RyanVM] 2012-06-09 19:30:18 PDT

https://hg.mozilla.org/mozilla-central/rev/e6dedc30b9c3