Last Comment Bug 762755 - de-ns-ify nsXULMenuAccessible and nsXULListboxAccessible classes
: de-ns-ify nsXULMenuAccessible and nsXULListboxAccessible classes
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Mark Capella [:capella]
:
: alexander :surkov
Mentors:
Depends on: 762754
Blocks: densifya11y
  Show dependency treegraph
 
Reported: 2012-06-07 18:54 PDT by alexander :surkov
Modified: 2012-06-09 19:30 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (80.17 KB, patch)
2012-06-08 15:12 PDT, Mark Capella [:capella]
surkov.alexander: review+
Details | Diff | Splinter Review
Patch (v2) (116.70 KB, patch)
2012-06-08 22:01 PDT, Mark Capella [:capella]
no flags Details | Diff | Splinter Review

Description alexander :surkov 2012-06-07 18:54:58 PDT

    
Comment 1 Mark Capella [:capella] 2012-06-08 15:12:28 PDT
Created attachment 631546 [details] [diff] [review]
Patch (v1)

Woo hoo! A two-fer-one !
Comment 2 alexander :surkov 2012-06-08 21:05:57 PDT
Comment on attachment 631546 [details] [diff] [review]
Patch (v1)

Review of attachment 631546 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsXULListboxAccessibleWrap.h
@@ +11,5 @@
>  
> +namespace mozilla {
> +namespace a11y {
> +
> +typedef class XULListBoxAccessible XULListBoxAccessibleWrap;

ok, if you like though I didn't think to uppercase b in box (however you keep other classes untouched like XULListitemAccessible

::: accessible/src/xul/nsXULListboxAccessible.cpp
@@ +893,5 @@
>    return NativelyUnavailable() || (mParent && mParent->NativelyUnavailable()) ?
>      states::UNAVAILABLE : states::FOCUSABLE | states::SELECTABLE;
>  }
>  
> +NS_IMETHODIMP XULListitemAccessible::GetActionName(PRUint8 aIndex, nsAString& aName)

keep NS_IMETHODIMP on separate line

::: accessible/src/xul/nsXULListboxAccessible.h
@@ +143,1 @@
>                                  public nsIAccessibleTableCell

wrong indent

::: accessible/src/xul/nsXULMenuAccessible.cpp
@@ +289,5 @@
>    // That indicates we don't walk anonymous children for menuitems
>    return false;
>  }
>  
> +NS_IMETHODIMP XULMenuitemAccessible::DoAction(PRUint8 index)

return type on own line

@@ +300,5 @@
>    return NS_ERROR_INVALID_ARG;
>  }
>  
>  /** select us! close combo box if necessary*/
> +NS_IMETHODIMP XULMenuitemAccessible::GetActionName(PRUint8 aIndex, nsAString& aName)

same

@@ +396,5 @@
>  {
>    return roles::SEPARATOR;
>  }
>  
> +NS_IMETHODIMP XULMenuSeparatorAccessible::DoAction(PRUint8 index)

same and below
Comment 3 Mark Capella [:capella] 2012-06-08 22:01:52 PDT
Created attachment 631612 [details] [diff] [review]
Patch (v2)

fyi, final for push.
Comment 4 Mark Capella [:capella] 2012-06-08 22:31:31 PDT
fyi on WIN, hg rename FOO foo generates a renaming thing to itself kind of error...

hg rename FOO xxx, followed by
hg rename xxx foo achieves the goal
Comment 5 Mark Capella [:capella] 2012-06-08 22:51:52 PDT
push to try:
https://tbpl.mozilla.org/?tree=Try&rev=6b0a0f95c64d
Comment 6 Mark Capella [:capella] 2012-06-09 01:23:31 PDT
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8ca3fe220709
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-06-09 19:30:37 PDT
https://hg.mozilla.org/mozilla-central/rev/8ca3fe220709

Note You need to log in before you can comment on or make changes to this bug.