de-ns-ify nsXULMenuAccessible and nsXULListboxAccessible classes

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Depends on: 762754
(Assignee)

Comment 1

5 years ago
Created attachment 631546 [details] [diff] [review]
Patch (v1)

Woo hoo! A two-fer-one !
Attachment #631546 - Flags: review?(surkov.alexander)
(Reporter)

Comment 2

5 years ago
Comment on attachment 631546 [details] [diff] [review]
Patch (v1)

Review of attachment 631546 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsXULListboxAccessibleWrap.h
@@ +11,5 @@
>  
> +namespace mozilla {
> +namespace a11y {
> +
> +typedef class XULListBoxAccessible XULListBoxAccessibleWrap;

ok, if you like though I didn't think to uppercase b in box (however you keep other classes untouched like XULListitemAccessible

::: accessible/src/xul/nsXULListboxAccessible.cpp
@@ +893,5 @@
>    return NativelyUnavailable() || (mParent && mParent->NativelyUnavailable()) ?
>      states::UNAVAILABLE : states::FOCUSABLE | states::SELECTABLE;
>  }
>  
> +NS_IMETHODIMP XULListitemAccessible::GetActionName(PRUint8 aIndex, nsAString& aName)

keep NS_IMETHODIMP on separate line

::: accessible/src/xul/nsXULListboxAccessible.h
@@ +143,1 @@
>                                  public nsIAccessibleTableCell

wrong indent

::: accessible/src/xul/nsXULMenuAccessible.cpp
@@ +289,5 @@
>    // That indicates we don't walk anonymous children for menuitems
>    return false;
>  }
>  
> +NS_IMETHODIMP XULMenuitemAccessible::DoAction(PRUint8 index)

return type on own line

@@ +300,5 @@
>    return NS_ERROR_INVALID_ARG;
>  }
>  
>  /** select us! close combo box if necessary*/
> +NS_IMETHODIMP XULMenuitemAccessible::GetActionName(PRUint8 aIndex, nsAString& aName)

same

@@ +396,5 @@
>  {
>    return roles::SEPARATOR;
>  }
>  
> +NS_IMETHODIMP XULMenuSeparatorAccessible::DoAction(PRUint8 index)

same and below
Attachment #631546 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 631612 [details] [diff] [review]
Patch (v2)

fyi, final for push.
Attachment #631546 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
fyi on WIN, hg rename FOO foo generates a renaming thing to itself kind of error...

hg rename FOO xxx, followed by
hg rename xxx foo achieves the goal
(Assignee)

Comment 5

5 years ago
push to try:
https://tbpl.mozilla.org/?tree=Try&rev=6b0a0f95c64d
(Assignee)

Comment 6

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8ca3fe220709
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/8ca3fe220709
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.