Closed Bug 762755 Opened 8 years ago Closed 8 years ago

de-ns-ify nsXULMenuAccessible and nsXULListboxAccessible classes

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: surkov, Assigned: capella)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Depends on: 762754
Attached patch Patch (v1) (obsolete) — Splinter Review
Woo hoo! A two-fer-one !
Attachment #631546 - Flags: review?(surkov.alexander)
Comment on attachment 631546 [details] [diff] [review]
Patch (v1)

Review of attachment 631546 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/atk/nsXULListboxAccessibleWrap.h
@@ +11,5 @@
>  
> +namespace mozilla {
> +namespace a11y {
> +
> +typedef class XULListBoxAccessible XULListBoxAccessibleWrap;

ok, if you like though I didn't think to uppercase b in box (however you keep other classes untouched like XULListitemAccessible

::: accessible/src/xul/nsXULListboxAccessible.cpp
@@ +893,5 @@
>    return NativelyUnavailable() || (mParent && mParent->NativelyUnavailable()) ?
>      states::UNAVAILABLE : states::FOCUSABLE | states::SELECTABLE;
>  }
>  
> +NS_IMETHODIMP XULListitemAccessible::GetActionName(PRUint8 aIndex, nsAString& aName)

keep NS_IMETHODIMP on separate line

::: accessible/src/xul/nsXULListboxAccessible.h
@@ +143,1 @@
>                                  public nsIAccessibleTableCell

wrong indent

::: accessible/src/xul/nsXULMenuAccessible.cpp
@@ +289,5 @@
>    // That indicates we don't walk anonymous children for menuitems
>    return false;
>  }
>  
> +NS_IMETHODIMP XULMenuitemAccessible::DoAction(PRUint8 index)

return type on own line

@@ +300,5 @@
>    return NS_ERROR_INVALID_ARG;
>  }
>  
>  /** select us! close combo box if necessary*/
> +NS_IMETHODIMP XULMenuitemAccessible::GetActionName(PRUint8 aIndex, nsAString& aName)

same

@@ +396,5 @@
>  {
>    return roles::SEPARATOR;
>  }
>  
> +NS_IMETHODIMP XULMenuSeparatorAccessible::DoAction(PRUint8 index)

same and below
Attachment #631546 - Flags: review?(surkov.alexander) → review+
Attached patch Patch (v2)Splinter Review
fyi, final for push.
Attachment #631546 - Attachment is obsolete: true
fyi on WIN, hg rename FOO foo generates a renaming thing to itself kind of error...

hg rename FOO xxx, followed by
hg rename xxx foo achieves the goal
https://hg.mozilla.org/mozilla-central/rev/8ca3fe220709
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.