763036 - Long taps broken on Top Sites tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Search suggestions changed something so that now we return an AwesomeBarItem rather than a Cursor when we call getItemFromPosition(). I'm filing this to track, but with the refactoring in bug 759041 this will be cleaner to fix, so I'm planning to just fix it there.

Comment 2

[Cristian Nicolae (:xti)]

When I long tap on an entry from Top Sites I get errors like this (one error for each long tap):

E/GeckoAwesomeBar( 9831): item at 0 is not a Cursor
E/GeckoAwesomeBar( 9831): item at 1 is not a Cursor
E/GeckoAwesomeBar( 9831): item at 2 is not a Cursor
E/GeckoAwesomeBar( 9831): item at 3 is not a Cursor

--
Firefox 16.0a1 (2012-06-19)
Device: Galaxy Nexus
OS: Android 4.0.2

Comment 3

[Peter Retzer (:pretzer)]

The respective patches of bug 759041 were already landed some time ago, even though that bug itself is not fixed yet. Therefore this works now.

Comment 4

[Adrian Tamas (:AdrianT)]

This is still an issue on Firefox Mobile 15.0b2 build 1 on HTC Desire running Android 2.2

Comment 5

[Peter Retzer (:pretzer)]

Right, the patches landed on m-c when it was 16 and were not uplifted to 15. 
Wes, is it possible to uplift those patches to Beta?
If we do that though, we probably also want to fix bug 777649 for Beta.

Comment 6

[Wesley Johnston (:wesj)]

The fix in 16 isn't something I want to push forward. I'll put together a separate patch for 15 if we want it?

Comment 7

[:Margaret Leibovic]

I think this is definitely something we need to fix for 15, since it's a regression.

Comment 8

[Wesley Johnston (:wesj)]

Attachment: Patch for beta

Since this will go straight to beta with no testing on central, thought more eyes would be better. This is pretty similar to what's on central though, without the refactor. Tested locally tapping on different entries in all three panes with and without search suggestions.

I'll ask for approval once the reviews are done.

Comment 9

[Peter Retzer (:pretzer)]

Wes, is bug 777649 also present in 15? Did you fix it with your patch here? If yes please remember that the other channels need a fix for it as well.

Comment 10

[Wesley Johnston (:wesj)]

Comment on attachment 646191 [details] [diff] [review]
Patch for beta

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Search suggestions
User impact if declined: No context menu on awesomescreen
Testing completed (on m-c, etc.): Patch on m-c is very similar, but not exactly the same. Tested locally.
Risk to taking this patch (and alternatives if risky): Low risk. Basically adds a new path and a new getter method.
String or UUID changes made by this patch: None.

Comment 11

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-beta/rev/6932a40200a3

Comment 12

[Ioana Chiorean]

Tcs added in MozTrap for Firefox 15 and later versions both phone and tablet: 

https://moztrap.mozilla.org/manage/case/6030/ Awesomescreen tablet suite - 
Long tap in Top Sites  
https://moztrap.mozilla.org/manage/case/6031/ Awesomescreen suite - 
Long tap in Top Sites