Last Comment Bug 763036 - Long taps broken on Top Sites tab
: Long taps broken on Top Sites tab
: regression
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: Wesley Johnston (:wesj)
: Sebastian Kaspari (:sebastian)
: 763963 (view as bug list)
Depends on:
Blocks: 777649
  Show dependency treegraph
Reported: 2012-06-08 13:04 PDT by Wesley Johnston (:wesj)
Modified: 2016-07-29 14:25 PDT (History)
10 users (show)
ioana.chiorean: in‑moztrap+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch for beta (4.01 KB, patch)
2012-07-26 10:23 PDT, Wesley Johnston (:wesj)
mbrubeck: review+
bnicholson: review+
akeybl: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description User image Wesley Johnston (:wesj) 2012-06-08 13:04:10 PDT
Search suggestions changed something so that now we return an AwesomeBarItem rather than a Cursor when we call getItemFromPosition(). I'm filing this to track, but with the refactoring in bug 759041 this will be cleaner to fix, so I'm planning to just fix it there.
Comment 1 User image Wesley Johnston (:wesj) 2012-06-12 09:16:25 PDT
*** Bug 763963 has been marked as a duplicate of this bug. ***
Comment 2 User image Cristian Nicolae (:xti) 2012-06-19 02:25:07 PDT
When I long tap on an entry from Top Sites I get errors like this (one error for each long tap):

E/GeckoAwesomeBar( 9831): item at 0 is not a Cursor
E/GeckoAwesomeBar( 9831): item at 1 is not a Cursor
E/GeckoAwesomeBar( 9831): item at 2 is not a Cursor
E/GeckoAwesomeBar( 9831): item at 3 is not a Cursor

Firefox 16.0a1 (2012-06-19)
Device: Galaxy Nexus
OS: Android 4.0.2
Comment 3 User image Peter Retzer (:pretzer) 2012-07-26 00:47:52 PDT
The respective patches of bug 759041 were already landed some time ago, even though that bug itself is not fixed yet. Therefore this works now.
Comment 4 User image Adrian Tamas (:AdrianT) 2012-07-26 01:56:26 PDT
This is still an issue on Firefox Mobile 15.0b2 build 1 on HTC Desire running Android 2.2
Comment 5 User image Peter Retzer (:pretzer) 2012-07-26 02:48:10 PDT
Right, the patches landed on m-c when it was 16 and were not uplifted to 15. 
Wes, is it possible to uplift those patches to Beta?
If we do that though, we probably also want to fix bug 777649 for Beta.
Comment 6 User image Wesley Johnston (:wesj) 2012-07-26 09:15:13 PDT
The fix in 16 isn't something I want to push forward. I'll put together a separate patch for 15 if we want it?
Comment 7 User image :Margaret Leibovic 2012-07-26 09:35:33 PDT
I think this is definitely something we need to fix for 15, since it's a regression.
Comment 8 User image Wesley Johnston (:wesj) 2012-07-26 10:23:41 PDT
Created attachment 646191 [details] [diff] [review]
Patch for beta

Since this will go straight to beta with no testing on central, thought more eyes would be better. This is pretty similar to what's on central though, without the refactor. Tested locally tapping on different entries in all three panes with and without search suggestions.

I'll ask for approval once the reviews are done.
Comment 9 User image Peter Retzer (:pretzer) 2012-07-26 10:58:16 PDT
Wes, is bug 777649 also present in 15? Did you fix it with your patch here? If yes please remember that the other channels need a fix for it as well.
Comment 10 User image Wesley Johnston (:wesj) 2012-07-26 12:17:12 PDT
Comment on attachment 646191 [details] [diff] [review]
Patch for beta

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Search suggestions
User impact if declined: No context menu on awesomescreen
Testing completed (on m-c, etc.): Patch on m-c is very similar, but not exactly the same. Tested locally.
Risk to taking this patch (and alternatives if risky): Low risk. Basically adds a new path and a new getter method.
String or UUID changes made by this patch: None.
Comment 11 User image Wesley Johnston (:wesj) 2012-07-30 17:47:39 PDT
Comment 12 User image Ioana Chiorean 2012-12-28 07:16:25 PST
Tcs added in MozTrap for Firefox 15 and later versions both phone and tablet: Awesomescreen tablet suite - 
Long tap in Top Sites Awesomescreen suite - 
Long tap in Top Sites

Note You need to log in before you can comment on or make changes to this bug.