steps to reproduce: 1. Load https://marketplace-dev.allizom.org/en-US/app/mozilla-marketplace/reviews 2. Click on 'More reviews' observed behavior: Nothing happens. for desktop, we should consider showing pagination. for mobile, it makes sense to do infinite load.
I think Potch said he wanted to take this one.
Was working on this last week - will polish and push shortly.
Assignee: nobody → cvan
Target Milestone: --- → 2012-06-21
Basta, can you take this? Here's a WIP patch: https://github.com/cvan/zamboni/commit/f1080ba
Assignee: cvan → mattbasta
Target Milestone: 2012-06-21 → 2012-07-12
Evidently I had another WIP patch: https://github.com/cvan/zamboni/commit/b68803a
Kevin, if you don't have time to work on reviews this week, unassign yourself and someone else can take the bug.
Target Milestone: 2012-07-26 → 2012-08-02
Blocker for reviews to go live this week.
Assignee: nobody → cvan
Target Milestone: 2012-08-02 → 2012-08-09
new WIP: https://github.com/mozilla/zamboni/commit/8a71943 This is pretty hard considering we have to maintain 20 per page on Desktop but 5 per page on Mobile (which means toggling four times then loading the next page, etc.). FWIW, the new reviews mocks do call for this: http://cl.ly/3c3q1I1m1k2u If someone (or myself) is adventurous after Reviews ships, we'll need to eventually tackle this. But to unblock us, this should suffice: https://github.com/mozilla/zamboni/commit/81f3eb7
Assignee: cvan → nobody
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: 2012-08-09 → ---
What else is left here?
No longer blocks: 766199
(In reply to Wil Clouser [:clouserw] from comment #8) > What else is left here? My patch doesn't work reliably, that's all. It looks like this: http://f.cl.ly/items/2j3704240x2Y3q3X2P2Q/Screen%20shot%202012-08-31%20at%203.18.56%20PM.png It should say "More reviews" per the mock: http://cl.ly/3c3q1I1m1k2u Also related: bug 784635 and bug 784624 comment 1.
Davor, if you're bored with reviews stuff, here's a good one that needs fixing.
Summary: Nothing happens on clicking 'More reviews' → Make pagination work better on mobile
Whiteboard: [janus] → [janus][android][see comment 9]
Whiteboard: [janus][android][see comment 9] → [janus][android][see comment 9][uinits]
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → DUPLICATE
See Also: → bug 784624
Summary: Make pagination work better on mobile → Add "more" pagination to reviews
Duplicate of bug: 784624
You need to log in before you can comment on or make changes to this bug.