764755 - Remove the aero glass style border of arrow panels and reduce the arrow size

Status: RESOLVED FIXED

(Toolkit :: Themes, enhancement)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 633090 [details] [diff] [review]
patch

I need to take care of a few edge cases...

Comment 2

[u428464]

This is part of the arrow panel redesign ? https://wiki.mozilla.org/Arrow_Panel_Redesign

Comment 3

[Dão Gottwald [:dao]]

Yes, it's part of that. I didn't know we had a feature page for this.

Comment 4

[Dão Gottwald [:dao]]

Attachment: patch v2

Comment 5

[Marco Bonardo [:mak]]

we likely also need this to properly have the downloads button as the last button in the toolbar, so adding a dep just to track that.

Comment 6

[Marco Bonardo [:mak]]

for information, are we going to reduce the size of the arrow on other themes too, or just winstripe?

Comment 7

[Dão Gottwald [:dao]]

All platforms eventually.

Comment 8

[Stephen Horlander [:shorlander]]

(In reply to Marco Bonardo [:mak] from comment #6)
> for information, are we going to reduce the size of the arrow on other
> themes too, or just winstripe?

We need to do it for all of them. I would like for them to be roughly the same structurally. Even if the styling may vary slightly.

Comment 9

[Stephen Horlander [:shorlander]]

Comment on attachment 633176 [details] [diff] [review]
patch v2

Review of attachment 633176 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, the arrow just needs a little tweaking:

- Arrow border should be a little bit darker
- Arrow needs to have a matching drop shadow
- Edges need to be a little more crisp (currently kind of blurry)
- The arrow border shouldn't overlap the panel border (creates two darker pixels)

Getting those details right with SVG might be difficult. It might better to use a PNGs instead.

I will attach a screenshot.

Comment 10

[Stephen Horlander [:shorlander]]

Attachment: Arrow Tweaks

Comment 11

[Dão Gottwald [:dao]]

Adding shadow to the arrow makes this more complicated, since the panel would move down due to the shadow extending above the arrow tip. That's why the shadow is cut off at the top in the current PNGs, which looks pretty bad. Since the arrow shadow is going to be hardly visible at this opacity and size, I'd prefer just skipping it for now.

Comment 12

[Dão Gottwald [:dao]]

Attachment: patch v3

made the arrow border darker and crisper, removed the overlapping pixels, added a very subtle shadow on the sides (not the full shadow, as explained)

Comment 13

[Stephen Horlander [:shorlander]]

Comment on attachment 633479 [details] [diff] [review]
patch v3

Review of attachment 633479 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!

Comment 14

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e983572af03f

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e983572af03f

Comment 16

[bogas04]

Can we implement this to Windows Basic / Windows Classic and other visual themes too? Coz now it is pretty generic for Windows

Comment 17

[Peter Henkel [:Terepin]]

Sorry for OT, but will they receive animations? I was kinda hoping to see them implemented in this patch. :/