Closed Bug 764810 Opened 12 years ago Closed 3 years ago

new mail notification taskbar icon remains on program exit

Categories

(Thunderbird :: OS Integration, defect)

14 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1664586

People

(Reporter: kuno.meyer, Unassigned)

References

Details

(Keywords: regression, reproducible)

User Agent: Mozilla/5.0 (Windows NT 6.0; rv:14.0) Gecko/20100101 Firefox/14.0
Build ID: 20120605113340

Steps to reproduce:

- Start Thunderbird
- Receive a new mail (--> new mail notification icon appears in the Windows taskbar)
- Quit Thunderbird


Actual results:

- The "new mail" notification icon remains in the Windows taskbar and disappears only when hit with the mouse. (As if Thunderbird was crashed on exit.)


Expected results:

- The "new mail" notification icon shoud disappear on quitting Thunderbird.
Is thunderbird.exe still running in the task manager when you see this ?
Tunderbird.exe is properly terminating. No signs of a crash like a "thunderbird.exe has stopped working" message by Windows, an entry in the Windows Event Log or some indication in "about:crashes" (provided by the ViewAbout extension).

The behaviour is reproducible in 100% of the cases.

It is a POP3 account that received the mail.
Having the same issue on TB 14 under Windows 7, x64.

As of right now I have *five* new mail notifications in Windows tray which will remain until I mouse over them, and continue to accumulate each time I load/quit TB.  It happens every single time I exit TB with new mail indicator active.

TB is not running, confirmed many times in Taskmanager.

TB shows every sign of having exited cleanly, it's just not cleaning up the unread notification prior to exit.

I was also having the issue on versions 12 & 13 - possibly more I can't keep track of the rapid releases.
Confirmed

STEPS TO REPRODUCE:

1. Send email to an account that Thunderbird is set up to check automatically.
2. Start Thunderbird and let it biff.
3. New mail icon appears in system tray.
4. Close Thunderbird.

RESULT:
Envelope remains in tray.

EXPECTED:
Thunderbird should clear the icon on close.

Seeing this on Win7x64 as well. OS->All
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows Vista → All
Hardware: x86 → All
Version: 13 → 14
2012-02-29 works
2012-03-01 fails
The changes are http://hg.mozilla.org/comm-central/pushloghtml?fromchange=271f2a50cfbb&tochange=a5e4ebd71004
However, I can't find the culprit among them.
Does anybody have a clue?
(In reply to Thomas Bertels from comment #6)
> 2012-02-29 works
> 2012-03-01 fails
> The changes are
> http://hg.mozilla.org/comm-central/
> pushloghtml?fromchange=271f2a50cfbb&tochange=a5e4ebd71004
> However, I can't find the culprit among them.
> Does anybody have a clue?

perhaps it was a moz-central checkin?

Do you still see this when using daily build https://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-central/
Flags: needinfo?(kuno.meyer)
Flags: needinfo?(tbertels+bugzilla)
Yes, still reproduceable with latest build.

The comm-central checkins are much numerous:
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2012-02-29&enddate=2012-03-01
Flags: needinfo?(tbertels+bugzilla)
Flags: needinfo?(kuno.meyer)
I've had this problem for the longest time, including 24.1.0. Hope someone would find and fix this bug - it's not a huge one but annoying!
Isn't this a windows bug? It happens with a lot of programs.
(In reply to sjw from comment #10)
> Isn't this a windows bug? It happens with a lot of programs.

Yes and no. AFAIK it is generally up to the process that placed the icon in the tray to remove it. I don't think the Windows OS takes care of it automatically. If a program terminates abnormally in Windows the tray may not refresh to reflect that the program has closed (because the process aborted without executing any instruction to remove the tray icon).
In fact, Windows only refreshes the icon when you hover/touch it with the mouse. This is what you may observe with a lot of programs.

However, the misbehaviour is clearly on Thunderbird's side because it doesn't to properly clean up the icon on exit.
The corresponding Win32 API is "Shell_NotifyIcon" (see [1]), which is called at exactly two places with the parameter "NIM_DELETE" (see [2]). The one that matters, after my opinion, is the one from the destructor of the "nsMessengerWinIntegration" class (see [3]). This class is only instantiated at nsMailModule.cpp (see [4], [5]), but actually never released? Here, my understanding of the Mozilla codebase and the XPCOM internals ends.

[1] http://msdn.microsoft.com/en-us/library/windows/desktop/bb762159%28v=vs.85%29.aspx
[2] http://mxr.mozilla.org/comm-central/ident?i=GenericShellNotify
[3] http://mxr.mozilla.org/comm-central/ident?i=nsMessengerWinIntegration
[4] http://mxr.mozilla.org/comm-central/source/mailnews/build/nsMailModule.cpp#358
[5] http://mxr.mozilla.org/comm-central/source/mozilla/xpcom/components/ModuleUtils.h#39
See Also: → 777950
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.