764812 - Too easy to close tabs by swipe

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Maybe it's just me, but I'm finding it a little too easy to close tabs by swiping by simply dragging the thumbnail not so far off screen. Perhaps this should be reduced (since we dont currently have undo-tab)?

Adding Madhava/Ian for thoughts here.

Testing on inbound:

--
Samsung Galaxy Nexus (Android 4.0.4)
20120614063825
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d4982f32837

Comment 2

[Aaron Train [:aaronmt]]

Wes is this fixed by your velocity calculation changes?

Comment 3

[Wesley Johnston (:wesj)]

Attachment: Patch

This adjusts our kill edge so that we only delete if the touch is on the left or right side of the tab from where it started.

I also talked to madhava about "fading" the row when the user enters the area where it will be deleted. Working on that. Probably fine for a separate bug.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Wesley Johnston (:wesj) from comment #3)

> I also talked to madhava about "fading" the row when the user enters the
> area where it will be deleted. Working on that. Probably fine for a separate
> bug.

Yes please. New bug.

Comment 5

[Wesley Johnston (:wesj)]

filed bug 766710

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 635057 [details] [diff] [review]
Patch

>                 if (dir == DragDirection.HORIZONTAL) {
>     
>                     int finalPos = 0;

nit: remove this blank line

>+                    if ((start.x > mList.getWidth()/2 && e.getX() < mList.getWidth()/4)) {

Add spaces around operators

>+                    } else if (start.x < mList.getWidth()/2 && e.getX() > mList.getWidth()*3/4) {

Add spaces around operators

Also, this worries me:  mList.getWidth()*3/4

Would operator precedence and rounding make this: mList.getWidth()*0.75  or  mList.getWidth()*1

Can you add parens around the (3 / 4) or just use 0.75? (3 / 4) would make it easier to follow your comment.

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc426bd053fe

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cc426bd053fe

Comment 9

[Wesley Johnston (:wesj)]

Comment on attachment 635057 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 713450
User impact if declined: Easier to accidentally close tabs
Testing completed (on m-c, etc.): landed mc 6-22
Risk to taking this patch (and alternatives if risky): low. fixes a new feature. just tweaks some constants
String or UUID changes made by this patch: none

Comment 10

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f6f345b6dc68

Comment 11

[Andreea Pod]

If I swipe to the left the tab closes only if more then half of it not in view, but if I swipe to the right the tab still closes way too easy, is this ok? 

Verified on:
- build: Firefox 16.0a1 (2012-07-08) and Firefox 15.0a2 (2012-07-08)
- device: LG Optimus 2x 
- OS: Android 2.2.2

Comment 12

[Wesley Johnston (:wesj)]

We don't care how much of the tab is in view. The idea here now is to close if your swipe starts on the left half of the tab, and ends on the right 25% of the screen, or vice versa. i.e. you could theoretically close a tab by only moving 25% of it off the screen if you start your drag in the middle of the screen. I'm guessing one of two things is happening when you swipe "right". Either

a.) You're doing the action with your thumb on the hand gripping the phone? In that case maybe in this situation you're moving your thumb towards your palm, starting the swipe in the middle of the screen the middle of the screen and dragging the tab towards the edge. I could see that being "easier" than the other case, moving your thumb away from your palm, maybe its harder to move the tab quite as far?

b.) You're able to move your finger one direction more quickly than the other.

Comment 13

[Andreea Pod]

What I see still like a problem is that if you tap in the left side of the tab and swipe to the right only a bit the tab closes and if you tap on the left side of the tab and swipe to the left, the tab closes in the right side. I filed bug 772436 for these and also made video: http://www.youtube.com/watch?v=gXjRV-slHhA&feature=youtu.be

Comment 14

[Aaron Train [:aaronmt]]

Andreea, please verify and add test-cases around this feature.

Comment 15

[Andreea Pod]

Verified fixed on:
- build: Firefox Beta 15.0 (2012-07-17)
- device: ASUS EEE Transformer (Android 4.0.3), LG Optimus 2X (Android 2.2.2)

Test-cases added in moztrap.