772436 - Tab is closed too easy when swiped to the right

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Andreea Pod]

Build: Firefox 16.0a1 (2012-07-10)
Device: LG Optimus 2X (Android 2.2.2)

Steps to reproduce:
1. Open the tab menu
2. make sure you have few tabs opened
3. tap on one of the tabs on the left side and swipe to the right but not more than the close ("X") button width 

Expected results: 
- the tab should jump back as it does when you swipe from right to left

Actual result: 
- the tab closes, please see video: http://www.youtube.com/watch?v=gXjRV-slHhA&feature=youtu.be

Note: 
- also I saw that if you tap on the left side of the tab and swipe to the left that tab closes in the right side.

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

Uh, you warned me about this rounding and I thought I paid attention, but apparently not. (3/4) is being rounded to zero before the multiplication.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 640689 [details] [diff] [review]
Patch

\o/ I am not useless... just ignored :)

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/465da27bb61b

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 640689 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 764812
User impact if declined: Sliding from the left will always close the tab.
Testing completed (on m-c, etc.): Just landed.
Risk to taking this patch (and alternatives if risky): Very low. Fixes a regression. At worst, this should have the exact same behavior as before.
String or UUID changes made by this patch: None.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/465da27bb61b

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6682659fbde7

Comment 8

[Andreea Pod]

Verified fixed on:
- build: Firefox Beta 15.0 (2012-07-17)
- device: ASUS EEE Transformer (Android 4.0.3), LG Optimus 2X (Android 2.2.2)