765632 - Kuma: Need a way to set translation parent

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Localization, defect, P1)

Description

[Les Orchard [:lorchard]]

Migration was unable to establish translation parents for some pages. For example:

    https://developer-new.mozilla.org/en-US/docs/HTML/Element/button

That page has translations in es and fr:

    {{ languages( { "es": "es/HTML/Elemento/button" ,  "fr": "fr/HTML/Element/Button" } ) }}

But, the translation parents were not migrated. So, we need the ability to manually choose a new translation parent for pages to fix this situation.

Comment 1

[David Walsh :davidwalsh]

Where would this appear?  The "edit" page?  Somewhere in "admin"?

Comment 2

[Les Orchard [:lorchard]]

I'd say Edit page, ideally. There should be a way for general wiki editors to correct translation relationships. Otherwise, we're limited to the handful of admins that exist to do the work.

Comment 3

[David Walsh :davidwalsh]

Les:

How can we tell if a translation doesn't have a parent?  Simply no parent_id?  How can I tell if something is a translation?

We should only show that new field if the translation doesn't have a parent, right?

Comment 4

[David Walsh :davidwalsh]

My proposal for this ticket is: If no "parent_id" is present, show this field as an autocompleter, much like the link editor

Comment 5

[Luke Crouch [:groovecoder]]

Sounds good to me.

Comment 6

[John Karahalis [:openjck]]

Friendly all aboard ping. We scheduled this one to be completed before the next sprint. How's it looking?

Comment 7

[David Walsh :davidwalsh]

I current have the front end completed on this branch:

    https://github.com/darkwing/kuma/tree/set-trans-parent-765632

I attempted to complete the server side with these lines:

    https://github.com/darkwing/kuma/commit/fe4454f08e3634a85b14aafae17b10395d12c504

But upon submission, I receive the following error:

    [A revision must be based on a revision of the English document. Revision ID 891 does not fit those criteria.]

Updating ticket as progress.

Comment 8

[Luke Crouch [:groovecoder]]

This is complicated by the fact that kitsune wants non-english revisions to be based_on corresponding documents' en-US revisions. MDN has always had some pages that were never based on en_US pages.

We can break it by removing the constraint, but that will also break kitsune's feature that notifies localizers when an English document changes. (See bug 671717)

So, we're deferring this feature to post-launch.

Comment 9

[John Karahalis [:openjck]]

Moving out of the release as per our discussions last week.

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/3b8495434bc67a50a23841b92a50aa222c915dca
fix bug 765632 - Adding parent-settings capabilities for translations

Adding show block logic

Progress

Updating to front-end progress

Progress

https://github.com/mozilla/kuma/commit/6879b3f8bb8e2ec4631538a09efb20737e62d80c
Merge pull request #575 from groovecoder/set-trans-parent-765632-squashed

fix bug 765632 - Adding parent-settings capabilities for translations