765777 - Make NSIS 2.46u first in Thunderbird PATH settings

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Comment 1

[John Hopkins (:jhopkins)]

Now that all win32 (and win64) build machines have NSIS 2.46u installed, we need to update our Thunderbird buildbot-configs to point at it.

Comment 2

[John Hopkins (:jhopkins)]

Attachment: nthomas' WIP patch from https://bugzilla.mozilla.org/show_bug.cgi?id=762218#c3

nthomas said:

This was enough to get
 PATH=D:\mozilla-build\nsis-2.46u;D:\mozilla-build\msys\local\bin;...
and 
 checking for makensisu-2.46... /d/mozilla-build/nsis-2.46u/makensisu-2.46
 checking for Unicode NSIS with major version == 2 and minor version >= 33... yes
in the compile step of a 'TB WINNT 5.2 comm-central build' job; log at [1].
That's using mw32-ix-slave01, a staging slave with 2.46u installed but no change to d:\mozilla-build\msys\etc\profile.d\profile-extrapaths.sh. We definitely need to clobber hard otherwise configure caches the 2.33 it found previously.

The build is still running and will need testing, but my dumps of the master indicate PATH will be modified in 'make installer' step too so it should work OK. The en-US release build uses the same factory, so it gets the change for free. The Release repacks set the env on every step, so they're OK. I think we'll need a change for nightly repacks though, env=self.env isn't currently set on the configure step.

[1] http://dev-master01.build.scl1.mozilla.com:8710/builders/TB%20WINNT%205.2%20comm-central%20build/builds/2/steps/compile/logs/stdio

Comment 3

[John Hopkins (:jhopkins)]

Attachment: updated patch

updated patch which includes win64 and win32-debug PATH setting

Comment 4

[John Hopkins (:jhopkins)]

Comment on attachment 634115 [details] [diff] [review]
updated patch

Landed in https://hg.mozilla.org/build/buildbot-configs/rev/6f59db7d63de

Comment 5

[Rail Aliiev [:rail]]

In production since today

Comment 6

[John Hopkins (:jhopkins)]

Attachment: buildbotcustom patch

pass env to various configure commands in BaseRepackFactory

Nick, I believe this should pass in the updated PATH with NSIS to NightlyRepackFactory.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

I'm not comfortable with reviewing this before it has been through staging to check that both Firefox and Thunderbird jobs are still green. L10n jobs are notoriously easy to break and more than just the path is being changed. We gain this in the builder:
            'BINSCOPE': 'C:\\Program Files (x86)\\Microsoft\\SDL BinScope\\BinScope.exe',
            'DOWNLOAD_BASE_URL': 'http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly',
            'EN_US_BINARY_URL': 'http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central',
            'HG_SHARE_BASE_DIR': 'e:/builds/hg-shared',
            'MOZ_CRASHREPORTER_NO_REPORT': '1',
            'MOZ_MAKE_COMPLETE_MAR': '1',
            'MOZ_OBJDIR': 'obj-firefox',
            'MOZ_SIGN_CMD': < WithProperties "python %(toolsdir)s/release/signing/signtool.py --cachedir %(basedir)s/signing_cache -t %(basedir)s/token -n %(basedir)s/nonce -c %(toolsdir)s/release/signing/host.cert -H dev-master01.build.mozilla.org:8080" > ,
            'MOZ_UPDATE_CHANNEL': 'nightly',
            'PATH': '${MOZILLABUILD}buildbotve\\scripts;${PATH}',
            'PDBSTR_PATH': '/c/Program Files/Debugging Tools for Windows (x64)/srcsrv/pdbstr.exe',
            'POST_SYMBOL_UPLOAD_CMD': '/usr/local/bin/post-symbol-upload.py',
            'SYMBOL_SERVER_HOST': 'symbols1.dmz.phx1.mozilla.com',
            'SYMBOL_SERVER_PATH': '/mnt/netapp/breakpad/symbols_ffx/',
            'SYMBOL_SERVER_SSH_KEY': '/c/Users/cltbld/.ssh/ffxbld_dsa',
            'SYMBOL_SERVER_USER': 'ffxbld',
            'TINDERBOX_OUTPUT': '1'

The MOZ_OBJDIR might be problematic.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

I reran comm-beta's 0f9abbfdb5a6 and verified it picked up NSIS 2.46 in configure, the build is at http://ftp.mozilla.org/pub/mozilla.org/thunderbird/tinderbox-builds/comm-beta-win32/1339865784/thunderbird-14.0.en-US.win32.installer.exe

Similarly, comm-central cff415a502cb is at http://stage.mozilla.org/pub/mozilla.org/thunderbird/tinderbox-builds/comm-central-win32/1340030304/thunderbird-16.0a1.en-US.win32.installer.exe

Standard8, could you verify bug 760807 is fixed in those ?

Comment 9

[John Hopkins (:jhopkins)]

Usul will verify this tomorrow.

Comment 10

[John Hopkins (:jhopkins)]

(In reply to Nick Thomas [:nthomas] from comment #7)
> I'm not comfortable with reviewing this before it has been through staging
> to check that both Firefox and Thunderbird jobs are still green.

I've set aside some build machines on http://dev-master01.build.scl1.mozilla.com:8900 to do some testing.  I'll see if I can test a fix for bug 725839 at the same time.

Comment 11

[Mark Banner (:standard8)]

(In reply to Nick Thomas [:nthomas] from comment #8)
> Standard8, could you verify bug 760807 is fixed in those ?

I've just done a quick examination of the helper.exe and they seem to have the correct compatibility specifications in them, so I think they are fine. I'll let Ludovic do the full verification tomorrow though.

Comment 12

[Ludovic Hirlimann [:Usul]]

And I'm signing this off - works like a charm.

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 634160 [details] [diff] [review]
buildbotcustom patch

Please request review when testing is complete, thanks.

Comment 14

[Rail Aliiev [:rail]]

(In reply to Ludovic Hirlimann [:Usul] from comment #12)
> And I'm signing this off - works like a charm.

Closing.