80401 - ftp folders show as single bookmarks in the toplevel menu and Manager

Status: VERIFIED INVALID

(SeaMonkey :: Bookmarks & History, defect, P5)

Description

[Claudius Gayle]

***Overview Description: 
  When 'extended-data views' are on and working ftp:// links show as individual bookmarks instead of
folders. This used to be the case with the IE favorites folder (bug 76618) but that has been fixed. File://
links seem to behave correctly as well so I believe that just leaves ftp:// links. These links show correctly
in the personal toolbar and in the bookmarks popup button on the personal toolbar, but NOT in the
bookmarks manager window or the toplevel bookmarks menu.

***Steps to Reproduce: 
1) In prefs: Debug|Networking uncheck 'Enable html directory listing'
2) Also the pref (now hidden) for extended date views must be turned on (Ben what is this pref?)
3) Bookmark an ftp site
4) look at it in the toplevel menu or bookmarks manager
5) Now look at it using the bookmarks button on the personal toolbar (that's a pref too)

***Actual Results: 

It's shown as a folder on the ptoolbar but nowhere else.

***Expected Results: 

Should be a folder everywhere

***Build Date & Platform Info: 

exists in 20010511 builds on all platforms and has for some time now. off shoot of bug 76618

Comment 1

[Bradley Baetz]

As an aside, I have a patch so that this works without needing the to disable
the html directory listing - see bug 78148.

Anyway, I'll attach the obvious fixes.

The extended data pref doesn't appear to be used, according to an lxr search.
The only mention of it is in pref-bookmarks.xul

Ben, can I get r/sr on this patch?

Comment 2

[Bradley Baetz]

Attachment: patch

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

I believe the aggregated FTP view was disabled deliberately (I disabled it)
because of complaints from users that the view was unwieldy when showing large
listings, and the expected behaviour was to just load the link in the content area.

If the personal toolbar deviates from this behaviour, that is the bug. 

Comment 4

[Bradley Baetz]

Pushing back to Ben to resolve, one way or the other.

Comment 5

[Bradley Baetz (:bbaetz)]

If the feature has been removed, then the ui for it needs to go. Nominating for
nsbeta1 - currently directory bookmarks can't be used at all from some menus,
since they don't expand either, so its just confusing.

The patch would be about two lines (removing rdf:httpindex), as soon as someone
(Ben?) works out the cright thing to do.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

Remaining places, according to LXR:

- bookmarks button on personal toolbar
- personal toolbar
- bookmarks panel. 

Easy to fix. 

Comment 7

[Bradley Baetz (:bbaetz)]

*** Bug 85330 has been marked as a duplicate of this bug. ***

Comment 8

[sairuh (rarely reading bugmail)]

workaround from bug 85330: remove the trailing / at the end of the ftp url. then
the icon in the toolbar, as well as the bookmarks-toolbar entry, appear and work
fine.

Comment 9

[A.j. Lavin]

This bug still exists in Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4+)
Gecko/20010914.

I want to add to this bug report to try to clarify what I read as rambling
confusion shown so far in this bug report. And also to remind you that this bug
still exists.

Steps to reproduce:

1. Open Mozilla and visit an ftp directory, such as
ftp://ftp.netexpress.net/pub/pam/.

2. Drag the URL to the Bookmarks Side Panel in order to create a bookmark for
the ftp directory.

3. Notice that a folder appears in the Bookmarks Side Panel that has the same
name as the ftp directory.

4. Click on the + sign next to the side panel bookarm to open the folder.

5. Notice that the folder is in fact empty, despite the fact that the ftp
directory contains several entries.

6. Right mouse click on the same ftp directory bookmark, and select Open from
the drop down list. Notice that the main window loads the ftp directory.

7. Select the bookmark through the Bookmarks menu. Notice that this also loads
the ftp directory in the main window.

Not knowing what the intended behavior of ftp directory bookmarks in the sidebar
is, I can still say that the current behavior is broken. Clicking on these
bookmarks has no effect whatsoever, which is surprizing to the user.

I would not be surprized if clicking on these bookmarks loaded the ftp directory
in the main window.

I also would not be surprized if clicking on the + sign next to these bookmarks
 listed the entries of the ftp directory in the sidebar. 

I am, however, surprized and disappointed that clicking on on an ftp directory
sidebar folder does nothing whatsoever.

Comment 10

[Bradley Baetz (:bbaetz)]

Right, this feature has only been partly disabled. Since its bad ui, and I want 
to get rid of the rdf datasource for this in the long term, we should remove it 
totally.

Ben?

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 12

[Bradley Baetz (:bbaetz)]

Invalid. This has been turned off (well, it will be when ben checks in bug 70269
after the tree turns green)

Comment 13

[sairuh (rarely reading bugmail)]

mass-verifying Invalid bugs which haven't changed since 2001-12-31.

use the search string "PinballWizard" if you want to filter out this msg.