766432 - IonMonkey: Integrate with VTune

Status: RESOLVED DUPLICATE of bug 1332466

(Core :: JavaScript Engine, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: WIP v0

Very hacked up patch. Works, basically, but there are holes in JIT code coverage (like VMWrappers/OOL paths).

This patch also takes out ebp as a general register (if --enable-profiling) and saves it in prologues, so VTune can construct js->js callstacks.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: wip v1

this version maps VMWrappers (unfortunately, i couldnt grab the function names), and ICs, which show as things like "ic-getprop-native" and map to the file and line the property access occurred on (rather than the place they were potentially inlined).

Comment 2

[Joe Olivas]

I have been crashing with the v1 patch, and it looks to be caused by the disabling of the check if the profiler is running. Uncommenting this check appears to fix in the small test case I have run so far: 


+++ b/js/src/ion/IonCaches.cpp
@@ -52,16 +52,41 @@
> 
> #include "vm/Stack.h"
> #include "IonFrames-inl.h"
> 
> using namespace js;
> using namespace js::ion;
> 
> void
>+InstrumentCache(IonCode *code, JSScript *script, jsbytecode *pc, const char *name)
>+{
>+#ifdef MOZ_VTUNE
>+    //if (iJIT_SAMPLING_ON != iJIT_IsProfilingActive())
>+    //    return;

Comment 3

[Joe Olivas]

The fix I suggested above turns out to be more of a workaround while there is no collection.

I think the cause is that the JSScript * in the second argument is coming in as NULL, so script->filename is failing.

Comment 4

[David Mandelin [:dmandelin]]

Attachment: rebased wip 1

Comment 5

[Joe Olivas]

Attachment: wipv1 + Windows support + bugfix

Showing Windows a little love, and fixing a compile error in jsdbgapi.h.

Comment 6

[Joe Olivas]

Attachment: wipv1 + Windows support + bugfix

Minor change to fix VTune crash on finalization.

Comment 7

[Joe Olivas]

Attachment: wipv1 + Windows support + bugfix

Comment 8

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: WIP v2

Entirely new patch based on bug 785234, includes some of Joe's fixes. This one is factored with the intent of being checked in, and tries to be smarter about reporting inlined function calls. I still have to get out-of-line chunks and ICs working.

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: WIP v2 actual patch

Can't actually test yet, but it builds.

Comment 10

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: more generalized patch

This version removes the VTune dependency for mapping line numbers, so it should be usable by SPS and OProfile as well. It also adds OOL support.

TODO: testing, ICs, x64.