Closed
Bug 766481
Opened 12 years ago
Closed 12 years ago
Handle window.alert/prompt/confirm in <iframe> within <iframe mozbrowser>
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: timdream, Assigned: justin.lebar+bug)
References
Details
(Whiteboard: [qa+])
Attachments
(2 files, 1 obsolete file)
5.38 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
1.31 KB,
patch
|
mounir
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #742944 +++ Gaia issue: https://github.com/mozilla-b2g/gaia/issues/1802 For HTML structure like this: <iframe mozbrower> <iframe> <button onclick="alert('hi')">Alert</button> </iframe> </iframe> The alert() call can bypass the mozbrowser capability implemented in Bug #742944 STR: Launch Gaia "UI Tests" app and try the alert/prompt test.
Reporter | ||
Updated•12 years ago
|
Summary: Handle window.open in <iframe mozbrowser> → Handle window.open in <iframe> within <iframe mozbrowser>
Assignee | ||
Comment 1•12 years ago
|
||
Is the problem alert() or window.open? Or do both not work within <iframe>s?
Assignee | ||
Comment 2•12 years ago
|
||
Also, these dependencies / blocking bugs are probably not what you mean, but I'm not sure what you mean for this bug to cover, so I don't want to change them.
Reporter | ||
Comment 3•12 years ago
|
||
@jlebar Yeah I totally missed up with the dependency thing ... I've updated the title. Can you fix the dependency? Thanks.
Summary: Handle window.open in <iframe> within <iframe mozbrowser> → Handle window.alert/prompt/confirm in <iframe> within <iframe mozbrowser>
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
blocking-basecamp: + → ---
blocking-kilimanjaro: + → ---
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #635170 -
Flags: review?(mounir)
Assignee | ||
Comment 5•12 years ago
|
||
This was a pretty dumb bug. Oh well.
Attachment #635171 -
Flags: review?(mounir)
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → justin.lebar+bug
Updated•12 years ago
|
Component: General → DOM: Mozilla Extensions
Product: Boot2Gecko → Core
QA Contact: general → general
Assignee | ||
Comment 6•12 years ago
|
||
Even better; now it's a one-line fix.
Attachment #635170 -
Attachment is obsolete: true
Attachment #635170 -
Flags: review?(mounir)
Attachment #636066 -
Flags: review?(mounir)
Updated•12 years ago
|
Attachment #636066 -
Flags: review?(mounir) → review+
Updated•12 years ago
|
Attachment #635171 -
Flags: review?(mounir) → review+
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d https://hg.mozilla.org/mozilla-central/rev/a6a8b50651e1
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Updated•12 years ago
|
Whiteboard: [qa+]
Comment 8•12 years ago
|
||
What is the change to nsGenericElement.cpp ? https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #8) > What is the change to nsGenericElement.cpp ? > https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d Known bug in hg, although I can't find the bug at the moment. It seems to be harmless, although certainly quite scary.
Updated•11 years ago
|
Component: DOM: Mozilla Extensions → DOM
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•