Closed Bug 766481 Opened 8 years ago Closed 8 years ago

Handle window.alert/prompt/confirm in <iframe> within <iframe mozbrowser>

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: timdream, Assigned: justin.lebar+bug)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa+])

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #742944 +++

Gaia issue: https://github.com/mozilla-b2g/gaia/issues/1802

For HTML structure like this:

<iframe mozbrower>
    <iframe>
       <button onclick="alert('hi')">Alert</button>
    </iframe>
</iframe>

The alert() call can bypass the mozbrowser capability implemented in Bug #742944

STR:

Launch Gaia "UI Tests" app and try the alert/prompt test.
Summary: Handle window.open in <iframe mozbrowser> → Handle window.open in <iframe> within <iframe mozbrowser>
Is the problem alert() or window.open?

Or do both not work within <iframe>s?
Also, these dependencies / blocking bugs are probably not what you mean, but I'm not sure what you mean for this bug to cover, so I don't want to change them.
@jlebar Yeah I totally missed up with the dependency thing ...

I've updated the title. Can you fix the dependency? Thanks.
Summary: Handle window.open in <iframe> within <iframe mozbrowser> → Handle window.alert/prompt/confirm in <iframe> within <iframe mozbrowser>
No longer blocks: 752013, 763602, 744451
No longer depends on: 764718, 742944, 758297, 762049, 764414, 766207
blocking-basecamp: + → ---
blocking-kilimanjaro: + → ---
Blocks: 741587
No longer depends on: 741587
Attached patch Patch, v1 (obsolete) — Splinter Review
Attachment #635170 - Flags: review?(mounir)
Attached patch Tests, v1Splinter Review
This was a pretty dumb bug.  Oh well.
Attachment #635171 - Flags: review?(mounir)
Assignee: nobody → justin.lebar+bug
Component: General → DOM: Mozilla Extensions
Product: Boot2Gecko → Core
QA Contact: general → general
Blocks: 766871
Attached patch Patch v2Splinter Review
Even better; now it's a one-line fix.
Attachment #635170 - Attachment is obsolete: true
Attachment #635170 - Flags: review?(mounir)
Attachment #636066 - Flags: review?(mounir)
Attachment #636066 - Flags: review?(mounir) → review+
Attachment #635171 - Flags: review?(mounir) → review+
https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d
https://hg.mozilla.org/mozilla-central/rev/a6a8b50651e1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Whiteboard: [qa+]
What is the change to nsGenericElement.cpp ?
https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d
(In reply to Olli Pettay [:smaug] from comment #8)
> What is the change to nsGenericElement.cpp ?
> https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d

Known bug in hg, although I can't find the bug at the moment.  It seems to be harmless, although certainly quite scary.
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.