Handle window.alert/prompt/confirm in <iframe> within <iframe mozbrowser>

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: timdream, Assigned: Justin Lebar (not reading bugmail))

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

([qa+])

Attachments

(2 attachments, 1 obsolete attachment)

+++ This bug was initially created as a clone of Bug #742944 +++

Gaia issue: https://github.com/mozilla-b2g/gaia/issues/1802

For HTML structure like this:

<iframe mozbrower>
    <iframe>
       <button onclick="alert('hi')">Alert</button>
    </iframe>
</iframe>

The alert() call can bypass the mozbrowser capability implemented in Bug #742944

STR:

Launch Gaia "UI Tests" app and try the alert/prompt test.
Summary: Handle window.open in <iframe mozbrowser> → Handle window.open in <iframe> within <iframe mozbrowser>
(Assignee)

Comment 1

5 years ago
Is the problem alert() or window.open?

Or do both not work within <iframe>s?
(Assignee)

Comment 2

5 years ago
Also, these dependencies / blocking bugs are probably not what you mean, but I'm not sure what you mean for this bug to cover, so I don't want to change them.
@jlebar Yeah I totally missed up with the dependency thing ...

I've updated the title. Can you fix the dependency? Thanks.
Summary: Handle window.open in <iframe> within <iframe mozbrowser> → Handle window.alert/prompt/confirm in <iframe> within <iframe mozbrowser>
(Assignee)

Updated

5 years ago
No longer blocks: 752013, 763602, 744451
No longer depends on: 764718, 742944, 758297, 762049, 764414, 766207
(Assignee)

Updated

5 years ago
blocking-basecamp: + → ---
blocking-kilimanjaro: + → ---
(Assignee)

Updated

5 years ago
Blocks: 741587
No longer depends on: 741587
(Assignee)

Comment 4

5 years ago
Created attachment 635170 [details] [diff] [review]
Patch, v1
Attachment #635170 - Flags: review?(mounir)
(Assignee)

Comment 5

5 years ago
Created attachment 635171 [details] [diff] [review]
Tests, v1

This was a pretty dumb bug.  Oh well.
Attachment #635171 - Flags: review?(mounir)
(Assignee)

Updated

5 years ago
Assignee: nobody → justin.lebar+bug
Component: General → DOM: Mozilla Extensions
Product: Boot2Gecko → Core
QA Contact: general → general
(Assignee)

Updated

5 years ago
Blocks: 766871
(Assignee)

Comment 6

5 years ago
Created attachment 636066 [details] [diff] [review]
Patch v2

Even better; now it's a one-line fix.
Attachment #635170 - Attachment is obsolete: true
Attachment #635170 - Flags: review?(mounir)
Attachment #636066 - Flags: review?(mounir)
Attachment #636066 - Flags: review?(mounir) → review+
Attachment #635171 - Flags: review?(mounir) → review+
https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d
https://hg.mozilla.org/mozilla-central/rev/a6a8b50651e1
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16

Updated

5 years ago
Whiteboard: [qa+]
What is the change to nsGenericElement.cpp ?
https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d
(Assignee)

Comment 9

5 years ago
(In reply to Olli Pettay [:smaug] from comment #8)
> What is the change to nsGenericElement.cpp ?
> https://hg.mozilla.org/mozilla-central/rev/f3cd319dd52d

Known bug in hg, although I can't find the bug at the moment.  It seems to be harmless, although certainly quite scary.
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.