Closed
Bug 766808
Opened 12 years ago
Closed 12 years ago
Cannot launch apps with icons using a relative url
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)
Tracking
(blocking-kilimanjaro:?, firefox16 verified)
Tracking | Status | |
---|---|---|
firefox16 | --- | verified |
People
(Reporter: jsmith, Assigned: wesj)
References
Details
(Whiteboard: [blocking-webrtandroid1+])
Attachments
(1 file)
5.21 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Steps: 1. Go to testmanifest.com 2. Modify the manifest to have icons point to non-existent locations 3. Save it 4. Install the web app 5. Go to about:apps and try to launch it Expected: The app should start in a chromeless window. Actual: Nothing happens.
Reporter | ||
Updated•12 years ago
|
Summary: Cannot launch apps with icons pointing to a 404 from about:apps → Cannot launch apps with icons pointing to a non-existent location from about:apps
Reporter | ||
Comment 1•12 years ago
|
||
With the fix to have default icons for apps without icons, I'm wondering if that will fix this problem by caveat. Re-test this to ensure.
Keywords: qawanted
Reporter | ||
Updated•12 years ago
|
Blocks: Blocking-FFA-WebRT1+
Comment 2•12 years ago
|
||
I've just experienced this with an app that doesn't specify an icon (so has the default icon on Desktop), rather than an icon that doesn't exist.
Reporter | ||
Comment 3•12 years ago
|
||
(In reply to Andrew Williamson [:eviljeff] from comment #2) > I've just experienced this with an app that doesn't specify an icon (so has > the default icon on Desktop), rather than an icon that doesn't exist. Ah, good point. Just saw that happen, although the build today for me does not show the default icon yet when you don't specify an icon.
Reporter | ||
Updated•12 years ago
|
Summary: Cannot launch apps with icons pointing to a non-existent location from about:apps → Cannot launch apps with no icons specified or icons pointing to a non-existent location from about:apps
Comment 4•12 years ago
|
||
(In reply to Jason Smith [:jsmith] from comment #3) > (In reply to Andrew Williamson [:eviljeff] from comment #2) > > I've just experienced this with an app that doesn't specify an icon (so has > > the default icon on Desktop), rather than an icon that doesn't exist. > > Ah, good point. Just saw that happen, although the build today for me does > not show the default icon yet when you don't specify an icon. Yeah, I don't get a default icon either on Android. Actually I suppose my issue was more bug 749618 than this one.
Comment 5•12 years ago
|
||
I figure this is the same thing I'm seeing when installing 'Galactians 2' [1]. No shortcut is created, and in about:apps; I see no icon but mere text that is still un-launchable. [1] https://marketplace.mozilla.org/en-US/app/galactians2/ -- Nightly (06/29) Samsung Galaxy Nexus (Android 4.0.4)
Updated•12 years ago
|
blocking-kilimanjaro: --- → ?
Assignee | ||
Comment 6•12 years ago
|
||
Galactians 2 has an icon specified and desktop Firefox manages to find it just fine. I think there's a different problem there.
Comment 7•12 years ago
|
||
Nevermind, comment #5 -> bug 769712
Reporter | ||
Comment 8•12 years ago
|
||
The issue about being unable to launch apps that have invalid icons will likely be resolved by bug 766260. I can launch apps now that do not have icons, although launching in general from the notification appears to be broken (that's a separate issue).
Assignee | ||
Comment 9•12 years ago
|
||
Resolve relative urls using the app origin.
Assignee: nobody → wjohnston
Attachment #637989 -
Flags: review?(mark.finkle)
Reporter | ||
Updated•12 years ago
|
No longer blocks: Blocking-FFA-WebRT1+
Assignee | ||
Updated•12 years ago
|
Summary: Cannot launch apps with no icons specified or icons pointing to a non-existent location from about:apps → Cannot launch apps with icons using a relative url
Comment 10•12 years ago
|
||
Comment on attachment 637989 [details] [diff] [review] Patch This keeps getting more and more complicated
Attachment #637989 -
Flags: review?(mark.finkle) → review+
Updated•12 years ago
|
tracking-fennec: --- → ?
status-firefox16:
--- → affected
Reporter | ||
Updated•12 years ago
|
QA Contact: aaron.train
Reporter | ||
Updated•12 years ago
|
Blocks: Blocking-FFA-WebRT1+
Priority: -- → P1
Assignee | ||
Comment 12•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/422dcbefb833
Reporter | ||
Updated•12 years ago
|
Whiteboard: [qa+]
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/422dcbefb833
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Updated•12 years ago
|
status-firefox16:
affected → ---
Comment 14•12 years ago
|
||
V-F via Nightly (07/12), Samsung Galaxy Nexus (Android 4.1.1)
Reporter | ||
Updated•12 years ago
|
Whiteboard: [blocking-webrtandroid1+]
Updated•10 years ago
|
tracking-fennec: ? → ---
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•