766904 - Make sure unlockOrientation() is a no-op if the orientation wasn't locked

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 635242 [details] [diff] [review]
Patch v1

Review of attachment 635242 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoScreenOrientationListener.java
@@ +163,5 @@
>  
>    public void unlockScreenOrientation() {
> +    if (!mIsLocked) {
> +      return;
> +    }

how about?
if (GeckoApp.mAppContext.getRequestedOrientation() == ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED)
    return;

rather than introduce this new state that needs to be maintained.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 635267 [details] [diff] [review]
Patch v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 740190
User impact if declined: with bug 764753, we are going to call unlockOrientation() every time a nsScreen is killed. We want to make sure doing so when there was no orientation lock is a no-op in that case.
Risk to taking this patch (and alternatives if risky): regressions like unlock() not being called but that seems safe enough...
String or UUID changes made by this patch: none

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5a1a4ae9172d

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 635267 [details] [diff] [review]
Patch v2

[Triage Comment]
Low risk, Fennec Native only fix. Approved for Aurora 15.

Comment 6

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f770790a44cb

Comment 7

[Scoobidiver (away)]

Target Milestone is for m-c.