HTMLObjectElement and HTMLSharedObjectElement should trigger LoadObject in more cases

RESOLVED INCOMPLETE

Status

()

Core
Plug-ins
RESOLVED INCOMPLETE
6 years ago
a year ago

People

(Reporter: johns, Unassigned)

Tracking

(Depends on: 1 bug)

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
Right now nsHTMLSharedObjectElement doesn't hook UnsetAttr(), and neither handle the addition of <param> tags or type changes, which may change our decision of what type to load.
(Reporter)

Updated

6 years ago
Status: NEW → ASSIGNED
Summary: nsHTMLObjectElement and nsHTMLSharedObject element should trigger LoadObject in more cases → nsHTMLObjectElement and nsHTMLSharedObjectElement should trigger LoadObject in more cases
(Reporter)

Updated

6 years ago
Blocks: 783059
(Reporter)

Comment 1

6 years ago
Note that we need to be careful not to needlessly instantiate a plugin multiple times

> var obj = document.createElement("object");
> document.body.appendChild(obj);
> obj.type = "application/x-shockwave-flash";
> obj.data = "./vid.swf";

If we LoadObject() when the type attribute changes, we might start instantiating flash as a channel-less plugin, only to invalidate that when .data is set. This could also regress bug 781394 in a similar manner. We likely need to queue up script runners on property changes.
Depends on: 781394
(Reporter)

Updated

6 years ago
Blocks: 309533
(Reporter)

Updated

6 years ago
No longer blocks: 783059
Depends on: 783059
(Reporter)

Comment 2

6 years ago
test_object.html added by bug 783059 will need workarounds removed when this lands
(Reporter)

Updated

5 years ago
Blocks: 856816
(Reporter)

Updated

5 years ago
No longer blocks: 856816
(Reporter)

Updated

5 years ago
Blocks: 872098
(Reporter)

Updated

5 years ago
Assignee: jschoenick → nobody
Status: ASSIGNED → NEW
Summary: nsHTMLObjectElement and nsHTMLSharedObjectElement should trigger LoadObject in more cases → HTMLObjectElement and HTMLSharedObjectElement should trigger LoadObject in more cases
(Reporter)

Updated

5 years ago
Whiteboard: [good first bug][mentor=johns][lang=c++]
(Reporter)

Updated

5 years ago
No longer blocks: 872098
Depends on: 872098
(Reporter)

Comment 3

5 years ago
Once bug 872098 is fixed this becomes a trivial fix
Whiteboard: [good first bug][mentor=johns][lang=c++]
(Reporter)

Comment 4

5 years ago
(In reply to John Schoenick [:johns] from comment #3)
> Once bug 872098 is fixed this becomes a trivial fix

Ack, confused bug numbers -- bug 856816 rather
Blocks: 872098
Depends on: 856816
No longer depends on: 872098

Comment 5

a year ago
Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.