Closed Bug 767631 Opened 12 years ago Closed 7 years ago

HTMLObjectElement and HTMLSharedObjectElement should trigger LoadObject in more cases

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: johns, Unassigned)

References

Details

Right now nsHTMLSharedObjectElement doesn't hook UnsetAttr(), and neither handle the addition of <param> tags or type changes, which may change our decision of what type to load.
Status: NEW → ASSIGNED
Summary: nsHTMLObjectElement and nsHTMLSharedObject element should trigger LoadObject in more cases → nsHTMLObjectElement and nsHTMLSharedObjectElement should trigger LoadObject in more cases
Blocks: 783059
Note that we need to be careful not to needlessly instantiate a plugin multiple times

> var obj = document.createElement("object");
> document.body.appendChild(obj);
> obj.type = "application/x-shockwave-flash";
> obj.data = "./vid.swf";

If we LoadObject() when the type attribute changes, we might start instantiating flash as a channel-less plugin, only to invalidate that when .data is set. This could also regress bug 781394 in a similar manner. We likely need to queue up script runners on property changes.
Depends on: 781394
Blocks: 309533
No longer blocks: 783059
Depends on: 783059
test_object.html added by bug 783059 will need workarounds removed when this lands
Blocks: 856816
No longer blocks: 856816
Blocks: 872098
Assignee: jschoenick → nobody
Status: ASSIGNED → NEW
Summary: nsHTMLObjectElement and nsHTMLSharedObjectElement should trigger LoadObject in more cases → HTMLObjectElement and HTMLSharedObjectElement should trigger LoadObject in more cases
Whiteboard: [good first bug][mentor=johns][lang=c++]
No longer blocks: 872098
Depends on: 872098
Once bug 872098 is fixed this becomes a trivial fix
Whiteboard: [good first bug][mentor=johns][lang=c++]
(In reply to John Schoenick [:johns] from comment #3)
> Once bug 872098 is fixed this becomes a trivial fix

Ack, confused bug numbers -- bug 856816 rather
Blocks: 872098
Depends on: 856816
No longer depends on: 872098
Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.