767631 - HTMLObjectElement and HTMLSharedObjectElement should trigger LoadObject in more cases

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Plug-ins, defect)

Description

[John Schoenick [:johns]]

Right now nsHTMLSharedObjectElement doesn't hook UnsetAttr(), and neither handle the addition of <param> tags or type changes, which may change our decision of what type to load.

Comment 1

[John Schoenick [:johns]]

Note that we need to be careful not to needlessly instantiate a plugin multiple times

> var obj = document.createElement("object");
> document.body.appendChild(obj);
> obj.type = "application/x-shockwave-flash";
> obj.data = "./vid.swf";

If we LoadObject() when the type attribute changes, we might start instantiating flash as a channel-less plugin, only to invalidate that when .data is set. This could also regress bug 781394 in a similar manner. We likely need to queue up script runners on property changes.

Comment 2

[John Schoenick [:johns]]

test_object.html added by bug 783059 will need workarounds removed when this lands

Comment 3

[John Schoenick [:johns]]

Once bug 872098 is fixed this becomes a trivial fix

Comment 4

[John Schoenick [:johns]]

(In reply to John Schoenick [:johns] from comment #3)
> Once bug 872098 is fixed this becomes a trivial fix

Ack, confused bug numbers -- bug 856816 rather

Comment 5

[Benjamin Smedberg]

Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.