76770 - wording in "can't change" message incorrect (or let submitter add keywords?)

Status: RESOLVED WORKSFORME

(Bugzilla :: Bugzilla-General, defect, P2)

Description

[Garth Wallace]

When trying to nominate a bug I submitted for mozilla 1.0 by adding the
mozilla1.0 keyword, I get the error message "Only the owner or submitter of the
bug, or a sufficiently empowered user, may make that change to the keywords
field." in black in a red box. However, I *am* the submitter. I suspect that
this is a problem with the wording of the error message and not with the user
checking.

Comment 1

[Jacob Steenhagen]

IIRC, a submitter is suposed to be 'sufficiently empowered'... in witch case it
is an error w/the user checking.

Comment 2

[Jacob Steenhagen]

Looking at post_bug.cgi, line 175 makes it sound like the reporter should only
be allowed to change the status...

175 # Let reporter change bug status, even if they can't edit bugs.
176 # If reporter can't re-open their bug they will just file a duplicate.
177 # While we're at it, let them close their own bugs as well.
178 if ( ($f eq "bug_status") && ($whoid eq $reporterid) ) {
179     return 1;
180 }

But later on at line 200 it looks like the reporter can edit anything...

200 } elsif ($reporterid eq $whoid || $ownerid eq $whoid ||
201          $qacontactid eq $whoid) {
202     return 1;
203 }
(This is an elsif for "Changing state to an opened that other than UNCONFIRMED)

Am I misinterpiting what this last code bit does?  If so, then the wording in
the error message is wrong.  Otherwise, there's a bug somewhere in this
user/permission checking code.

Comment 3

[Matthew Tuck [:CodeMachine]]

See also bug #40970.

Comment 4

[Andreas Franke (gone)]

-> Bugzilla product, General component (decide permissions policy),
reassigning.

Comment 5

[Gervase Markham [:gerv]]

*** Bug 40970 has been marked as a duplicate of this bug. ***

Comment 6

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 7

[Joel Peshkin]

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being
retargeted to 2.20
If you plan to act on one immediately, go ahead and pull it back to 2.18.

Comment 8

[Dave Miller [:justdave]]

This bug appears to have been reported against version 2.10 of Bugzilla, based
on both the version field and the timestamp when the bug was filed (2.12 came
out two weeks after this bug was filed).

I'm unable to reproduce this problem on any currently supported version of
Bugzilla (2.16 and up).  If anyone still has this problem, please reopen the bug.