Closed
Bug 767918
Opened 12 years ago
Closed 6 years ago
Remove Java Console extensions in the install directory's extensions directory on install and app update.
Categories
(SeaMonkey :: Installer, defect)
Tracking
(seamonkey2.49esr wontfix, seamonkey2.60 fixed, seamonkey2.53 affected, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.60
People
(Reporter: philip.chee, Assigned: frg)
Details
(Whiteboard: [good first bug][lang=NSIS][level=apprentice])
Attachments
(1 file, 1 obsolete file)
|
2.72 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Firefox fixed this in Bug 597235 and Bug 654131. We should do the same. Our NSIS installer macros are sufficiently similar that this is likely to be a straight one to one port.
|
||
Comment 1•11 years ago
|
||
Can you confirm that you're still working on this bug?
Flags: needinfo?(installer)
|
Reporter | |
Comment 2•11 years ago
|
||
That't the default assignee. It's now a GFB looking for a volunteer. I'll change the flags to take it of your radar.
Flags: needinfo?(installer)
|
|
Reporter | |
Updated•11 years ago
|
Assignee: installer → nobody
|
|
||
Updated•10 years ago
|
Mentor: bugspam.Callek
Whiteboard: [good first bug][mentor=mscmurf/Callek][lang=NSIS][level=apprentice] → [good first bug][lang=NSIS][level=apprentice]
|
|
Reporter | |
Updated•10 years ago
|
Mentor: bugzilla
Attachment #8696366 -
Flags: review?(bugzilla)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8696366 [details] [diff] [review] ahmed3.patch Review of attachment 8696366 [details] [diff] [review]: ----------------------------------------------------------------- Hi Medka, thanks for the patch! Take a look at my comment below. ::: suite/installer/windows/nsis/shared.nsh @@ +799,5 @@ > +!macro RemoveDeprecatedFiles > + ; Remove talkback if it is present (remove after bug 386760 is fixed) > + ${If} ${FileExists} "$INSTDIR\extensions\talkback@mozilla.org\" > + RmDir /r /REBOOTOK "$INSTDIR\extensions\talkback@mozilla.org\" > + ${EndIf} Can you remove this part? :) Bug 386760 has already been fixed quite a while ago, also(?) we don't ship Talkback for quite a few years now.
|
||
Updated•6 years ago
|
Mentor: bugspam.Callek
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Mentor: bugzilla
|
|
Assignee | |
Comment 5•6 years ago
|
||
Firefox removed most of the console extensions covered in the previous patch but added some newer in. I just used a generic loop to kill them all. Starting with 2.50 the plugin itself isn't supported anymore. Does anyone know if the plugin CAFEEFAC-00xx-0000-00xx-ABCDEFFEDCBC is also installed under extensions? I installed an old 1.6 jre but it was not there.
Attachment #8696366 -
Attachment is obsolete: true
Attachment #8696366 -
Flags: review?(bugzilla)
Attachment #8990516 -
Flags: review?(iann_bugzilla)
Attachment #8990516 -
Flags: approval-comm-esr60?
|
|
Assignee | |
Updated•6 years ago
|
status-seamonkey2.49esr:
--- → wontfix
status-seamonkey2.53:
--- → affected
Comment on attachment 8990516 [details] [diff] [review] 767918-javaconsole.patch LGTM r/a=me - I don't have java / SM on windows, so cannot test but looks right
Attachment #8990516 -
Flags: review?(iann_bugzilla)
Attachment #8990516 -
Flags: review+
Attachment #8990516 -
Flags: approval-comm-esr60?
Attachment #8990516 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/91578f646104 Remove Java Console extensions in the install directory's extensions directory on install and app update. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 8•6 years ago
|
||
https://hg.mozilla.org/releases/comm-esr60/rev/151cd03133dff4d64da2d081aefdafb88a216771
status-seamonkey2.57esr:
--- → fixed
status-seamonkey2.60:
--- → fixed
Target Milestone: --- → seamonkey2.60
You need to log in
before you can comment on or make changes to this bug.
Description
•