Closed Bug 767918 Opened 8 years ago Closed 2 years ago

Remove Java Console extensions in the install directory's extensions directory on install and app update.

Categories

(SeaMonkey :: Installer, defect)

x86
Windows 7
defect
Not set

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.60 fixed)

RESOLVED FIXED
seamonkey2.60
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed
seamonkey2.60 --- fixed

People

(Reporter: philip.chee, Assigned: frg)

Details

(Whiteboard: [good first bug][lang=NSIS][level=apprentice])

Attachments

(1 file, 1 obsolete file)

Firefox fixed this in Bug 597235 and Bug 654131. We should do the same. Our NSIS installer macros are sufficiently similar that this is likely to be a straight one to one port.
Can you confirm that you're still working on this bug?
Flags: needinfo?(installer)
That't the default assignee. It's now a GFB looking for a volunteer. I'll change the flags to take it of your radar.
Flags: needinfo?(installer)
Assignee: installer → nobody
Mentor: bugspam.Callek
Whiteboard: [good first bug][mentor=mscmurf/Callek][lang=NSIS][level=apprentice] → [good first bug][lang=NSIS][level=apprentice]
Mentor: bugzilla
Attached patch ahmed3.patch (obsolete) — Splinter Review
Attachment #8696366 - Flags: review?(bugzilla)
Comment on attachment 8696366 [details] [diff] [review]
ahmed3.patch

Review of attachment 8696366 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Medka,
thanks for the patch! Take a look at my comment below.

::: suite/installer/windows/nsis/shared.nsh
@@ +799,5 @@
> +!macro RemoveDeprecatedFiles
> +	; Remove talkback if it is present (remove after bug 386760 is fixed)
> +	${If} ${FileExists} "$INSTDIR\extensions\talkback@mozilla.org\"
> +		RmDir /r /REBOOTOK "$INSTDIR\extensions\talkback@mozilla.org\"
> +	${EndIf}

Can you remove this part? :) Bug 386760 has already been fixed quite a while ago, also(?) we don't ship Talkback for quite a few years now.
Mentor: bugspam.Callek
Assignee: nobody → frgrahl
Status: NEW → ASSIGNED
Mentor: bugzilla
Firefox removed most of the console extensions covered in the previous patch but added some newer in. I just used a generic loop to kill them all.

Starting with 2.50 the plugin itself isn't supported anymore. Does anyone know if the plugin CAFEEFAC-00xx-0000-00xx-ABCDEFFEDCBC is also installed under extensions? I installed an old 1.6 jre but it was not there.
Attachment #8696366 - Attachment is obsolete: true
Attachment #8696366 - Flags: review?(bugzilla)
Attachment #8990516 - Flags: review?(iann_bugzilla)
Attachment #8990516 - Flags: approval-comm-esr60?
Comment on attachment 8990516 [details] [diff] [review]
767918-javaconsole.patch

LGTM r/a=me - I don't have java / SM on windows, so cannot test but looks right
Attachment #8990516 - Flags: review?(iann_bugzilla)
Attachment #8990516 - Flags: review+
Attachment #8990516 - Flags: approval-comm-esr60?
Attachment #8990516 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/91578f646104
Remove Java Console extensions in the install directory's extensions directory on install and app update. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.