768525 - Update the twitter logo

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Andreas Nilsson (:andreasn)]

We fixed the logo in bug #737466, but Twitter recently changed the logo again.

Old logo: http://theinspirationroom.com/daily/design/2012/6/old-twitter-logo.jpg
New logo: http://theinspirationroom.com/daily/design/2012/6/new-twitter-logo.jpg

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: updated twitter logos

Just a graphic change, so I don't think this needs code-review.

Comment 2

[Patrick Cloke [:clokep]]

Thanks for doing those Andreas, even though there's no code changes it's helpful to keep me or Florian involved when making changes to chat/ as it's used in other applications besides Thunderbird. Anyway, rubber-stamp approval=me, assuming bwinton is good with the UI changes. :)

Also, was there any official announcement of this at all? Did we get the new images off of https://dev.twitter.com/docs/image-resources as we did for bug 737466?

Comment 3

[Andreas Nilsson (:andreasn)]

Patrick: Sure, I'll add the feedback? flag next time.

The blog post from Twitter about the logo change can be found here: http://blog.twitter.com/2012/06/taking-flight-twitterbird.html

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: screenshot to ease review

Before and after patch.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 637103 [details] [diff] [review]
updated twitter logos

Based just on the screenshot, ui-r=me.

Thanks,
Blake.

Comment 6

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/538abfda8a26

Andreas, Blake, do you think we need this for Thunderbird 15? If so, please request approval for aurora.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 637103 [details] [diff] [review]
updated twitter logos

[Triage Comment]
Yes, we should ship with the right logos :-)

Comment 8

[Florian J. [:FeuerFliege]]

All chat icons are square but these ones are not.

Comment 9

[aleth [:aleth]]

(In reply to Florian Janßen from comment #8)
> All chat icons are square but these ones are not.

This causes ugly distortions in situations where the icon is then stretched to a standard size via CSS.

Comment 10

[Florian J. [:FeuerFliege]]

Attachment: compare undistorted icons with the screenshot

The icons are displayed distorted because the are stretched to a square aspect ratio.

And please note, that prpl-twitter-48.png isn’t 48px in either direction. It is 44px × 35px.

Comment 11

[Andreas Nilsson (:andreasn)]

(In reply to Florian Janßen from comment #10)
> Created attachment 637846 [details]
> compare undistorted icons with the screenshot

> And please note, that prpl-twitter-48.png isn’t 48px in either direction. It
> is 44px × 35px.

Wow, you're right. I assumed the images I got off twitter had these dimensions (as it said so on their resource page). New patch coming up with this taken care of.

Comment 12

[Andreas Nilsson (:andreasn)]

Attachment: twitter icons with correct 16x16, 32x32 and 48x48 canvas

New icons. Sorry for missing this.

Comment 13

[Patrick Cloke [:clokep]]

Comment on attachment 638291 [details] [diff] [review]
twitter icons with correct 16x16, 32x32 and 48x48 canvas

Florian is currently on vacation...I tried this patch out and it looks good. I have an image I'll upload showing the difference between the non-square and square icons.

Thanks for fixing this promptly Andreas!

Comment 14

[Patrick Cloke [:clokep]]

Attachment: Non-square and square icons

The right side is with attachment 638291 [details] [diff] [review], the left side is with attachment 637103 [details] [diff] [review].

Comment 15

[Florian Quèze [:florian]]

https://hg.mozilla.org/comm-central/rev/a52505700b63
https://hg.mozilla.org/releases/comm-aurora/rev/302127df8750