Update the twitter logo

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: andreasn, Assigned: andreasn)

Tracking

Trunk
Thunderbird 16.0

Thunderbird Tracking Flags

(thunderbird15 fixed)

Details

Attachments

(5 attachments)

(Assignee)

Description

5 years ago
We fixed the logo in bug #737466, but Twitter recently changed the logo again.

Old logo: http://theinspirationroom.com/daily/design/2012/6/old-twitter-logo.jpg
New logo: http://theinspirationroom.com/daily/design/2012/6/new-twitter-logo.jpg
(Assignee)

Updated

5 years ago
Assignee: nobody → nisses.mail
(Assignee)

Comment 1

5 years ago
Created attachment 637103 [details] [diff] [review]
updated twitter logos

Just a graphic change, so I don't think this needs code-review.
Attachment #637103 - Flags: ui-review?(bwinton)
Thanks for doing those Andreas, even though there's no code changes it's helpful to keep me or Florian involved when making changes to chat/ as it's used in other applications besides Thunderbird. Anyway, rubber-stamp approval=me, assuming bwinton is good with the UI changes. :)

Also, was there any official announcement of this at all? Did we get the new images off of https://dev.twitter.com/docs/image-resources as we did for bug 737466?
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Patrick: Sure, I'll add the feedback? flag next time.

The blog post from Twitter about the logo change can be found here: http://blog.twitter.com/2012/06/taking-flight-twitterbird.html
(Assignee)

Comment 4

5 years ago
Created attachment 637126 [details]
screenshot to ease review

Before and after patch.
Comment on attachment 637103 [details] [diff] [review]
updated twitter logos

Based just on the screenshot, ui-r=me.

Thanks,
Blake.
Attachment #637103 - Flags: ui-review?(bwinton) → ui-review+
https://hg.mozilla.org/comm-central/rev/538abfda8a26

Andreas, Blake, do you think we need this for Thunderbird 15? If so, please request approval for aurora.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Comment on attachment 637103 [details] [diff] [review]
updated twitter logos

[Triage Comment]
Yes, we should ship with the right logos :-)
Attachment #637103 - Flags: approval-comm-aurora+
All chat icons are square but these ones are not.

Comment 9

5 years ago
(In reply to Florian Janßen from comment #8)
> All chat icons are square but these ones are not.

This causes ugly distortions in situations where the icon is then stretched to a standard size via CSS.
Created attachment 637846 [details]
compare undistorted icons with the screenshot

The icons are displayed distorted because the are stretched to a square aspect ratio.

And please note, that prpl-twitter-48.png isn’t 48px in either direction. It is 44px × 35px.
(Assignee)

Comment 11

5 years ago
(In reply to Florian Janßen from comment #10)
> Created attachment 637846 [details]
> compare undistorted icons with the screenshot

> And please note, that prpl-twitter-48.png isn’t 48px in either direction. It
> is 44px × 35px.

Wow, you're right. I assumed the images I got off twitter had these dimensions (as it said so on their resource page). New patch coming up with this taken care of.
(Assignee)

Comment 12

5 years ago
Created attachment 638291 [details] [diff] [review]
twitter icons with correct 16x16, 32x32 and 48x48 canvas

New icons. Sorry for missing this.
(Assignee)

Updated

5 years ago
Attachment #638291 - Flags: review?(florian)
(Assignee)

Updated

5 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 638291 [details] [diff] [review]
twitter icons with correct 16x16, 32x32 and 48x48 canvas

Florian is currently on vacation...I tried this patch out and it looks good. I have an image I'll upload showing the difference between the non-square and square icons.

Thanks for fixing this promptly Andreas!
Attachment #638291 - Flags: review?(florian) → review+
Created attachment 638655 [details]
Non-square and square icons

The right side is with attachment 638291 [details] [diff] [review], the left side is with attachment 637103 [details] [diff] [review].
https://hg.mozilla.org/comm-central/rev/a52505700b63
https://hg.mozilla.org/releases/comm-aurora/rev/302127df8750
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
status-thunderbird15: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.