769286 - Having more than one reviews on one app (All of them counting on rating.)

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect)

Description

[Alfredos-Panagiotis Damkalis [:fredy]]

Steps to reproduce:

1. Create a review and submit it.
2. On the same app submit again a new review.

What happens:

Your old review doesn't show up but exists and counts to rating (rating stars). The new review shows up and also counts to rating.

What should happen:

You should be able only to edit your already submitted review and not to be able to add a new one over the old.

Some more points on this bug:

1. You can add many ratings (1000 or 10000) which are going to affect the rating. For example two persons have rated an app one with 1 star and one with 5 stars, so we have 2 reviews with the average to be 3 stars.
Then the first one starts submitting more reviews with 1 star, for example 3 more. Now we have 2 reviews again but the average is 2 stars.

2. Deleting the new review, shows up the old one but the rating still counts. At the above example if I remove all the reviews of the first guy then we will have 1 review with 5 stars but the average will still be 2 stars.

3. The behavior at the second point is relative to the (https://bugzilla.mozilla.org/show_bug.cgi?id=764952)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Basta has a patch for this.

Comment 2

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/zamboni/commit/f1b25e2cb598ab46532021fd9395485a5f828991

Comment 3

[krupa raj[:krupa]]

Attachment: screenshot for reopening

Now, the review gets updated but not the rating. See screenshot.

Comment 4

[Matt Basta [:basta]]

Is the rating being cached or is it being improperly generated?

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj 82[:krupa] from comment #3)
> Created attachment 643199 [details]
> screenshot for reopening
> 
> Now, the review gets updated but not the rating. See screenshot.

I think you could get away with doing `addon_review_aggregates.delay(addon.addon_id, using='default')` upon save, and that should work.

https://github.com/mozilla/zamboni/blob/master/apps/reviews/tasks.py#L39

Comment 6

[Matt Basta [:basta]]

Updated:

https://github.com/mozilla/zamboni/commit/f898a3cdab9d504ce1618b015ab2a43b819aa0a4

Comment 7

[Cristian Boldan]

Verified as fixed in https://marketplace-dev.allizom.org/ on FF17 (Win 7)
Postfix screencast http://screencast.com/t/xQK5r2oJPd5S
Closing bug.