769390 - Remove $(shell) functions from Makefile.in files

Status: NEW

(Firefox Build System :: General, defect)

Description

[Gregory Szorc [:gps]]

$(shell) function calls aren't declarative. We should move them out of Makefile.in's and into rules.mk or somewhere else.

Comment 1

[Gregory Szorc [:gps]]

Semi-accurate lists:

https://mxr.mozilla.org/mozilla-central/search?string=%24%28shell&find=Makefile&findi=&filter=&hitlimit=&tree=mozilla-central

http://people.mozilla.org/~gszorc/bxr.html#shell

Comment 2

[(not currently active) Ted Mielczarek]

Looking at the link in comment 1, discounting third-party code and things like packager.mk, there are only a handful of things that actually use $(shell):
A part of mac bundle generation (bug 1223748):
https://dxr.mozilla.org/mozilla-central/rev/789e30ff2e3d6e1fcfce1a373c1e5635488d24da/browser/app/Makefile.in#79

searchplugins (bug 1407427):
https://dxr.mozilla.org/mozilla-central/rev/789e30ff2e3d6e1fcfce1a373c1e5635488d24da/browser/locales/Makefile.in#39
https://dxr.mozilla.org/mozilla-central/rev/789e30ff2e3d6e1fcfce1a373c1e5635488d24da/mobile/locales/Makefile.in#74

Some stuff for running adb to list connected devices for Android's `make install` (which could probably just become a mach command):
https://dxr.mozilla.org/mozilla-central/rev/789e30ff2e3d6e1fcfce1a373c1e5635488d24da/mobile/android/build.mk#23