769400 - Don't allow suspending the browser when downloading a file

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Brian R. Bondy [:bbondy]]

Downloads currently fail if you navigate away from the Metro browser.

Leverage either the background tasks API or the PowerCreateRequest, PowerSetRequest, and PowerClearRequest functions (as documented in the Power Availability Requests whitepaper) in order to allow downloads.

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1

Works nicely, once downloads are done it allows the process suspend to happen

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2.

if (!powerCreateRequest)
-   return FALSE;
+   return INVALID_HANDLE_VALUE;

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 693981 [details] [diff] [review]
Patch v1

Review of attachment 693981 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me!

::: widget/windows/winrt/MetroAppShell.cpp
@@ +210,5 @@
> +  static HMODULE kernel32 = GetModuleHandleW(L"kernel32.dll");
> +  static PowerCreateRequestPtr powerCreateRequest =
> +    (PowerCreateRequestPtr)GetProcAddress(kernel32, "PowerCreateRequest");
> +  if (!powerCreateRequest)
> +    return FALSE;

nit - NULL seems more appropriate here.

Comment 5

[Jim Mathies [:jimm]]

(In reply to Brian R. Bondy [:bbondy] from comment #3)
> Created attachment 693985 [details] [diff] [review]
> Patch v2.
> 
>   if (!powerCreateRequest)
> -   return FALSE;
> +   return INVALID_HANDLE_VALUE;

That's even better!

Comment 6

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/projects/elm/rev/4d6ab9b15ca7

Comment 7

[Brian R. Bondy [:bbondy]]

This will be migrated in the elm -> m-c migration. Resolving.