Reinstalling an app previously installed that preloads the appcache uninstalls the app

VERIFIED FIXED in Firefox 16

Status

Firefox Graveyard
Web Apps
VERIFIED FIXED
5 years ago
a year ago

People

(Reporter: jsmith, Assigned: Felipe)

Tracking

({dataloss})

unspecified
Firefox 16
All
Windows 7
dataloss

Details

(Whiteboard: [qa!])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Steps:

1. Install the app with appcache here - http://people.mozilla.com/~fdesre/openwebapps/test.html
2. Cut your internet connection
3. Reinstall the app with appcache here - http://people.mozilla.com/~fdesre/openwebapps/test.html

Expected:

Without a network connection, I'd expect app installation to fail.

Actual:

The app ends up being uninstalled from the user's machine.
(Reporter)

Comment 1

5 years ago
Note - this does not happen with an app that is installed from the same hosted origin that does not use appcache preloading.
(Reporter)

Comment 2

5 years ago
Change that - this happens also when an internet connection is present.
Summary: Reinstalling an app with no internet connection previously installed that preloads the appcache uninstalls the app → Reinstalling an app previously installed that preloads the appcache uninstalls the app
(Reporter)

Updated

5 years ago
blocking-kilimanjaro: --- → ?
(Reporter)

Comment 3

5 years ago
k9o nomination - We're heavily advocating app cache with web apps, especially with app cache preloading. Having incorrect reinstall behavior isn't a good thing.
When you say it uninstalls the app, does it remove it from the DOM registry, or just clears the offline cache?
(Reporter)

Comment 5

5 years ago
(In reply to Fabrice Desré [:fabrice] from comment #4)
> When you say it uninstalls the app, does it remove it from the DOM registry,
> or just clears the offline cache?

Uninstall app in this case implies:

- Uninstalling the app natively from the machine (e.g. equilvalent to removing through add or remove programs)

I'm currently digging into if this affects the DOMRegistry as well (e.g. removing it from there on reinstall).
(Reporter)

Updated

5 years ago
Priority: -- → P2
Jason, does it remove the profile directory?
(Reporter)

Comment 7

5 years ago
(In reply to Marco Castelluccio from comment #6)
> Jason, does it remove the profile directory?

Yup. It removes the entire application folder actually, including the profile folder. Marking for re-triage, as we now know this involves data loss, including the app profile.
Keywords: dataloss
Priority: P2 → --
In the installer, the only case in which we remove the profile directory is when there is an error during installation. Do you see anything in the error console?
(Reporter)

Comment 9

5 years ago
(In reply to Marco Castelluccio from comment #8)
> In the installer, the only case in which we remove the profile directory is
> when there is an error during installation. Do you see anything in the error
> console?

Indeed I do! Here's the error I got:

Timestamp: 7/3/2012 5:01:56 PM
Error: Error installing app: ReferenceError: Cr is not defined
Source File: resource:///modules/WebappsInstaller.jsm
Line: 36
(Assignee)

Comment 10

5 years ago
Created attachment 638928 [details] [diff] [review]
Patch

Thanks Jason and Marco for figuring out the problem
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Attachment #638928 - Flags: review?(mar.castelluccio)
(Assignee)

Comment 11

5 years ago
try build to show up here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/felipc@gmail.com-cbf852638a63

(the build also includes the fix for bug 769955)
(Reporter)

Comment 12

5 years ago
(In reply to Felipe Gomes (:felipe) from comment #11)
> try build to show up here:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/felipc@gmail.com-
> cbf852638a63
> 
> (the build also includes the fix for bug 769955)

Will this patch fix bug 770321 also? I know this error in the error console also reproduces on Mac as well.
Attachment #638928 - Flags: review?(mar.castelluccio) → review+
(In reply to Jason Smith [:jsmith] from comment #12)
> Will this patch fix bug 770321 also? I know this error in the error console
> also reproduces on Mac as well.

Most probably it will fix bug 770321. And it could fix also bug 753660.
(Assignee)

Comment 14

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/66a21d10cc58
Target Milestone: --- → Firefox 16
(Reporter)

Updated

5 years ago
Duplicate of this bug: 770321
(Reporter)

Updated

5 years ago
QA Contact: jsmith
Whiteboard: [qa+]
https://hg.mozilla.org/mozilla-central/rev/66a21d10cc58
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 17

5 years ago
Verified on Nightly.
Status: RESOLVED → VERIFIED
blocking-kilimanjaro: ? → ---
Whiteboard: [qa+] → [qa!]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.