769545 - Reinstalling an app previously installed that preloads the appcache uninstalls the app

Status: VERIFIED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Jason Smith [:jsmith]]

Steps:

1. Install the app with appcache here - http://people.mozilla.com/~fdesre/openwebapps/test.html
2. Cut your internet connection
3. Reinstall the app with appcache here - http://people.mozilla.com/~fdesre/openwebapps/test.html

Expected:

Without a network connection, I'd expect app installation to fail.

Actual:

The app ends up being uninstalled from the user's machine.

Comment 1

[Jason Smith [:jsmith]]

Note - this does not happen with an app that is installed from the same hosted origin that does not use appcache preloading.

Comment 2

[Jason Smith [:jsmith]]

Change that - this happens also when an internet connection is present.

Comment 3

[Jason Smith [:jsmith]]

k9o nomination - We're heavily advocating app cache with web apps, especially with app cache preloading. Having incorrect reinstall behavior isn't a good thing.

Comment 4

[[:fabrice] Fabrice Desré]

When you say it uninstalls the app, does it remove it from the DOM registry, or just clears the offline cache?

Comment 5

[Jason Smith [:jsmith]]

(In reply to Fabrice Desré [:fabrice] from comment #4)
> When you say it uninstalls the app, does it remove it from the DOM registry,
> or just clears the offline cache?

Uninstall app in this case implies:

- Uninstalling the app natively from the machine (e.g. equilvalent to removing through add or remove programs)

I'm currently digging into if this affects the DOMRegistry as well (e.g. removing it from there on reinstall).

Comment 6

[Marco Castelluccio [:marco]]

Jason, does it remove the profile directory?

Comment 7

[Jason Smith [:jsmith]]

(In reply to Marco Castelluccio from comment #6)
> Jason, does it remove the profile directory?

Yup. It removes the entire application folder actually, including the profile folder. Marking for re-triage, as we now know this involves data loss, including the app profile.

Comment 8

[Marco Castelluccio [:marco]]

In the installer, the only case in which we remove the profile directory is when there is an error during installation. Do you see anything in the error console?

Comment 9

[Jason Smith [:jsmith]]

(In reply to Marco Castelluccio from comment #8)
> In the installer, the only case in which we remove the profile directory is
> when there is an error during installation. Do you see anything in the error
> console?

Indeed I do! Here's the error I got:

Timestamp: 7/3/2012 5:01:56 PM
Error: Error installing app: ReferenceError: Cr is not defined
Source File: resource:///modules/WebappsInstaller.jsm
Line: 36

Comment 10

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Thanks Jason and Marco for figuring out the problem

Comment 11

[:Felipe Gomes (needinfo for replies!)]

try build to show up here: http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-cbf852638a63

(the build also includes the fix for bug 769955)

Comment 12

[Jason Smith [:jsmith]]

(In reply to Felipe Gomes (:felipe) from comment #11)
> try build to show up here:
> http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-
> cbf852638a63
> 
> (the build also includes the fix for bug 769955)

Will this patch fix bug 770321 also? I know this error in the error console also reproduces on Mac as well.

Comment 13

[Marco Castelluccio [:marco]]

(In reply to Jason Smith [:jsmith] from comment #12)
> Will this patch fix bug 770321 also? I know this error in the error console
> also reproduces on Mac as well.

Most probably it will fix bug 770321. And it could fix also bug 753660.

Comment 14

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66a21d10cc58

Comment 16

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/66a21d10cc58

Comment 17

[Jason Smith [:jsmith]]

Verified on Nightly.