Video control on html5 video repaint too often on Youtube player

RESOLVED FIXED in mozilla17

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kolubinowicki, Assigned: mattwoodrow)

Tracking

({regression})

Trunk
mozilla17
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 638175 [details]
Repainting issue on Youtube html5 player

Please check attachment for more info:

Video control on html5 video repaint to often on Youtube player:

Step to reproduce:

Enable Html5 video on page:
http://www.youtube.com/html5
Open example video:
http://www.youtube.com/watch?v=mzPxo7Y6JyA
look at the video controls button:

Regression window:

OK:
http://hg.mozilla.org/mozilla-central/rev/f08d285b63b0

BAD:
http://hg.mozilla.org/mozilla-central/rev/d9d61d199b11
(Reporter)

Updated

5 years ago
Blocks: 539356
Keywords: regression

Updated

5 years ago
Attachment #638175 - Attachment mime type: application/octet-stream → video/webm
Confirmed - setting to New
Status: UNCONFIRMED → NEW
Ever confirmed: true
Smells like a DLBI regression.
Summary: Video control on html5 video repaint to often on Youtube player → Video control on html5 video repaint too often on Youtube player
This happens on all platforms.
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 4

5 years ago
Initial testing of this shows this for the invalidation log:

http://pastebin.mozilla.org/1688404


This means that the elapsed time text frame was deleted when we painted, and we didn't have the new text frame created (or at least, it didn't create an nsDisplayText display item).

Unsure how this could have changed under DLBI, unless we just weren't invalidating (or painting) previously until the text frame is created.
(Assignee)

Comment 5

5 years ago
Created attachment 638584 [details] [diff] [review]
Call WillPaint/DidPaint in the right place

Ok, confirmed this to be the latter.

The original text frame is removed, and we invalidate part of the layer. Then we paint on a refresh driver tick, draw with missing text and send an invalidate event to the widget. Then the new text frame is created before the widget paint event fires.

With the old code, we didn't paint until the widget event, so we would have drawn the text.

I think we need to move the code for WillPaint/DidPaint into being called around the refresh driver paint, instead of being called by the OS surrounding the widget paint (composite).

This patch fixes the flicker for me.
Attachment #638584 - Flags: review?(roc)
(Assignee)

Updated

5 years ago
Duplicate of this bug: 770083
Attachment #638584 - Flags: review?(roc) → review+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/674cde7d007a
https://hg.mozilla.org/mozilla-central/rev/674cde7d007a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Backed out as part of DLBI:

https://hg.mozilla.org/mozilla-central/rev/674cde7d007a
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ad204385022
Status: REOPENED → NEW
Target Milestone: mozilla16 → ---
https://hg.mozilla.org/mozilla-central/rev/0ad204385022
Status: NEW → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Depends on: 782980

Updated

5 years ago
Depends on: 783791

Updated

5 years ago
Depends on: 797167

Updated

5 years ago
Assignee: nobody → matt.woodrow
You need to log in before you can comment on or make changes to this bug.