770058 - Switching main window between active and inactive doesn't update the title bar active state if disabled MenuBar in Window7Classic Style

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/d9d61d199b11
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 ID:20120701030537

This maybe happens in Windows7 Classic style only.

Steps to Reproduce:
1. Make sure "Windows7 Classic Style" is selected
2. Start Firefox with clean profile (MenuBar is disabled)
3-1. Switch to another application (Alt+Tab)
    -- Observe TitleBar Color
3-2. Switch to Nightly again (Alt+Tab)
    -- Observe TitleBar Color

Actual Results:
 The TitleBar color does not change

Expected Results:
 The TitleBar should change .


Mouse over Window Control Buttons(Minimum/Maximize/Close) helps.

Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0d9f7fb55226
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 ID:20120629192951
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cd6d52bdf2d8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 ID:20120629200651
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0d9f7fb55226&tochange=cd6d52bdf2d8

Suspected: Bug 539356

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's probably this change to PresShell::DocumentStatesChanged:

-  if (aStateMask.HasState(NS_DOCUMENT_STATE_WINDOW_INACTIVE)) {
-    nsIFrame* root = mFrameConstructor->GetRootFrame();
-    if (root) {
-      root->InvalidateFrameSubtree();
-    }
-  }
+  ScheduleViewManagerFlush();

We still need to do that InvalidateFrameSubtree to invalidate frames that have native-theme backgrounds that have changed.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: part 1: remove unnecessary parameters

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: Part 2: invalidate themed frames on document activity change

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: part 2 v2

Only call GetChildLists, not GetCrossDocChildLists, because this gets called on every document anyway.

Comment 5

[Phil Ringnalda (:philor)]

FWIW (not much), those don't seem to fix the not-yet-marked-dupe bug 770081 on OS X.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hmm, maybe that uses nsILookAndFeel colors or something?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: do it the hard way

I sure hope this fixes it. I don't have any bigger sledgehammers.

Comment 8

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/071d6332729b
https://hg.mozilla.org/integration/mozilla-inbound/rev/6266a1336e2d

Comment 9

[Phil Ringnalda (:philor)]

I'm not sure which All this one is, but it's All minus OS X, which is bug 770056.

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/071d6332729b
https://hg.mozilla.org/mozilla-central/rev/6266a1336e2d

Comment 11

[(no longer active)]

Backed out as part of DLBI:

https://hg.mozilla.org/mozilla-central/rev/6266a1336e2d
https://hg.mozilla.org/mozilla-central/rev/071d6332729b

Comment 12

[Ed Morley [:emorley]]

Backed out (see bug 539356 comment 337):
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3f86e3a3240

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5f4c8635e87e
https://hg.mozilla.org/mozilla-central/rev/9366a70acb1d