Switching main window between active and inactive doesn't update the title bar active state if disabled MenuBar in Window7Classic Style

RESOLVED FIXED in mozilla18

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Alice0775 White, Assigned: roc)

Tracking

({regression})

16 Branch
mozilla18
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/d9d61d199b11
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 ID:20120701030537

This maybe happens in Windows7 Classic style only.

Steps to Reproduce:
1. Make sure "Windows7 Classic Style" is selected
2. Start Firefox with clean profile (MenuBar is disabled)
3-1. Switch to another application (Alt+Tab)
    -- Observe TitleBar Color
3-2. Switch to Nightly again (Alt+Tab)
    -- Observe TitleBar Color

Actual Results:
 The TitleBar color does not change

Expected Results:
 The TitleBar should change .


Mouse over Window Control Buttons(Minimum/Maximize/Close) helps.

Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/0d9f7fb55226
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 ID:20120629192951
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/cd6d52bdf2d8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 ID:20120629200651
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0d9f7fb55226&tochange=cd6d52bdf2d8

Suspected: Bug 539356
It's probably this change to PresShell::DocumentStatesChanged:

-  if (aStateMask.HasState(NS_DOCUMENT_STATE_WINDOW_INACTIVE)) {
-    nsIFrame* root = mFrameConstructor->GetRootFrame();
-    if (root) {
-      root->InvalidateFrameSubtree();
-    }
-  }
+  ScheduleViewManagerFlush();

We still need to do that InvalidateFrameSubtree to invalidate frames that have native-theme backgrounds that have changed.
Created attachment 638256 [details] [diff] [review]
part 1: remove unnecessary parameters
Assignee: nobody → roc
Attachment #638256 - Flags: review?(matt.woodrow)
Created attachment 638257 [details] [diff] [review]
Part 2: invalidate themed frames on document activity change
Attachment #638257 - Flags: review?(matt.woodrow)
Created attachment 638258 [details] [diff] [review]
part 2 v2

Only call GetChildLists, not GetCrossDocChildLists, because this gets called on every document anyway.
Attachment #638257 - Attachment is obsolete: true
Attachment #638257 - Flags: review?(matt.woodrow)
Attachment #638258 - Flags: review?(matt.woodrow)
FWIW (not much), those don't seem to fix the not-yet-marked-dupe bug 770081 on OS X.
Hmm, maybe that uses nsILookAndFeel colors or something?
Created attachment 638268 [details] [diff] [review]
do it the hard way

I sure hope this fixes it. I don't have any bigger sledgehammers.
Attachment #638258 - Attachment is obsolete: true
Attachment #638258 - Flags: review?(matt.woodrow)
Attachment #638268 - Flags: review?(matt.woodrow)
Attachment #638268 - Flags: review?(matt.woodrow) → review+
Attachment #638256 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/071d6332729b
https://hg.mozilla.org/integration/mozilla-inbound/rev/6266a1336e2d
OS: Windows 7 → All
Hardware: x86 → All
I'm not sure which All this one is, but it's All minus OS X, which is bug 770056.
https://hg.mozilla.org/mozilla-central/rev/071d6332729b
https://hg.mozilla.org/mozilla-central/rev/6266a1336e2d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
(Reporter)

Updated

5 years ago
Depends on: 770575
(Reporter)

Updated

5 years ago
Depends on: 770642
Backed out as part of DLBI:

https://hg.mozilla.org/mozilla-central/rev/6266a1336e2d
https://hg.mozilla.org/mozilla-central/rev/071d6332729b
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Backed out (see bug 539356 comment 337):
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3f86e3a3240
https://hg.mozilla.org/mozilla-central/rev/5f4c8635e87e
https://hg.mozilla.org/mozilla-central/rev/9366a70acb1d
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla16 → mozilla18
You need to log in before you can comment on or make changes to this bug.