The default bug view has changed. See this FAQ.

Rename "Send Image...", "Send Video...", and "Send Audio..." to "Email Image...", etc

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Menus
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
Firefox 16
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I talked with shorlander and we think that we should keep the context menuitems for sending media but rename them to be simpler and more obvious as to their outcomes.

In the case of these items, the user doesn't get to choose *how* the message is sent, so the word "As" in "Send Image As..." doesn't really apply here.

We can make this more intuitive by changing these to:
"Email Image...", "Email Video...", and "Email Audio..."

The behavior of these menuitems will remain the same.
Summary: Rename "Send Image As...", "Send Video As...", and "Send Audio As..." to "Email Image...", etc → Rename "Send Image...", "Send Video...", and "Send Audio..." to "Email Image...", etc
Depends on: 239307
Created attachment 638614 [details] [diff] [review]
Patch

This patch is dependent on the patch for bug 239307, that's why I didn't update the sendPageCmd in browser-context.inc since the send page command is removed from the context menu in the patch for bug 239307.

This patch renames Send Image, Send Video, Send Audio, and Send Page to Email *.

This MXR search shows that these are the only "Send *" strings that will lead to a user sending an email <https://mxr.mozilla.org/mozilla-central/search?string=send+&find=\.dtd&findi=\.x.l&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central>.
Attachment #638614 - Flags: ui-review?(shorlander)
Attachment #638614 - Flags: review?(fryn)
Comment on attachment 638614 [details] [diff] [review]
Patch

>Bug 770419 - Rename 'Send Image...' et al to 'Email Image...'.

This bug has a more complete summary, please use that (at least).

>-<!ENTITY sendPageCmd.label            "Send Link…">
>-<!ENTITY sendPageCmd.accesskey        "e">
>+<!ENTITY sendPageCmd2.label           "Email Link…">
>+<!ENTITY sendPageCmd2.accesskey       "E">

emailFooCmd rather than sendFooCmd2.

The original spelling of the verb is "e-mail". Not sure which is better or used more commonly...
Attachment #638614 - Flags: review-

Comment 3

5 years ago
Comment on attachment 638614 [details] [diff] [review]
Patch

(In reply to Dão Gottwald [:dao] from comment #2)
> The original spelling of the verb is "e-mail". Not sure which is better or
> used more commonly...

"email" is used more commonly (see Google results, etc.) and is also what we use (including in 'Copy Email Address'):
https://mxr.mozilla.org/mozilla-central/search?string=email&find=\.dtd%24&findi=\.dtd%24&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
although pippki is the odd exception:
https://mxr.mozilla.org/mozilla-central/search?string=e-mail&find=\.dtd%24&findi=\.dtd%24&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Attachment #638614 - Flags: review?(fryn)
Created attachment 638940 [details] [diff] [review]
Patch v2

I renamed the entities to be email*Cmd, but I didn't update the commands or other related items because I don't think the tradeoff of hg history churn is worth it.

test_contextmenu.html passes green locally.

On the question of email vs e-mail, the brand toolkit [0] says to refer to the AP Styleguide [1] which recommends 'email'.

[0] http://www.mozilla.org/en-US/firefox/brand/copy/rules/
[1] http://mashable.com/2011/03/18/ap-stylebook-email/
Attachment #638614 - Attachment is obsolete: true
Attachment #638614 - Flags: ui-review?(shorlander)
Attachment #638940 - Flags: review?(fryn)
Attachment #638940 - Flags: review?(dao)

Comment 5

5 years ago
Comment on attachment 638940 [details] [diff] [review]
Patch v2

I think Dão was asking you to change the commit message:

(In reply to Dão Gottwald [:dao] from comment #2)
> Comment on attachment 638614 [details] [diff] [review]
> Patch
> 
> >Bug 770419 - Rename 'Send Image...' et al to 'Email Image...'.
> 
> This bug has a more complete summary, please use that (at least).
Attachment #638940 - Flags: review?(fryn) → feedback+

Comment 6

5 years ago
Comment on attachment 638940 [details] [diff] [review]
Patch v2

Never mind. I misunderstood.
Attachment #638940 - Flags: review?(dao)
Attachment #638940 - Flags: review+
Attachment #638940 - Flags: feedback+
Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ed02bff1f4d
Flags: in-testsuite+
Target Milestone: --- → Firefox 16
https://hg.mozilla.org/mozilla-central/rev/2ed02bff1f4d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Do we want a followup bug to consider entirely removing these?
(In reply to Justin Dolske [:Dolske] from comment #9)
> Do we want a followup bug to consider entirely removing these?

I'm not sure, but I'm leaning towards not removing these (hence the filing of this bug).

Our current data shows that ~3% of context menu clicks are for send-image. As mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=252277#c10, the URLs for these items are generally hidden vs. the generally visibile page URLs. This distinction makes the benefit of keeping these menuitems greater than the 'Send Page...' one.
Depends on: 776293
You need to log in before you can comment on or make changes to this bug.