770453 - [b2g] semi-transparent scroll bars should not occupy content-flow space

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #711986 +++

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

See https://github.com/mozilla-b2g/gaia/pull/2136 for tests

The scroll bar currently occupies 8px of the spaces, causing the 10th small boxes to flow to the second row and a 12px blank beside the scroll bar.

I tried to hack the CSS but so far without much success. Will keep trying.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

It is likely that bug 636564 will resolve that.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Vivien Nicolas (:vingtetun) from comment #2)
> It is likely that bug 636564 will resolve that.

That is really unfortunate ...

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Let's add Roc to this bug. He can have good suggestions for us.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I believe cjones and Doug have some ideas about rendering scroll indicators in the compositor. Is that the best plan for dealing with this bug?

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Yes, but async sub-frame scrolling is looking risky for b2g v1, so we'll likely need to ship with the current sync fallback hack.  This bug is less important for the scrollable subframes though, I guess.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

If we want to proceed with fixing synchronously drawn scrollbar indicators in this bug, I think the best way forward would be to revive the subset of patches in bug 636564 that are needed here.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Part 1, v1: handle scrollbar margins

Roc, this patch came from bug 636564 and you have already r+ it. It seems to resolve the issue.

Comment 9

[Kan-Ru Chen [:kanru] (UTC+9)]

Vivien do you want to land this? The scrollbar is pretty annoying ;-)

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ed259005de2

Comment 11

[Ed Morley [:emorley]]

Backed out for Android XUL R3 failures in scrollbars-0{1,2}.svg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13935054&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4b106f2136c

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: mobile/xul patch

mobile/xul/themes/content/content.css change the size of scrollbars for SVG content making a reftest to fail when the margin is taken into account for calculating the size of the scrollable area. This patch should not change any fennec behavior and ensure that we don't fail the reftest.

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5e444664a6c
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99a135fc810

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b5e444664a6c
https://hg.mozilla.org/mozilla-central/rev/a99a135fc810