Last Comment Bug 770453 - [b2g] semi-transparent scroll bars should not occupy content-flow space
: [b2g] semi-transparent scroll bars should not occupy content-flow space
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
:
Mentors:
: 776232 (view as bug list)
Depends on: 636564 691609 711986 780373 781086
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-03 02:42 PDT by Tim Guan-tin Chien [:timdream] (please needinfo; on leave in July)
Modified: 2012-08-07 22:01 PDT (History)
9 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
+


Attachments
Part 1, v1: handle scrollbar margins (2.02 KB, patch)
2012-07-24 10:13 PDT, Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
roc: review+
Details | Diff | Review
mobile/xul patch (2.43 KB, patch)
2012-08-01 12:41 PDT, Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
mark.finkle: review+
Details | Diff | Review

Description Tim Guan-tin Chien [:timdream] (please needinfo; on leave in July) 2012-07-03 02:42:03 PDT
+++ This bug was initially created as a clone of Bug #711986 +++
Comment 1 Tim Guan-tin Chien [:timdream] (please needinfo; on leave in July) 2012-07-03 02:44:46 PDT
See https://github.com/mozilla-b2g/gaia/pull/2136 for tests

The scroll bar currently occupies 8px of the spaces, causing the 10th small boxes to flow to the second row and a 12px blank beside the scroll bar.

I tried to hack the CSS but so far without much success. Will keep trying.
Comment 2 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-07-03 03:07:09 PDT
It is likely that bug 636564 will resolve that.
Comment 3 Tim Guan-tin Chien [:timdream] (please needinfo; on leave in July) 2012-07-03 03:26:24 PDT
(In reply to Vivien Nicolas (:vingtetun) from comment #2)
> It is likely that bug 636564 will resolve that.

That is really unfortunate ...
Comment 4 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-07-23 09:46:05 PDT
Let's add Roc to this bug. He can have good suggestions for us.
Comment 5 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-07-23 16:59:16 PDT
I believe cjones and Doug have some ideas about rendering scroll indicators in the compositor. Is that the best plan for dealing with this bug?
Comment 6 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-23 17:01:56 PDT
Yes, but async sub-frame scrolling is looking risky for b2g v1, so we'll likely need to ship with the current sync fallback hack.  This bug is less important for the scrollable subframes though, I guess.
Comment 7 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2012-07-23 17:35:42 PDT
If we want to proceed with fixing synchronously drawn scrollbar indicators in this bug, I think the best way forward would be to revive the subset of patches in bug 636564 that are needed here.
Comment 8 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-07-24 10:13:12 PDT
Created attachment 645358 [details] [diff] [review]
Part 1, v1: handle scrollbar margins

Roc, this patch came from bug 636564 and you have already r+ it. It seems to resolve the issue.
Comment 9 Kan-Ru Chen [:kanru] (UTC+8) 2012-07-27 18:24:17 PDT
Vivien do you want to land this? The scrollbar is pretty annoying ;-)
Comment 10 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-07-28 00:43:30 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ed259005de2
Comment 11 Ed Morley [:emorley] 2012-07-28 05:32:52 PDT
Backed out for Android XUL R3 failures in scrollbars-0{1,2}.svg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=13935054&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4b106f2136c
Comment 12 Dietrich Ayala (:dietrich) 2012-07-31 13:39:27 PDT
*** Bug 776232 has been marked as a duplicate of this bug. ***
Comment 13 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-08-01 12:41:29 PDT
Created attachment 648044 [details] [diff] [review]
mobile/xul patch

mobile/xul/themes/content/content.css change the size of scrollbars for SVG content making a reftest to fail when the margin is taken into account for calculating the size of the scrollable area. This patch should not change any fennec behavior and ensure that we don't fail the reftest.
Comment 14 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-08-03 03:37:14 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5e444664a6c
https://hg.mozilla.org/integration/mozilla-inbound/rev/a99a135fc810

Note You need to log in before you can comment on or make changes to this bug.