770735 - Replace Share option with Quick Share options in {remote tabs} home panel context-menu

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently one has to open the tab, and select 'Share' and then select 'Firefox Sync'. [3 steps].


Perhaps we can detect a long-tap on a tab in the 'Sync Tabs' pane and have the option to select a 'Send to device' action that just uses the Firefox Sync intent immediately.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

ux, renom if you want to do anything here

Comment 2

[Nick Alexander :nalexander [he/him]]

This is a good idea, but with the state of Send Tab to Device (Bug 941744) currently in flux, it's not actionable.

Comment 3

[Aaron Train [:aaronmt]]

Huh? I don't see the dependancy.

I don't see this any different than using the share in our browser menu. You can share to Email, etc.

Comment 4

[Aaron Train [:aaronmt]]

Oh nm, misread my own bug. Sharing remote tabs in entirety  is another bug.

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Aaron Train [:aaronmt] from comment #3)
> Huh? I don't see the dependancy.
> 
> I don't see this any different than using the share in our browser menu. You
> can share to Email, etc.

Oooh, I interpreted this ticket differently.  Adding a 'Share...' menu item is actionable.  Updating title.

Comment 6

[Nick Alexander :nalexander [he/him]]

Bonus points for feeding this through the quick-share mechanism.  Would be awesome to have the quick share items in the context-menu, and to update the quick-share choices with the data here.  No idea how hard that is :)

Comment 7

[Aaron Train [:aaronmt]]

Bug 770735

Comment 8

[Aaron Train [:aaronmt]]

Whoops, meant to mention 785199, give remote tabs a context menu

Comment 9

[Ian Barlow (:ibarlow)]

I wonder if the long press interaction in the synced tab tray would be better served by an action bar mode instead of a context menu. 

This would allow us to support not only sharing of individual items, but also provide users with a way to select multiple tabs at once so they can act on them as a group -- could be opening them all at once, sharing a group of links, etc.

Comment 10

[Nick Alexander :nalexander [he/him]]

Post Bug 785199, this is now implemented.  I'm going to keep it open to discuss replacing Share with the Quick Share items in this (really, all home panel) menus.

Comment 11

[Nick Alexander :nalexander [he/him]]

Attachment: Share.Menu.01.png

Comment 12

[Nick Alexander :nalexander [he/him]]

Attachment: Share.Menu.02.png

Comment 13

[Nick Alexander :nalexander [he/him]]

wesj: did you ever consider this?  Can you comment on how hard this might be, and if there are any problems I should be aware of?

Comment 14

[Wesley Johnston (:wesj)]

I think this will be tough. When these menus are inflated, for instance here:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/HomeFragment.java#107

we inflate them from native resources. At this point we need some way to inject a custom view. AFAIK, The menu's don't give us a way to inject any custom views:
http://developer.android.com/reference/android/view/Menu.html

and MenuItem's don't allow them either.  Things like setActionProvider on the MenuItem (should?) only affect the actionview shown on the actionbar if there's room (since these are native context menus, and since we have no actionbar, they won't appear there ever):
http://developer.android.com/reference/android/view/MenuItem.html#setActionProvider%28android.view.ActionProvider%29

I think we'll have to switch from using these NativeMenu's to generating menus entirely of our own to do this (but I haven't exhaustively tried).

If we can't, there are probably two options:

1.) attempt to use Prompt.java since it includes some support for these types of menuitems already (it will likely need some massaging to make that work from Java code). 

2.) Alternatively, you could probably use our GeckoMenu code as well (since it supports inflating resources from Android's XML, it might work better here actually).

I've wanted to bring the two of those together at some point, but its a lot of refactoring (i.e. killing org.mozilla.gecko.prompt.PromptListItem and replacing it with GeckoMenuItem is bug 943568), and its not necessarily required for this.

Comment 15

[Richard Newman [:rnewman]]

Can we redefine the problem in a way that presents a solution? 

For example, how about adding a row beneath or above the selected or long pressed row, putting share items there? Kinda like an action bar, not a context menu. Ian touched on this in Comment 9.

Maybe tapping a row turns it into a fat row, with share icons and a menu button?

Comment 16

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.