Closed Bug 773732 Opened 13 years ago Closed 13 years ago

After reloading a page, the selected script and line should remain the same

Categories

(DevTools :: Debugger, defect, P3)

12 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 17

People

(Reporter: vporof, Assigned: vporof)

References

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(3 files)

Open debugger, switch to another script and reload the page. Most likely, the currently visible script is switched to the first one in the list. This annoyed me today and I think we should fix it.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #648284 - Flags: review?(rcampbell)
Priority: -- → P3
Comment on attachment 648284 [details] [diff] [review] v1 nice little usability win there. With a test!
Attachment #648284 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Depends on: 780198
Depends on: 782179
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [fixed-in-fx-team]
Target Milestone: Firefox 17 → ---
The backout had failures, so I have reverted it (effectively relanding this bug) and instead disabled the test (rather than trying to figure out how to backout cleanly). Sorry for the extra noise. Relanding: https://hg.mozilla.org/mozilla-central/rev/618652af63c9 Disable test: https://hg.mozilla.org/mozilla-central/rev/ccf120bf4638
Whiteboard: [test disabled][leave open]
Target Milestone: --- → Firefox 17
Spotted a regression from 783393. Need to fix this.
Attached patch v2Splinter Review
This should fix it. Amongst other things, executeSoon is evil.
Attachment #655311 - Flags: review?(rcampbell)
Comment on attachment 655311 [details] [diff] [review] v2 Review of attachment 655311 [details] [diff] [review]: ----------------------------------------------------------------- yuup.
Attachment #655311 - Flags: review?(rcampbell) → review+
Whiteboard: [test disabled][leave open] → [test disabled][fixed-in-fx-team]
Whiteboard: [test disabled][fixed-in-fx-team] → [fixed-in-fx-team]
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: