After reloading a page, the selected script and line should remain the same

RESOLVED FIXED in Firefox 17

Status

defect
P3
normal
RESOLVED FIXED
7 years ago
Last year

People

(Reporter: vporof, Assigned: vporof)

Tracking

12 Branch
Firefox 17
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(3 attachments)

Assignee

Description

7 years ago
Open debugger, switch to another script and reload the page. Most likely, the currently visible script is switched to the first one in the list. This annoyed me today and I think we should fix it.
Assignee

Comment 1

7 years ago
Posted patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #648284 - Flags: review?(rcampbell)
Assignee

Updated

7 years ago
Priority: -- → P3
Comment on attachment 648284 [details] [diff] [review]
v1

nice little usability win there. With a test!
Attachment #648284 - Flags: review?(rcampbell) → review+
Assignee

Updated

7 years ago
Whiteboard: [land-in-fx-team]
Assignee

Comment 4

7 years ago
https://hg.mozilla.org/integration/fx-team/rev/64bc6b0e9127
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/64bc6b0e9127
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Depends on: 780198
Depends on: 782179
Backed out for causing the frequent bug 780198 and bug 782179:
https://hg.mozilla.org/mozilla-central/rev/3b46b03dff5c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [fixed-in-fx-team]
Target Milestone: Firefox 17 → ---
The backout had failures, so I have reverted it (effectively relanding this bug) and instead disabled the test (rather than trying to figure out how to backout cleanly). Sorry for the extra noise.

Relanding:
https://hg.mozilla.org/mozilla-central/rev/618652af63c9

Disable test:
https://hg.mozilla.org/mozilla-central/rev/ccf120bf4638
Whiteboard: [test disabled][leave open]
Target Milestone: --- → Firefox 17
Assignee

Comment 8

7 years ago
Spotted a regression from 783393. Need to fix this.
Assignee

Comment 9

7 years ago
Posted patch v2Splinter Review
This should fix it.
Amongst other things, executeSoon is evil.
Attachment #655311 - Flags: review?(rcampbell)
Comment on attachment 655311 [details] [diff] [review]
v2

Review of attachment 655311 [details] [diff] [review]:
-----------------------------------------------------------------

yuup.
Attachment #655311 - Flags: review?(rcampbell) → review+

Updated

7 years ago
Whiteboard: [test disabled][leave open] → [test disabled][fixed-in-fx-team]
Assignee

Updated

7 years ago
Whiteboard: [test disabled][fixed-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/e11af99c5566
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.