Closed Bug 780198 Opened 7 years ago Closed 6 years ago

Intermittent browser_dbg_reload-same-script.js | Test timed out, followed by browser_dbg_script-switching.js | The preferred script url wasn't set correctly | uncaught exception - ReferenceError: finish is not defined at debugger/test/head.js:113

Categories

(DevTools :: Debugger, defect, P2)

All
macOS
defect

Tracking

(firefox25 wontfix, firefox26 fixed, firefox-esr24 wontfix)

RESOLVED FIXED
Firefox 18
Tracking Status
firefox25 --- wontfix
firefox26 --- fixed
firefox-esr24 --- wontfix

People

(Reporter: ttaubert, Assigned: past)

References

Details

(Keywords: intermittent-failure, Whiteboard: [fixed-in-fx-team])

Attachments

(1 file, 1 obsolete file)

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_reload-same-script.js | Test timed out
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_script-switching.js | an unexpected uncaught JS exception reported through window.onerror - ReferenceError: executeSoon is not defined at chrome://mochitests/content/browser/browser/devtools/debugger/test/browser_dbg_reload-same-script.js:45

https://tbpl.mozilla.org/php/getParsedLog.php?id=14101376&tree=Fx-Team
Blocks: 773732
New test landed in last few weeks by bug 773732.
I've backed out the bug that landed this test (https://bugzilla.mozilla.org/show_bug.cgi?id=773732#c6) so this should stop now :-)
Attached patch v1 (obsolete) — Splinter Review
I may have an idea why we're timing out.
This would help.
Attachment #655365 - Flags: review?(rcampbell)
Attached patch v2Splinter Review
Yeah, no need to log anymore, it's pretty obvious. Always happening after the 8th step in the test, when trying to switch to a possibly not-fetched-yet script.
Assignee: nobody → vporof
Attachment #655365 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #655365 - Flags: review?(rcampbell)
Attachment #655408 - Flags: review?(rcampbell)
(In reply to Victor Porof [:vp] from comment #84)
> Created attachment 655408 [details] [diff] [review]
> v2
> 
> Yeah, no need to log anymore, it's pretty obvious. Always happening after
> the 8th step in the test, when trying to switch to a possibly
> not-fetched-yet script.

224 runs, didn't get this orange anymore.
https://tbpl.mozilla.org/?tree=Try&rev=77aeba47785a
Comment on attachment 655408 [details] [diff] [review]
v2

Review of attachment 655408 [details] [diff] [review]:
-----------------------------------------------------------------

I was curious, so I snatched it from Rob. Hopefully he won't mind!
Attachment #655408 - Flags: review?(rcampbell) → review+
Whiteboard: [orange] → [orange][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/f77ed5fe36f0
Whiteboard: [orange][land-in-fx-team] → [orange][fixed-in-fx-team]
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/f77ed5fe36f0
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
No more fails on fx-team and m-c for a week now.
I think we should get this fix in more places. At least Aurora, maybe?
(In reply to Victor Porof [:vp] from comment #152)
> No more fails on fx-team and m-c for a week now.
> I think we should get this fix in more places. At least Aurora, maybe?

Indeed. Do you want to take care of it?
Target Milestone: --- → Firefox 18
Comment on attachment 655408 [details] [diff] [review]
v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): A particular test times out when reloading a page with the debugger open.
User impact if declined: None, this touches test-only code for a developer tool feature not exposed to the general user.
Testing completed (on m-c, etc.): m-c and fx-team
Risk to taking this patch (and alternatives if risky): Negative
String or UUID changes made by this patch: None
Attachment #655408 - Flags: approval-mozilla-aurora?
Attachment #655408 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to TinderboxPushlog Robot from comment #163)
> edmorley

browser_dbg_reload-same-script.js Doesn't fail anywhere in that log...
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [fixed-in-fx-team]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is intriguing:

Console message: [JavaScript Error: "Error loading test-script-switching-01.js
noSuchActor" {file: "chrome://browser/content/debugger-controller.js" line: 1203}]
Let's talk about this next triage.
Assignee: vporof → nobody
Priority: P3 → --
Assignee: nobody → past
Priority: -- → P2
Summary: Intermittent browser_dbg_reload-same-script.js | Test timed out, followed by browser_dbg_script-switching.js | an unexpected uncaught JS exception reported through window.onerror → Intermittent browser_dbg_reload-same-script.js | Test timed out, followed by browser_dbg_script-switching.js | uncaught exception - ReferenceError: finish is not defined at debugger/test/head.js:113
Summary: Intermittent browser_dbg_reload-same-script.js | Test timed out, followed by browser_dbg_script-switching.js | uncaught exception - ReferenceError: finish is not defined at debugger/test/head.js:113 → Intermittent browser_dbg_reload-same-script.js | Test timed out, followed by browser_dbg_script-switching.js | The preferred script url wasn't set correctly | uncaught exception - ReferenceError: finish is not defined at debugger/test/head.js:113
Duplicate of this bug: 782179
Note that this test was disabled in bug 782179 until we figure out the problem.
Status: REOPENED → RESOLVED
Closed: 7 years ago6 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.