The default bug view has changed. See this FAQ.

fImageTargetTexture2DOES re-added to GLLibraryEGL after being moved to GLContext and renamed to fImageTargetTexture2D

RESOLVED FIXED in mozilla17

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
glImageTargetTexture2D is not an EGL function, and should not live in EGL function land. It also shouldn't have vendor suffixes. Also we shouldn't have two of them.
(Assignee)

Updated

5 years ago
Depends on: 728524
(Assignee)

Updated

5 years ago
Summary: fImageTargetTexture2DOES readded to GLLibraryEGL after being moved to GLContext and renamed to fImageTargetTexture2D → fImageTargetTexture2DOES re-added to GLLibraryEGL after being moved to GLContext and renamed to fImageTargetTexture2D
(Assignee)

Updated

5 years ago
Assignee: nobody → jgilbert
Depends on: 774841
(Assignee)

Comment 1

5 years ago
Created attachment 643560 [details] [diff] [review]
Cleanup: glEGLImageTargetTexture, more extension suffix removal
Attachment #643560 - Flags: review?(bjacob)
(Assignee)

Updated

5 years ago
Blocks: 775278
Attachment #643560 - Flags: review?(bjacob) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4a04cc38326
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla17
(Assignee)

Comment 3

5 years ago
Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76b751e49962
Target Milestone: mozilla17 → ---
(Assignee)

Comment 4

5 years ago
Created attachment 643902 [details] [diff] [review]
patch

Missed a 'mGLContext->' in an ifdef GONK block. :<
Carrying forward r+.
Attachment #643560 - Attachment is obsolete: true
Attachment #643902 - Flags: review+
(Assignee)

Comment 5

5 years ago
Created attachment 644103 [details] [diff] [review]
patch

Now with less bitrot!
Attachment #643902 - Attachment is obsolete: true
Attachment #644103 - Flags: review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/dccfac614c6b
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/dccfac614c6b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.