Last Comment Bug 774059 - fImageTargetTexture2DOES re-added to GLLibraryEGL after being moved to GLContext and renamed to fImageTargetTexture2D
: fImageTargetTexture2DOES re-added to GLLibraryEGL after being moved to GLCont...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Jeff Gilbert [:jgilbert]
:
Mentors:
Depends on: honeycomb-flash 728524 745137 762259 774841
Blocks: 775278
  Show dependency treegraph
 
Reported: 2012-07-15 03:40 PDT by Jeff Gilbert [:jgilbert]
Modified: 2012-07-20 06:42 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Cleanup: glEGLImageTargetTexture, more extension suffix removal (17.10 KB, patch)
2012-07-18 13:36 PDT, Jeff Gilbert [:jgilbert]
jacob.benoit.1: review+
Details | Diff | Review
patch (17.11 KB, patch)
2012-07-19 10:11 PDT, Jeff Gilbert [:jgilbert]
jgilbert: review+
Details | Diff | Review
patch (16.23 KB, patch)
2012-07-19 17:55 PDT, Jeff Gilbert [:jgilbert]
jgilbert: review+
Details | Diff | Review

Description Jeff Gilbert [:jgilbert] 2012-07-15 03:40:43 PDT
glImageTargetTexture2D is not an EGL function, and should not live in EGL function land. It also shouldn't have vendor suffixes. Also we shouldn't have two of them.
Comment 1 Jeff Gilbert [:jgilbert] 2012-07-18 13:36:00 PDT
Created attachment 643560 [details] [diff] [review]
Cleanup: glEGLImageTargetTexture, more extension suffix removal
Comment 3 Jeff Gilbert [:jgilbert] 2012-07-18 15:27:58 PDT
Backed out:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76b751e49962
Comment 4 Jeff Gilbert [:jgilbert] 2012-07-19 10:11:41 PDT
Created attachment 643902 [details] [diff] [review]
patch

Missed a 'mGLContext->' in an ifdef GONK block. :<
Carrying forward r+.
Comment 5 Jeff Gilbert [:jgilbert] 2012-07-19 17:55:19 PDT
Created attachment 644103 [details] [diff] [review]
patch

Now with less bitrot!
Comment 7 Ed Morley [:emorley] 2012-07-20 06:42:17 PDT
https://hg.mozilla.org/mozilla-central/rev/dccfac614c6b

Note You need to log in before you can comment on or make changes to this bug.