Closed
Bug 774081
Opened 13 years ago
Closed 13 years ago
tab curve is slightly overextended
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox15+ verified, firefox16 verified)
VERIFIED
FIXED
Firefox 17
People
(Reporter: jaws, Assigned: sriram)
References
Details
Attachments
(2 files)
|
221.32 KB,
image/png
|
Details | |
|
429.91 KB,
patch
|
mfinkle
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
screenshot of bug
the top of the tab curve starts to curve down on the left side instead of flattening out to merge nicely with the location bar. see attached screenshot of the bug
|
||
Comment 1•13 years ago
|
||
This might be a dupe. I think Sriram just needs some updated resources from Ian.
|
||
Updated•13 years ago
|
tracking-firefox15:
--- → +
|
||
Updated•13 years ago
|
Assignee: nobody → sriram
|
Assignee | |
Comment 3•13 years ago
|
||
This replaces all tab related resources. Hence there won't be any glitches on any device. The layout has to be changed to accomodate the new size of "tab_new" button.
Attachment #643546 -
Flags: review?(mark.finkle)
|
||
Updated•13 years ago
|
Attachment #643546 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
|
||
Updated•13 years ago
|
status-firefox15:
--- → affected
status-firefox16:
--- → affected
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 643546 [details] [diff] [review]
Patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): Moving menu to the right
User impact if declined: HDPI + ICS phones / XHDPI + ICS phones with h/w menu button will have problems in UI.
Testing completed (on m-c, etc.): Landed in m-c on 07/19
Risk to taking this patch (and alternatives if risky): None. This just replaces the resources.
String or UUID changes made by this patch: None.
Attachment #643546 -
Flags: approval-mozilla-beta?
Attachment #643546 -
Flags: approval-mozilla-aurora?
|
||
Comment 7•13 years ago
|
||
Comment on attachment 643546 [details] [diff] [review]
Patch
no risk, resource replacement - approved.
Attachment #643546 -
Flags: approval-mozilla-beta?
Attachment #643546 -
Flags: approval-mozilla-beta+
Attachment #643546 -
Flags: approval-mozilla-aurora?
Attachment #643546 -
Flags: approval-mozilla-aurora+
|
|
Assignee | |
Comment 8•13 years ago
|
||
|
||
Updated•13 years ago
|
|
|
Assignee | |
Comment 9•13 years ago
|
||
|
|
||
Updated•13 years ago
|
|
|
||
Updated•13 years ago
|
Status: RESOLVED → VERIFIED
|
||
Comment 12•12 years ago
|
||
Unable to reproduce the issue on:
Firefox Mobile 16.0b5 / Aurora 16.0a2 2012-09-26/ Nightly 17.0a1 2012-09-27
Samsung Galaxy R (Android 2.3.4)
Marking as verified on Firefox Mobile 16
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•