Closed Bug 77513 Opened 23 years ago Closed 23 years ago

Location Bar Autocomplete checkbox could be shortened.

Categories

(SeaMonkey :: Preferences, defect, P3)

Product:
SeaMonkey
Component:
Preferences
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.7

People

(Reporter: bugs, Assigned: bugs)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

Patch that does what Ben suggested.
1.74 KB, patch
hewitt
: review+
bugs
: superreview+
Details | Diff | Splinter Review
fix
1.03 KB, patch
jag+mozilla
: review+
Details | Diff | Splinter Review 
Preferences dialog, Navigator->Smart Browsing:

Automatically completes text typed into the Location bar.
[x] Enable Location bar autocomplete.

could be shortened to:

[x] Automatically complete text typed into Location bar

(or similar).
I agree, no need to repeat ourselves. Below is a patch that should fix this
(untested).

Index: prefwindow//resources/content/pref-smart_browsing.xul
===================================================================
RCS file:
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-smart_browsing.xul,v
retrieving revision 1.42
diff -u -r1.42 pref-smart_browsing.xul
--- prefwindow//resources/content/pref-smart_browsing.xul       2001/04/12
02:42:08     1.42
+++ prefwindow//resources/content/pref-smart_browsing.xul       2001/04/25 11:36:41
@@ -245,7 +245,6 @@
 
   <titledbox orient="vertical">
     <label value="&autoCompleteHeader.label;"/>
-      <html>&autoCompleteDescription.label;</html>
       <box autostretch="never">
         <checkbox id="browserAutoCompleteEnabled"
label="&autoCompleteEnabled.label;" accesskey="&autoCompleteEnabled.accesskey;"
                   pref="true" preftype="bool"
prefstring="browser.urlbar.autocomplete.enabled"
Index: prefwindow//resources/locale/en-US/pref-smart_browsing.dtd
===================================================================
RCS file:
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-smart_browsing.dtd,v
retrieving revision 1.22
diff -u -r1.22 pref-smart_browsing.dtd
--- prefwindow//resources/locale/en-US/pref-smart_browsing.dtd  2001/04/05
19:53:02     1.22
+++ prefwindow//resources/locale/en-US/pref-smart_browsing.dtd  2001/04/25 11:36:41
@@ -30,6 +30,5 @@
 
 
 <!ENTITY  autoCompleteHeader.label          "Location Bar Autocomplete">
-<!ENTITY  autoCompleteDescription.label     "Automatically completes text typed
into the Location bar.">
-<!ENTITY  autoCompleteEnabled.label                 "Enable Location bar
autocomplete">
+<!ENTITY  autoCompleteEnabled.label     "Automatically complete text typed into
Location bar.">
 <!ENTITY  autoCompleteEnabled.accesskey             "l">

Attaching it inline didn't work to well. Below is the patch attached instead.
Comment on attachment 32139 [details] [diff] [review]
Patch that does what Ben suggested.

[s]r=ben@netscape.com
Attachment #32139 - Flags: superreview+
need review.
Status: NEW → ASSIGNED
Keywords: patch, review
Target Milestone: --- → mozilla0.9.7
Priority: -- → P3
Comment on attachment 32139 [details] [diff] [review]
Patch that does what Ben suggested.

r=hewitt
Attachment #32139 - Flags: review+
fixed.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
hm, the text for the checkbox here is actually longer than the previous text.

now the Smart Browsing panel appears clipped on the right side --at least on
linux rh7.2 and mac 10.1.1 with the modern theme.

reopening --unless what i'm seeing is a different issue [i'll file a new bug if
necessary].
Blocks: 80392
Status: RESOLVED → REOPENED
Keywords: patch, review → regression
Resolution: FIXED → ---
Comment on attachment 60134 [details] [diff] [review]
fix

r=jag
Attachment #60134 - Flags: review+
joe sez sr=hewitt
Status: REOPENED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
looks good! tested on linux rh7.2 and mac 10.1.1 modern theme, with
2001.12.05-comm bits.
Status: RESOLVED → VERIFIED
*** Bug 112995 has been marked as a duplicate of this bug. ***
No longer blocks: 80392
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: