775601 - Re-enable section editing

Status: RESOLVED INCOMPLETE

(developer.mozilla.org Graveyard :: Wiki pages, defect, P1)

Description

[John Karahalis [:openjck]]

In bug 774449, we are planning to temporarily disable section editing before the Kuma launch, as it is causing some problems.

This bug is about re-enabling section editing after the launch. We will want to resolve all major section editing issues (listed as dependencies) before doing this.

Comment 2

[John Karahalis [:openjck]]

This will be possible after we resolve bug 771686, bug 772898 and bug 774186. Removing these as dependencies, as we now use dependencies for subtasks.

Comment 3

[Eric Shepherd [:sheppy]]

The work should be done, says ubernostrom, so let's turn it on! We're doing a lot of intricate work on updating small bits of large articles in preparation for MWC and not having section editing is hurting productivity a lot.

Comment 4

[David Walsh :davidwalsh]

On it.

Comment 5

[David Walsh :davidwalsh]

After displaying the buttons I found that the server-side functionality of section editing is not working, even on en-US docs.

The content correctly loads into the WYSIWYG but upon submission, the request returns a 302 (instead of the section content).  Upon refreshing the page, the edits are *not* visible and thus must not have been saved.

Through doing a number of logging.debug statements, I've found that the edit_document definition does return the correct URL to retrieve content from, but I'm not sure why that response is being given (I'd think we'd just dump the new content).

Within forms.py, the "self.cleaned_data['content']" within clean_content represents the new changed section (which is good), but the content returned by that method is incorrect-- the old content is returned.

My branch which displays section editing buttons is here:

https://github.com/darkwing/kuma/tree/775601-section-editing

Comment 6

[John Karahalis [:openjck]]

Superseded by bug 839559, which has a full specification.