772898 - Section editing removes TOC and all tags

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect, P1)

Description

[Louis-Rémi BABE]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/16.0 Firefox/16.0
Build ID: 20120703030538

Steps to reproduce:

I edited a specific section of a page.


Actual results:

After saving my changes and reloading the page, the TOC of the page was lost.


Expected results:

I want my TOC back!

Comment 1

[Jean-Yves Perrier [:teoli]]

Ha! That explains the vanishing TOCs that I was discovering!

Comment 2

[Eric Shepherd [:sheppy]]

Whoa. I assumed this was just cosmetic, but it's not. Weeeird! This needs to be investigated before launch.

Comment 4

[John Karahalis [:openjck]]

Janet provided some very good steps to repeat here:
https://bugzilla.mozilla.org/show_bug.cgi?id=775385#c0

Comment 5

[John Karahalis [:openjck]]

Jean-Yves in bug 775385:
> Note that the TOC is removed, but also all the tags :-(

Editing the title accordingly.

Comment 6

[Eric Shepherd [:sheppy]]

This is a fairly serious problem; we're gradually messing up the site by doing this. We also need to figure out how to fix all the pages that have been messed up.

Comment 7

[John Karahalis [:openjck]]

Planning to temporarily disable section editing (see bug 774449) before launch to avoid this and a bunch of other bugs related to section editing.

Also, I opened bug 775625 about fixing pages that have already been messed up.

Comment 8

[James Bennett [:ubernostrum]]

So, some quick notes on what's going on here.

The problem seems to stem from the fact that section editing doesn't submit all the metadata fields, but the form expects them; when it sees the submission, it thinks "no tags submitted, no ToC checkbox", and generates a new Revision accordingly.

Solution is going to be

1. Making the save code aware of section editing (not terribly hard because the form knows if it's editing a section or the full document), in bug 823733,

2. Reworking the section-editing unit tests to accommodate and exercise that (bug 826438),

3. For good measure, disabling the ability to do a "full-page" section edit, leaving only the inline version, since having both requires the code to be way more complicated (and may not even be possible since they'd be showing incompatible things for a single code path). That's bug 826444.

Comment 9

[James Bennett [:ubernostrum]]

Section editing still has issues, but the ones in this specific bug have been cleared up AFAIK.