Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Share panel profile information doesn't appear in the first window, doesn't look great on Mac

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: jaws)

Tracking

Trunk
Firefox 17
All
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fx16])

Attachments

(1 attachment, 1 obsolete attachment)

Combining two minor issues into one, to minimize aurora-uplift-tracking pain!

- The share panel profile information block is only updated on window load, so if the provider sends the profile data after that, it doesn't get updated. In practice, this means it doesn't really ever show up in the first window.

- When it does show up, on Mac, it doesn't look great, because the text is black-on-grey: http://cl.ly/image/081K3H3s1s3J
Whiteboard: [fx16]
Created attachment 644824 [details] [diff] [review]
fix the updating issue

This fixes the first issue.
The second issue looks to be because -moz-appearance:none on an OSX button still keeps the font color black.

See here: https://mxr.mozilla.org/mozilla-central/source/browser/themes/pinstripe/browser.css#1270

Either hard-coding white, or some other solution will be needed here for OSX.
Created attachment 645608 [details] [diff] [review]
Patch

This includes the fixes for both parts of this bug.

The |color:#fff;| is the same that is used by @hudButton@ which is referenced by the #identity-popup-more-info-button so I think it will be OK to use here.
Attachment #644824 - Attachment is obsolete: true
Attachment #645608 - Flags: review?(gavin.sharp)
Attachment #645608 - Flags: review?(gavin.sharp) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/673e19fc23eb
Flags: in-testsuite-
Target Milestone: --- → Firefox 17

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/673e19fc23eb
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 786207
You need to log in before you can comment on or make changes to this bug.