786207 - Display name in share panel is white on gray on OS X

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

See http://hg.mozilla.org/mozilla-central/file/8af2ff9c6018/browser/themes/pinstripe/browser.css#l1264

Now that bug 771284 landed, the share panel shows a white display name on a gray background. We should now switch this to use the standard color.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: recommend panel.patch

This fixes the font color as well as aligning the username with other text.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 657479 [details] [diff] [review]
recommend panel.patch

Review of attachment 657479 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/pinstripe/browser.css
@@ +1269,5 @@
>    font-weight: bold;
>  }
>  
>  #socialUserDisplayName > .button-box {
> +  -moz-margin-start: -5px;

Why is this necessary? Instead of using a negative margin here, is there a positive margin or padding elsewhere that can be removed?

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: recommend panel.patch

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 658194 [details] [diff] [review]
recommend panel.patch

[Approval Request Comment]
issue affects aurora, minor change to get the right packing and color of the username

Comment 5

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e30a0c22e414

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e30a0c22e414

Comment 7

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e253875d797f

Comment 8

[u279076]

Is this something that can/should be automated?

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #8)
> Is this something that can/should be automated?

The cost/benefit here wouldn't be worth it.

Comment 10

[u279076]

Thanks Jared, flagging [qa-].