Closed Bug 786207 Opened 8 years ago Closed 8 years ago

Display name in share panel is white on gray on OS X

Categories

(Firefox Graveyard :: SocialAPI, defect)

17 Branch
All
macOS
defect
Not set
normal

Tracking

(firefox17 fixed)

VERIFIED FIXED
Firefox 18
Tracking Status
firefox17 --- fixed

People

(Reporter: jaws, Assigned: mixedpuppy)

References

Details

(Whiteboard: [Fx17][qa-])

Attachments

(1 file, 1 obsolete file)

See http://hg.mozilla.org/mozilla-central/file/8af2ff9c6018/browser/themes/pinstripe/browser.css#l1264

Now that bug 771284 landed, the share panel shows a white display name on a gray background. We should now switch this to use the standard color.
Attached patch recommend panel.patch (obsolete) — Splinter Review
This fixes the font color as well as aligning the username with other text.
Attachment #657479 - Flags: review?(jaws)
Assignee: nobody → mixedpuppy
Comment on attachment 657479 [details] [diff] [review]
recommend panel.patch

Review of attachment 657479 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/pinstripe/browser.css
@@ +1269,5 @@
>    font-weight: bold;
>  }
>  
>  #socialUserDisplayName > .button-box {
> +  -moz-margin-start: -5px;

Why is this necessary? Instead of using a negative margin here, is there a positive margin or padding elsewhere that can be removed?
Attachment #657479 - Attachment is obsolete: true
Attachment #657479 - Flags: review?(jaws)
Attachment #658194 - Flags: review?(jaws)
Attachment #658194 - Flags: review?(jaws) → review?(felipc)
Attachment #658194 - Flags: review?(felipc) → review+
Keywords: checkin-needed
Comment on attachment 658194 [details] [diff] [review]
recommend panel.patch

[Approval Request Comment]
issue affects aurora, minor change to get the right packing and color of the username
Attachment #658194 - Flags: approval-mozilla-aurora?
Attachment #658194 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/e30a0c22e414
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Is this something that can/should be automated?
Flags: in-testsuite?
Whiteboard: [Fx17] → [Fx17][qa?]
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #8)
> Is this something that can/should be automated?

The cost/benefit here wouldn't be worth it.
Status: RESOLVED → VERIFIED
Thanks Jared, flagging [qa-].
Whiteboard: [Fx17][qa?] → [Fx17][qa-]
Flags: in-testsuite? → in-testsuite-
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.