776919 - Old reviews are replaced with the newly added reviews.

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Victor Carciu]

Prerequisites:
 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0

Steps to reproduce:
1.Go to MP and open an app with one review already added : https://marketplace-dev.allizom.org/app/campfire-7/reviews/
2.Submit a new review

Expected results:
Both reviews are displayed.

Actual results:
The old review is replaced by the new review.

Please see screencast for this bug: http://screencast.com/t/zOmdL0xWTMk

NOTES:
Possible cache issue. After 5 minutes and a refresh, both reviews are displayed.
Not able to reproduce for apps with more than one review already added.

Comment 1

[krupa raj[:krupa]]

This is by design. We decided to only show the latest review in Marketplace.

Comment 2

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj 82[:krupa] from comment #1)
> This is by design. We decided to only show the latest review in Marketplace.

Compare the first review (http://cl.ly/image/2Q012W3l1543) with the second review (http://cl.ly/image/1t22010B0U1o). They're by different authors.

Comment 3

[Kevin Ngo [:ngoke]]

i'm confused, what do the different authors mean?

Comment 4

[Victor Carciu]

The issue is that a review from an author is replacing an already posted review submitted by another author.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

(In reply to Victor Carciu from comment #4)
> The issue is that a review from an author is replacing an already posted
> review submitted by another author.

I saw this happen once, but I can't get reliable steps to reproduce. Can you help me here? Thanks!

Comment 6

[Victor Carciu]

I investigated the case and it is difficult to reproduce this bug, but I think that the issue is reproducible for the reviewed apps for which the user never added \edited\ deleted any review before.
Please let me know if this info is helpful, else I will investigate more.

Comment 7

[Christopher Van Wiemeersch [:cvan]]

I just saw Krupa reproduce this. The reviews are for some reason being *hidden* on the Reviews listing page (but appear on detail page). Curious bug.

Comment 8

[Matt Basta [:basta]]

Hidden like `display:none` hidden or hidden like the query set isn't returning them hidden?

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Blocker for reviews to go live this week.

Comment 10

[Christopher Van Wiemeersch [:cvan]]

I need help reproducing this. Victor, Krupa, anything you can hint towards for reliable STR will help. No luck for me! Thanks.

Comment 11

[krupa raj[:krupa]]

I tried but couldn't reproduce this issue anymore. Victor?

Comment 12

[Cristian Boldan]

I was also able to reproduce this issue by adding a review for an app that I haven't added any review in the past. As you can see in the screencast, the review from Krupa (the last one) dissapeared, and reappeared only after a few page reloads http://screencast.com/t/FrduHMsu8VN

Comment 13

[Matt Basta [:basta]]

Cristian: What kind of user were you logged in as when you reproduced the issue?

Comment 14

[Cristian Boldan]

As you can see in the screencast, I was using an admin user. But I was also able to reproduce this using a normal user. Please see screencast http://screencast.com/t/BBQFrnO3z

Comment 15

[krupa raj[:krupa]]

STR:
1. Pick an app which has no ratings. 
2. Add a review as user 1. 
3. Now as user 2, add a review from the "All reviews" page keeping the same rating as the first one.

Comment 16

[Christopher Van Wiemeersch [:cvan]]

Without caching, this is not a problem.

Cause: https://github.com/jbalogh/django-cache-machine/issues/6

Comment 17

[Kumar McMillan [:kumar]]

Hey guys, let's clarify the issue here. Old reviews are not replaced with newly added reviews. It's just that one user may not see *all* reviews immediately. After 5 minutes or so, all reviews are visible. No data is lost.

This is a side effect of our caching strategy which we need to minimize database usage. It is hard to fix because there's no easy way to invalidate the cache in cases like this. See https://github.com/jbalogh/django-cache-machine/issues/6

Since the reviews are eventually consistent and no harm is done, can we close this issue? Thanks for all the work investigating it.

Comment 18

[Christopher Van Wiemeersch [:cvan]]

Bug in django-cache-machine, so removing myself ;)

Comment 19

[Wil Clouser [:clouserw]]

I'm going to close this bug as WONTFIX.  If I could mark it as a duplicate of the github issue I would, but there is no reason to track this in two places.

As Kumar mentioned in comment 17, this isn't actually destructive, just different info shows up on the page for a few minutes.